Message ID | 20250417043427.1205626-1-faraz.ata@samsung.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | [v3] tty: serial: samsung_tty: support 18 uart ports | expand |
On 17/04/2025 06:34, Faraz Ata wrote: > ExynosAutov920 SoC supports 18 UART ports, update > the value of UART_NR to accommodate the same. > > Signed-off-by: Faraz Ata <faraz.ata@samsung.com> > --- > Changes in v3: > - Fixed review comments from Krzysztof Which ones? What changed? Best regards, Krzysztof
Hello Krzysztof > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, April 17, 2025 10:50 AM > To: Faraz Ata <faraz.ata@samsung.com>; alim.akhtar@samsung.com; > gregkh@linuxfoundation.org; jirislaby@kernel.org > Cc: linux-arm-kernel@lists.infradead.org; linux-samsung- > soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > serial@vger.kernel.org; dev.tailor@samsung.com; rosa.pila@samsung.com > Subject: Re: [PATCH v3] tty: serial: samsung_tty: support 18 uart ports > > On 17/04/2025 06:34, Faraz Ata wrote: > > ExynosAutov920 SoC supports 18 UART ports, update the value of > UART_NR > > to accommodate the same. > > > > Signed-off-by: Faraz Ata <faraz.ata@samsung.com> > > --- > > Changes in v3: > > - Fixed review comments from Krzysztof > > Which ones? What changed? > While sending v2 change log was missed unintentionally. Added missed change log in v3. > > Best regards, > Krzysztof
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 210fff7164c1..9a5211b730fb 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -52,7 +52,7 @@ #define S3C24XX_SERIAL_MINOR 64 #ifdef CONFIG_ARM64 -#define UART_NR 12 +#define UART_NR 18 #else #define UART_NR CONFIG_SERIAL_SAMSUNG_UARTS #endif
ExynosAutov920 SoC supports 18 UART ports, update the value of UART_NR to accommodate the same. Signed-off-by: Faraz Ata <faraz.ata@samsung.com> --- Changes in v3: - Fixed review comments from Krzysztof - Link to v2: https://patchwork.kernel.org/project/linux-samsung-soc/patch/20250404135006.1263827-1-faraz.ata@samsung.com/ Changes in v2: - Rebased on the latest linux-next and added reviewers as per get_maintainer - Link to v1: https://patchwork.kernel.org/project/linux-samsung-soc/patch/20250312061932.1797993-1-faraz.ata@samsung.com/ drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)