From patchwork Mon Jul 14 11:23:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 4544731 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B3C179F295 for ; Mon, 14 Jul 2014 11:23:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D97D020136 for ; Mon, 14 Jul 2014 11:23:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C311420131 for ; Mon, 14 Jul 2014 11:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754113AbaGNLXy (ORCPT ); Mon, 14 Jul 2014 07:23:54 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:58473 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbaGNLXx (ORCPT ); Mon, 14 Jul 2014 07:23:53 -0400 Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue005) with ESMTP (Nemesis) id 0MMrhT-1XDUmx2N3P-008Wyj; Mon, 14 Jul 2014 13:23:48 +0200 From: Arnd Bergmann To: kgene.kim@samsung.com Cc: Chander Kashyap , Tomasz Figa , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] cpuidle: big.LITTLE: add MCPM dependency Date: Mon, 14 Jul 2014 13:23:47 +0200 Message-ID: <4345351.RJRQd7ghCF@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V02:K0:57pmpfZ3ex2KOmbzKHgCwSXuXdeKqP3wS2/ObM1IgUg GBFJ56l8jrVlhnMQmMidIgvDEoKKnQGJNPoyUwzFE4sina8yir dE9E2OaeV/4gyT86WTq9mXX5JYi+eoBkxUC81Z9s+FAehieTXt 11YB3thmg3wa4EHeCr/0fAjhy/S0z2n1BrIjn7tvS+fg93I0+B L2F9lzuzYZaZObpvgKxrPyLNAFTEC0odhTAjzFTXT3S2pvJu4X fFUjF1YQjEANNgNU5eLB2GssLQ8Q5JUkpwSHGW4gB2DGfteUXY VEShEp5Cpr7u64vi5IrIF/OcbqRYLtrvKPVmwZn60Q6FRGcPwT 2JKxzkR3b2aFBPNP7fmE= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 662322fcb6d ("cpuidle: big.LITTLE: Add ARCH_EXYNOS entry in config") made it possible for the big-little cpuidle driver to run on exynos, which may or may not include MCPM support at compile time, so we run into a link error when it is disabled: drivers/built-in.o: In function `bl_enter_powerdown': :(.text+0x1889a0): undefined reference to `mcpm_cpu_powered_up' drivers/built-in.o: In function `bl_powerdown_finisher': :(.text+0x1889e8): undefined reference to `mcpm_set_entry_vector' :(.text+0x1889ec): undefined reference to `mcpm_cpu_suspend' This adds an explicit dependency to CONFIG_MCPM to avoid that case. Signed-off-by: Arnd Bergmann Cc: Chander Kashyap Cc: Tomasz Figa Cc: Daniel Lezcano Acked-by: Nicolas Pitre --- I believe the broken commit is only present in the samsung/for-next tree (through v3.17-next/cpuidle-exynos), so it should be fixed there. On a side note, I wonder if we should have platform dependencies at all, or just the MCPM dependency by itself. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm index 2f6b33ea6e08..459b7c91407a 100644 --- a/drivers/cpuidle/Kconfig.arm +++ b/drivers/cpuidle/Kconfig.arm @@ -10,6 +10,7 @@ config ARM_ARMADA_370_XP_CPUIDLE config ARM_BIG_LITTLE_CPUIDLE bool "Support for ARM big.LITTLE processors" depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS + depends on MCPM select ARM_CPU_SUSPEND select CPU_IDLE_MULTIPLE_DRIVERS help