From patchwork Wed Apr 16 18:14:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 4003481 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F41959F336 for ; Wed, 16 Apr 2014 18:15:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1DAA520351 for ; Wed, 16 Apr 2014 18:15:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FE6E2034F for ; Wed, 16 Apr 2014 18:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754206AbaDPSPK (ORCPT ); Wed, 16 Apr 2014 14:15:10 -0400 Received: from moutng.kundenserver.de ([212.227.126.130]:55781 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083AbaDPSPJ (ORCPT ); Wed, 16 Apr 2014 14:15:09 -0400 Received: from wuerfel.localnet (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue007) with ESMTP (Nemesis) id 0MgUqY-1WLavy0Mvm-00NefQ; Wed, 16 Apr 2014 20:14:28 +0200 From: Arnd Bergmann To: Tomasz Figa , Mark Brown Cc: Thomas Abraham , "linux-arm-kernel@lists.infradead.org" , Sachin Kamat , Kukjin Kim , "linux-samsung-soc@vger.kernel.org" , Thomas Abraham , Thomas Abraham , Sangsu Park , Sangbeom Kim , Padmavathi Venna Subject: Re: [PATCH 5/6] ARM: EXYNOS: Enable multi-platform build support Date: Wed, 16 Apr 2014 20:14:27 +0200 Message-ID: <5094962.iM2Kd6gfjd@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.11.0-18-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <534E9AA3.10409@samsung.com> References: <1397554134-11827-1-git-send-email-sachin.kamat@linaro.org> <534E9AA3.10409@samsung.com> MIME-Version: 1.0 X-Provags-ID: V02:K0:HrAVdPKDXl25SYz1qbBoia1XYpkGXwe1VijmXaCf+8C tr8tKBTw+e6JYRwOW/gN4UV/51IEElnrl1bYXGb6120I7+Wsi1 Bt8W5uXhRce9/FFeIU3ABTtzKHVGpHKn7uc0NG2pvlsLoV4KJE TGsBBlne/LacWkHh0IV8L/gsucWf4H/77zqnCEpWs4X6hRj7+y yH5cuZsIBUup9bKW+zYfGYAXvnL9IxteLmbNqcVG1ze16d7KFU QklY/uWPRmcu7o8mwN344AYgxPcQUcHtManoJDRSV6lCXZ2Oge 8v+ND1lsAsnIcBhk9PiIWYIIWWZuV5n98JV/NyVz3MjoMwG8AQ jS62xIWfEKN/ZMDCVu7o= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wednesday 16 April 2014 16:58:43 Tomasz Figa wrote: > On 16.04.2014 16:55, Thomas Abraham wrote: > > On Wed, Apr 16, 2014 at 8:18 PM, Tomasz Figa wrote: > >> On 16.04.2014 16:31, Arnd Bergmann wrote: > >>> sparsemem is still not supported in multiplatform, but after I looked > >>> at it in more detail, I came to the conclusion that there is no > >>> reason why it couldn't be. It just needs testing so we are confident > >>> that it doesn't break other platforms, and we need to find good > >>> platform-independent values for MAX_PHYSMEM_BITS and SECTION_SIZE_BITS > >>> to put into asm/memory.h, since we can't have them set in mach/memory.h > >>> for multiplatform. > >>> > >>> Looking at my patch again now, I would actually prefer to kill off > >>> the single-platform support for exynos right away. I don't see > >>> any reason to keep it now, and it complicates the test matrix. > >> > >> > >> That would be the best option, assuming that it wouldn't introduce feature > >> regressions. Unfortunately there is still ongoing work on cpufreq driver to > >> make it multiplatform-aware, so dropping single platform support right now > >> would introduce at least this one regression. > >> > >> Thomas, is there any progress on new version of Exynos cpufreq rework > >> series? > > > > Hi Tomasz, > > > > Yes, I am preparing the fourth version of the cpufreq patches and will > > post it next week. Mostly, the changes will be addressing your review > > comments. > > OK. Looking forward to it. Thanks for an update on this. > Cool! This is the only major issue I'm aware of, so I think we're good. If SPARSEMEM support is still relevant to anybody, I'm sure we can get that to work as well. There is one small issue with the sound drivers that came up, and I assume it was just a mistake. If not, some more work on that might be needed. See patch below. Arnd 8<------- From 6f3921c3218509114e855a8ea5932aeea5d3ddfd Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Tue, 18 Mar 2014 17:04:59 +0100 Subject: [PATCH] ASoC: samsung: don't build pcm and spdif on exynos In commit d37bdf736d9b "ASoC: samsung: Use ASoC dmaengine code where possible", Mark Brown changed the EXYNOS ASoC code to no longer use the private dma interfaces that are standing in the way of multiplatform enablement. However, in 313367e7bfa "ASoC: Samsung: Update Kconfig for I2S,SPDIF and PCM audio", two new users of that interface appeared, since it is now possible to enable SND_SOC_SAMSUNG_SMDK_SPDIF and SND_SOC_SMDK_WM8994_PCM on all Samsung SoCs including EXYNOS. This patch does a partial revert of 313367e7bfa by allowing these drivers on all samsung platforms except EXYNOS, so we can proceed with the multiplatform patches. If support for these drivers is actually needed on EXYNOS machines, the drivers should first be moved over to use the dmaengine code. Signed-off-by: Arnd Bergmann Cc: Sangsu Park Cc: Sangbeom Kim Cc: Padmavathi Venna Cc: Mark Brown --- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 7b610a8..efc01e0 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -167,7 +167,7 @@ config SND_SOC_GONI_AQUILA_WM8994 config SND_SOC_SAMSUNG_SMDK_SPDIF tristate "SoC S/PDIF Audio support for SMDK" - depends on SND_SOC_SAMSUNG + depends on SND_SOC_SAMSUNG && !ARCH_EXYNOS select SND_SAMSUNG_SPDIF help Say Y if you want to add support for SoC S/PDIF audio on the SMDK. @@ -183,7 +183,7 @@ config SND_SOC_SMDK_WM8580_PCM config SND_SOC_SMDK_WM8994_PCM tristate "SoC PCM Audio support for WM8994 on SMDK" - depends on SND_SOC_SAMSUNG + depends on SND_SOC_SAMSUNG && !ARCH_EXYNOS depends on I2C=y select MFD_WM8994 select SND_SOC_WM8994