| Message ID | 5137B183.6040201@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/06/2013 10:13 PM, Sylwester Nawrocki wrote: > @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = { > #ifdef CONFIG_S5P_DEV_FIMD0 > static struct resource s5p_fimd0_resource[] = { > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), > - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC), > - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO), > - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM), > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"), > + [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO, "fifo"), > + [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM, "system"), > }; Oops, something missing here. Of course should be: @@ -160,9 +160,9 @@ struct platform_device samsung_asoc_idma = { #ifdef CONFIG_S3C_DEV_FB static struct resource s3c_fb_resource[] = { [0] = DEFINE_RES_MEM(S3C_PA_FB, SZ_16K), - [1] = DEFINE_RES_IRQ(IRQ_LCD_VSYNC), - [2] = DEFINE_RES_IRQ(IRQ_LCD_FIFO), - [3] = DEFINE_RES_IRQ(IRQ_LCD_SYSTEM), + [1] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_VSYNC, "vsync"), + [2] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_FIFO, "fifo"), + [3] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_SYSTEM, "system"), -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sylwester Nawrocki wrote: > > On 03/06/2013 10:13 PM, Sylwester Nawrocki wrote: > > @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = { > > #ifdef CONFIG_S5P_DEV_FIMD0 > > static struct resource s5p_fimd0_resource[] = { > > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), > > - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC), > > - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO), > > - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM), > > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"), > > + [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO, "fifo"), > > + [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM, "system"), > > }; > > Oops, something missing here. Of course should be: > > @@ -160,9 +160,9 @@ struct platform_device samsung_asoc_idma = { > #ifdef CONFIG_S3C_DEV_FB > static struct resource s3c_fb_resource[] = { > [0] = DEFINE_RES_MEM(S3C_PA_FB, SZ_16K), > - [1] = DEFINE_RES_IRQ(IRQ_LCD_VSYNC), > - [2] = DEFINE_RES_IRQ(IRQ_LCD_FIFO), > - [3] = DEFINE_RES_IRQ(IRQ_LCD_SYSTEM), > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_VSYNC, "vsync"), > + [2] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_FIFO, "fifo"), > + [3] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_SYSTEM, "system"), ^^^^^^^ BTW, can you use 'tab' instead of white space at mark '^' - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 7 March 2013 02:43, Sylwester Nawrocki <sylvester.nawrocki@gmail.com> wrote: > On 03/06/2013 11:18 AM, Vikas Sajjan wrote: >> >> Good idea, but i am just wondering is it a good idea to modify the >> fimd driver ? > > > I think it is. But it depends what code quality you aim for. > > Is there any issue in making a change as below ? ;) Certainly no issue :-) Will check this idea both on exyno4 and exynos5 and shall update. > > Of course it's all up to you, I've just suggested what I thought was > an improvement to the current situation. > > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c > index 51afedd..4180247 100644 > --- a/arch/arm/plat-samsung/devs.c > +++ b/arch/arm/plat-samsung/devs.c > @@ -160,9 +160,9 @@ struct platform_device samsung_asoc_idma = { > #ifdef CONFIG_S3C_DEV_FB > static struct resource s3c_fb_resource[] = { > [0] = DEFINE_RES_MEM(S3C_PA_FB, SZ_16K), > - [1] = DEFINE_RES_IRQ(IRQ_LCD_VSYNC), > - [2] = DEFINE_RES_IRQ(IRQ_LCD_FIFO), > - [3] = DEFINE_RES_IRQ(IRQ_LCD_SYSTEM), > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_VSYNC, "vsync"), > + [2] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_FIFO, "fifo"), > + [3] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_SYSTEM, "system"), > }; > > struct platform_device s3c_device_fb = { > @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = { > #ifdef CONFIG_S5P_DEV_FIMD0 > static struct resource s5p_fimd0_resource[] = { > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), > - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC), > - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO), > - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM), > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"), > + [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO, "fifo"), > + [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM, "system"), > }; > > struct platform_device s5p_device_fimd0 = { > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 36493ce..5efb4c7 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -917,7 +917,7 @@ static int fimd_probe(struct platform_device *pdev) > if (IS_ERR(ctx->regs)) > return PTR_ERR(ctx->regs); > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); > if (!res) { > dev_err(dev, "irq request failed.\n"); > return -ENXIO; > diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c > index 968a625..43af0108 100644 > --- a/drivers/video/s3c-fb.c > +++ b/drivers/video/s3c-fb.c > @@ -1427,7 +1427,7 @@ static int s3c_fb_probe(struct platform_device *pdev) > goto err_lcd_clk; > } > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); > if (!res) { > dev_err(dev, "failed to acquire irq resource\n"); > ret = -ENOENT;
diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c index 51afedd..4180247 100644 --- a/arch/arm/plat-samsung/devs.c +++ b/arch/arm/plat-samsung/devs.c @@ -160,9 +160,9 @@ struct platform_device samsung_asoc_idma = { #ifdef CONFIG_S3C_DEV_FB static struct resource s3c_fb_resource[] = { [0] = DEFINE_RES_MEM(S3C_PA_FB, SZ_16K), - [1] = DEFINE_RES_IRQ(IRQ_LCD_VSYNC), - [2] = DEFINE_RES_IRQ(IRQ_LCD_FIFO), - [3] = DEFINE_RES_IRQ(IRQ_LCD_SYSTEM), + [1] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_VSYNC, "vsync"), + [2] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_FIFO, "fifo"), + [3] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_SYSTEM, "system"), }; struct platform_device s3c_device_fb = { @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = { #ifdef CONFIG_S5P_DEV_FIMD0 static struct resource s5p_fimd0_resource[] = { [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC), - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO), - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM), + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"), + [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO, "fifo"), + [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM, "system"), }; struct platform_device s5p_device_fimd0 = { diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 36493ce..5efb4c7 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -917,7 +917,7 @@ static int fimd_probe(struct platform_device *pdev) if (IS_ERR(ctx->regs)) return PTR_ERR(ctx->regs); - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); if (!res) { dev_err(dev, "irq request failed.\n"); return -ENXIO; diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c index 968a625..43af0108 100644 --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c @@ -1427,7 +1427,7 @@ static int s3c_fb_probe(struct platform_device *pdev) goto err_lcd_clk; } - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); if (!res) { dev_err(dev, "failed to acquire irq resource\n"); ret = -ENOENT;