From patchwork Wed Mar 6 21:13:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 2228251 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 534A8DF23A for ; Wed, 6 Mar 2013 21:13:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971Ab3CFVNt (ORCPT ); Wed, 6 Mar 2013 16:13:49 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:47252 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551Ab3CFVNt (ORCPT ); Wed, 6 Mar 2013 16:13:49 -0500 Received: by mail-we0-f172.google.com with SMTP id d46so4439916wer.31 for ; Wed, 06 Mar 2013 13:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QvaCA2C4YrAbVe8zPhE2DMJas03OqkbeMN99cWgZHR8=; b=He7tx3WumF7P63LRgS5yJ3OH6lJFQ8min6a4dAv2lTLN+MZrcBT2MikatqusB0myS+ ZZAVkVqtwxcG/CuTUpdFos+lfpSmvlGcRkgNcpiVel2nPkLpw+Wy1wV7w7PbqZIY2m1Z CeOeJF+gGPZz71fIC56HlHPFuIUKM/1cH4QsNq1WiN74o6XphXl2RdUmwDk1qmkoOmAA HMY0RbvBmpQ4DbSk/qWHtMbH4Xeocmw9neDRBuLk7AkX1a0JUeENF5Swv5GnQ86zHeYd rvphDf/hcJ6m9q6MD1puSXtVXfEYydPjvcZzP28o+lHBaIwdCOPDU99NdTtn2c5kRcd5 JRLA== X-Received: by 10.194.6.2 with SMTP id w2mr50014860wjw.10.1362604428051; Wed, 06 Mar 2013 13:13:48 -0800 (PST) Received: from [192.168.1.110] (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPS id bj9sm29453478wib.4.2013.03.06.13.13.45 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 06 Mar 2013 13:13:46 -0800 (PST) Message-ID: <5137B183.6040201@gmail.com> Date: Wed, 06 Mar 2013 22:13:39 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 MIME-Version: 1.0 To: Vikas Sajjan CC: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, sachin.kamat@linaro.org, t.figa@samsung.com, devicetree-discuss@lists.ozlabs.org, inki.dae@samsung.com, jy0922.shim@samsung.com, sunil joshi Subject: Re: [PATCH v6 5/5] ARM: dts: Add FIMD DT binding Documentation References: <1362044559-7496-1-git-send-email-vikas.sajjan@linaro.org> <1362044559-7496-6-git-send-email-vikas.sajjan@linaro.org> <5133A068.7060906@gmail.com> In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 03/06/2013 11:18 AM, Vikas Sajjan wrote: > Good idea, but i am just wondering is it a good idea to modify the > fimd driver ? I think it is. But it depends what code quality you aim for. Is there any issue in making a change as below ? ;) Of course it's all up to you, I've just suggested what I thought was an improvement to the current situation. --- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c index 51afedd..4180247 100644 --- a/arch/arm/plat-samsung/devs.c +++ b/arch/arm/plat-samsung/devs.c @@ -160,9 +160,9 @@ struct platform_device samsung_asoc_idma = { #ifdef CONFIG_S3C_DEV_FB static struct resource s3c_fb_resource[] = { [0] = DEFINE_RES_MEM(S3C_PA_FB, SZ_16K), - [1] = DEFINE_RES_IRQ(IRQ_LCD_VSYNC), - [2] = DEFINE_RES_IRQ(IRQ_LCD_FIFO), - [3] = DEFINE_RES_IRQ(IRQ_LCD_SYSTEM), + [1] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_VSYNC, "vsync"), + [2] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_FIFO, "fifo"), + [3] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_SYSTEM, "system"), }; struct platform_device s3c_device_fb = { @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = { #ifdef CONFIG_S5P_DEV_FIMD0 static struct resource s5p_fimd0_resource[] = { [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC), - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO), - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM), + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"), + [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO, "fifo"), + [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM, "system"), }; struct platform_device s5p_device_fimd0 = { diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 36493ce..5efb4c7 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -917,7 +917,7 @@ static int fimd_probe(struct platform_device *pdev) if (IS_ERR(ctx->regs)) return PTR_ERR(ctx->regs); - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); if (!res) { dev_err(dev, "irq request failed.\n"); return -ENXIO; diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c index 968a625..43af0108 100644 --- a/drivers/video/s3c-fb.c +++ b/drivers/video/s3c-fb.c @@ -1427,7 +1427,7 @@ static int s3c_fb_probe(struct platform_device *pdev) goto err_lcd_clk; } - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync"); if (!res) { dev_err(dev, "failed to acquire irq resource\n"); ret = -ENOENT;