From patchwork Fri Dec 18 14:46:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7885901 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 43D5D9F1AF for ; Fri, 18 Dec 2015 14:47:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 639302049C for ; Fri, 18 Dec 2015 14:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 843B62044C for ; Fri, 18 Dec 2015 14:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753811AbbLROrM (ORCPT ); Fri, 18 Dec 2015 09:47:12 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:56948 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753433AbbLROrL (ORCPT ); Fri, 18 Dec 2015 09:47:11 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0M9ulU-1a3Mj51Ryy-00B2r0; Fri, 18 Dec 2015 15:46:59 +0100 From: Arnd Bergmann To: Kukjin Kim , Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] ARM: s3c64xx: fix pm-debug compilation Date: Fri, 18 Dec 2015 15:46:54 +0100 Message-ID: <5515725.ojLSny3TOX@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:UfaJFjbBgfU8pwRqy+2AQXj6j4x4bav4hg2BBwvvPH3JyHM6f8r 9go9Ht1ngwA20EwuUzQVUVVPl/dQ0olA3IRYG2wTI7TQyRXoWAMrIt1Njstbmgj4/ISs2iJ +YNYn+n3FI9TvsvZeeui3uhicMhIQZwLOON4Cfj6E+0OrS1XH9uPvR4MSeftBYzMcSRaYfa P3gPxEX1p79jwmpV8c7ig== X-UI-Out-Filterresults: notjunk:1; V01:K0:dYOjykYEqqM=:C+KiEbfVBoHm0u8RJoDN/E 20GlG8vbwiJ0dWRVFAqN4pYg9Sl0RtWK9vkKShv6rIhDzsOrF4upjhXvdZ5p7XPcXnHvJjfP2 P776LtZOCfBNCCvbq0SdxqRvrzdHtgY7zIR26hvD5Kq7cMdL3BM3RcscAlUIJmWRmqRSXaQFU OaF5cR7ZyPVZf0mMXyxeNfiMDKVqpRzdPvW2pnjKqsK9apfnCyzzdez0McF54L2k2YexRLx7w k7IxCC53gAlXEZlHW710/JmKSpYlyoF+XyLFdwUnvI7092kE5eHhdo9LB4+J7MmYoZN6HY2SQ EKPDKihFrfPSD9VST36/lkVK+3BYB6IflBvRPNvLcXIIX4+G0oGSylBl2HkUjBnFc2rF60Ulv ft+4hiAqxx9Cb6VdJu9wHyRhzzf2kHL9d1ob8okYYyvD8l+Ul13hcpS8wIse/s1BkxLp02bEk PV4jOhwm3OqMiKFxW9yAnajK+roKIZTWue2z2Yd2VfufxBVEV6/bZBagKFXuRl4Yy+MabKc5N djjUKTrfVD1tF9mjIoUqQuTvrltXl9MWfyD166ri8rcuaX9cPyQWhbCBHvKxzvVP6cNzxSezz jr3vW++FdQOTFfycse00c7z4lb68cKU6P3sqIUs5qb9XvkkiBsKXThPA/3HL3wbXfFlvyi+JC DcwCEmZlHl9R/OeyWE5VWhy3o0oVhxZSFdxaeKmSbsV8yreYNNNQKQCq2/KGkn7YEu8SZhLM+ L4sgEeamj9Rt8R7A Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I got one randconfig build that failed to compile plat-samsung/pm-debug.c on s3c64xx: In file included from arch/arm/plat-samsung/pm-debug.c:27:0: arch/arm/mach-s3c64xx/include/mach/pm-core.h: In function 's3c_pm_debug_init_uart': arch/arm/mach-s3c64xx/include/mach/pm-core.h:25:25: error: 'S3C_VA_SYS' undeclared (first use in this function) u32 tmp = __raw_readl(S3C_PCLK_GATE); arch/arm/mach-s3c64xx/include/mach/pm-core.h:25:25: note: each undeclared identifier is reported only once for each function it appears in arch/arm/mach-s3c64xx/include/mach/pm-core.h:39:2: error: implicit declaration of function 'udelay' [-Werror=implicit-function-declaration] udelay(10); I have not investigated why this does not show up much more often, I guess the headers are usually included from elsewhere, but adding explicit #include statements is an obvious fix. Signed-off-by: Arnd Bergmann Reviewed-by: Krzysztof Kozlowski --- I suspect this has been broken for a long time, so no rush, but please apply this to a cleanup branch. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-s3c64xx/include/mach/pm-core.h b/arch/arm/mach-s3c64xx/include/mach/pm-core.h index 5be8fe368e54..4a285e97afff 100644 --- a/arch/arm/mach-s3c64xx/include/mach/pm-core.h +++ b/arch/arm/mach-s3c64xx/include/mach/pm-core.h @@ -16,9 +16,11 @@ #define __MACH_S3C64XX_PM_CORE_H __FILE__ #include +#include #include #include +#include static inline void s3c_pm_debug_init_uart(void) {