| Message ID | 55196DE2.4030109@fivetechno.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2015-03-30 17:38 GMT+02:00 Markus Reichl <m.reichl@fivetechno.de>: > The Exynos5422 SoC has a s3c6410 RTC where the source clock > is now a mandatory property. > > This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards. > It is based in v4.0-rc2. > > Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> > --- > Changes since v2: > 1. Dropped unused phandle. > Changes since v1: > 1. Dropped Documentation. > 2. Split into 2 parts. > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 03/31/2015 12:38 AM, Markus Reichl wrote: > The Exynos5422 SoC has a s3c6410 RTC where the source clock > is now a mandatory property. > > This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards. > It is based in v4.0-rc2. > > Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> > --- > Changes since v2: > 1. Dropped unused phandle. > Changes since v1: > 1. Dropped Documentation. > 2. Split into 2 parts. > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts > index 0408ec0..4a7ca15 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts > @@ -274,10 +274,6 @@ > reg = <0x50>; > }; > }; > - > - rtc@101E0000 { > - status = "okay"; > - }; > }; > > &hdmi { > @@ -374,3 +370,9 @@ > shunt-resistor = <10000>; > }; > }; > + > +&rtc { > + status = "okay"; > + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; > + clock-names = "rtc", "rtc_src"; > +}; > Exynos's RTC must need the XrtcXTI source clock (32.768kHz). Looks good to me. Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> Thanks, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi, > > On 03/31/2015 12:38 AM, Markus Reichl wrote: >> The Exynos5422 SoC has a s3c6410 RTC where the source clock >> is now a mandatory property. >> >> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards. >> It is based in v4.0-rc2. >> >> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> >> --- >> Changes since v2: >> 1. Dropped unused phandle. >> Changes since v1: >> 1. Dropped Documentation. >> 2. Split into 2 parts. >> --- >> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts >> index 0408ec0..4a7ca15 100644 >> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts >> @@ -274,10 +274,6 @@ >> reg = <0x50>; >> }; >> }; >> - >> - rtc@101E0000 { >> - status = "okay"; >> - }; >> }; >> >> &hdmi { >> @@ -374,3 +370,9 @@ >> shunt-resistor = <10000>; >> }; >> }; >> + >> +&rtc { >> + status = "okay"; >> + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; >> + clock-names = "rtc", "rtc_src"; >> +}; >> > > Exynos's RTC must need the XrtcXTI source clock (32.768kHz). Looks good to me. > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> > > Thanks, > Chanwoo Choi > Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts index 0408ec0..4a7ca15 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts @@ -274,10 +274,6 @@ reg = <0x50>; }; }; - - rtc@101E0000 { - status = "okay"; - }; }; &hdmi { @@ -374,3 +370,9 @@ shunt-resistor = <10000>; }; }; + +&rtc { + status = "okay"; + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>; + clock-names = "rtc", "rtc_src"; +};
The Exynos5422 SoC has a s3c6410 RTC where the source clock is now a mandatory property. This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards. It is based in v4.0-rc2. Signed-off-by: Markus Reichl <m.reichl@fivetechno.de> --- Changes since v2: 1. Dropped unused phandle. Changes since v1: 1. Dropped Documentation. 2. Split into 2 parts. --- arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)