From patchwork Sat Aug 29 09:33:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 7094921 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A9D1E9F372 for ; Sat, 29 Aug 2015 09:33:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C6C662072B for ; Sat, 29 Aug 2015 09:33:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF72220732 for ; Sat, 29 Aug 2015 09:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbbH2JdQ (ORCPT ); Sat, 29 Aug 2015 05:33:16 -0400 Received: from lists.s-osg.org ([54.187.51.154]:60990 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752473AbbH2JdQ (ORCPT ); Sat, 29 Aug 2015 05:33:16 -0400 Received: from [192.168.1.132] (120.101.23.95.dynamic.jazztel.es [95.23.101.120]) by lists.s-osg.org (Postfix) with ESMTPSA id E27524632A; Sat, 29 Aug 2015 02:33:12 -0700 (PDT) Subject: Re: [PATCH] ARM: exynos_defconfig: Enable big.LITTLE CPUidle support To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <1440749769-10135-1-git-send-email-javier@osg.samsung.com> <55E174F3.1030202@samsung.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: Kukjin Kim , Thierry Reding , Anand Moon , Russell King , linux-samsung-soc@vger.kernel.org, Sjoerd Simons , Lukasz Majewski , linux-arm-kernel@lists.infradead.org Message-ID: <55E17C56.4080200@osg.samsung.com> Date: Sat, 29 Aug 2015 11:33:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <55E174F3.1030202@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Krzysztof, On 08/29/2015 11:01 AM, Krzysztof Kozlowski wrote: > W dniu 28.08.2015 o 17:16, Javier Martinez Canillas pisze: >> Some Exynos big.LITTLE boards (i.e: Exynos5420 and Exynos5800 based >> Chromebooks) have proper firmware that allow the big.LITTLE CPUidle >> driver to work correctly, so enable support for this. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> Kukjin and Krzysztof, >> >> As you know there are other boards like the Exynos5422 based Odroid XU{3,4} >> whose firmware is broken due leaving CCI in secure mode which means that the >> kernel MCPM support can't properly manage CCI. >> >> So if you pick this patch, it should be tested in kernelci before appearing >> in linux-next to prevent any boot issues. >> >> But if that happens, I believe that is better to do a fix / workaround in >> those broken platforms since nothing prevents users to enable this option >> anyways. For example the CCI device node could be disabled in the DTS. >> >> arch/arm/configs/exynos_defconfig | 1 + >> 1 file changed, 1 insertion(+) > > On Odroid XU3L (next-20150828, Hardkernel u-boot) boot hangs just after: > Thanks for testing, I was expecting that is just that I don't have a Odroid XU{3,4} board for test here, I guess I should get one. > [ 2.568650] dwmmc_exynos 12200000.mmc: num-slots property not found, > assuming 1 slot is available > > ... so no. NACK :). First the boards, firmware, bootloader or kernel Agreed with the nack :) > code have to be fixed. > Or disable CCI, could you please test the following patch [0] so I can post it properly? > Best regards, > Krzysztof > Best regards, diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index dd8bc86d9de4..1e076458fab6 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -525,3 +525,7 @@ vdd33-supply = <&ldo9_reg>; vdd10-supply = <&ldo11_reg>; }; + +&cci { + status = "disabled"; +};