From patchwork Sun Mar 8 21:42:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 5963131 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DC01B9F373 for ; Sun, 8 Mar 2015 21:43:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 16F492026D for ; Sun, 8 Mar 2015 21:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21DB0201F5 for ; Sun, 8 Mar 2015 21:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbbCHVnl (ORCPT ); Sun, 8 Mar 2015 17:43:41 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:63888 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbbCHVnk (ORCPT ); Sun, 8 Mar 2015 17:43:40 -0400 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue001) with ESMTPSA (Nemesis) id 0MG2eU-1YH1r11298-00Est7; Sun, 08 Mar 2015 22:43:01 +0100 From: Arnd Bergmann To: Charles Keepax Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, padma.v@samsung.com, dmitry.torokhov@gmail.com, Maurus Cuelenaere , Liam Girdwood , Tomasz Figa , cw00.choi@samsung.com, Mark Brown , Kukjin Kim , a.kesavan@samsung.com, ch.naveen@samsung.com, jic23@kernel.org Subject: Re: [PATCH 05/10] ARM: s3c64xx: enable sparse IRQ support Date: Sun, 08 Mar 2015 22:42:59 +0100 Message-ID: <6643361.dhtMagqMYZ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150306174316.GA26692@opensource.wolfsonmicro.com> References: <1425299763-4066822-1-git-send-email-arnd@arndb.de> <1425299763-4066822-6-git-send-email-arnd@arndb.de> <20150306174316.GA26692@opensource.wolfsonmicro.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:57MCnLKpaZxa2XZbD7vYAmJErMgvzzcD4xk0WOM3afwZK7EG12y yzw3QLtbhn2NgRvOmOp8503HQ7cwfGS6KXUpW0zm6q4DNeTSvE2wbOTta1Z51gSOnyG+LK0 r+Ejn7fb2wFH05UHEcDq6Z4qAuBb6APqfWVw2ySoW/LOrU2LtsfEN8lww6bJXCXe/BDZDVQ CegVzKTWrYxFe5sBoztwA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Friday 06 March 2015 17:43:16 Charles Keepax wrote: > On Mon, Mar 02, 2015 at 01:35:58PM +0100, Arnd Bergmann wrote: > > This is another prerequisite for enabling multiplatform > > support, and it is the part I am least certain about. > > > > I assume it will cause the extra boot message "Cannot > > allocate irq_descs @ IRQ%d, assuming pre-allocated" to > > be printed, but otherwise work ok. This definitely needs > > to be tested on real hardware to see if it works. > > > > Signed-off-by: Arnd Bergmann > > --- > > This one appears to cause some problems with the IRQs on > Cragganmore, I need to look into it a bit more but it looks like > one of the PMICs can't allocate its IRQs: > > [ 0.961455] wm831x 1-0034: WM8311 revision C > [ 0.965066] wm831x 1-0034: Failed to allocate IRQs: -17 > > And the CODEC can't request its IRQ: > > [ 4.252735] arizona spi0.1: WM5102 revision C > [ 4.269763] arizona spi0.1: Failed to request primary IRQ 263: -22 > > Hopefully I can look into this a little more next week. > My interpretation is that I mistakenly set the .nr_irqs value for craggamore to include all irqs that the board has, while the wm831x tries to allocate the irq descriptors itself and fails if they are already allocated. If that is the only problem here, it would get fixed by this change: The samsung-gpio driver does not allocate irq descriptors for itself though, otherwise we could make the S3C64XX_NR_IRQS number smaller. Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c index f395a5617142..cbe353a5450e 100644 --- a/arch/arm/mach-s3c64xx/mach-crag6410.c +++ b/arch/arm/mach-s3c64xx/mach-crag6410.c @@ -855,7 +855,7 @@ static void __init crag6410_machine_init(void) MACHINE_START(WLF_CRAGG_6410, "Wolfson Cragganmore 6410") /* Maintainer: Mark Brown */ .atag_offset = 0x100, - .nr_irqs = S3C64XX_NR_IRQS + 160, + .nr_irqs = S3C64XX_NR_IRQS, .init_irq = s3c6410_init_irq, .map_io = crag6410_map_io, .init_machine = crag6410_machine_init,