diff mbox series

ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings

Message ID alpine.DEB.2.22.394.2009081136090.2478@hadrien
State Not Applicable
Headers show
Series ODROID-XU4: char: exynos: fix platform_no_drv_owner.cocci warnings | expand

Commit Message

Julia Lawall Sept. 8, 2020, 9:39 a.m. UTC
No need to set .owner here. The core will do it.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
CC: Brian Kim <brian.kim@hardkernel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

I received some other warnings about this file, but with no details:

>> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
dereferenced.
--
>> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
free on line 229


tree:   https://github.com/tobetter/linux odroid-5.9.y
head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 exynos-gpiomem.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Krzysztof Kozlowski Sept. 8, 2020, 10:04 a.m. UTC | #1
On Tue, Sep 08, 2020 at 11:39:51AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Fixes: be904257f8a9 ("ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access")
> CC: Brian Kim <brian.kim@hardkernel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@inria.fr>

Hi,

This is a downstream tree with certain non-upstreamable patches, so
nothing to do here for me.

Best regards,
Krzysztof

> ---
> 
> I received some other warnings about this file, but with no details:
> 
> >> drivers/char/exynos-gpiomem.c:231:15-18: ERROR: inst is NULL but
> dereferenced.
> --
> >> drivers/char/exynos-gpiomem.c:231:9-13: ERROR: reference preceded by
> free on line 229
> 
> 
> tree:   https://github.com/tobetter/linux odroid-5.9.y
> head:   1118f1d60573bfbf1eb7ef079fa879a498ba4313
> commit: be904257f8a9bd689b360fa98d3ffc85bdbeb560 [53/69] ODROID-XU4: char: exynos: add /dev/gpiomem device for rootless user GPIO access
> :::::: branch date: 4 hours ago
> :::::: commit date: 4 hours ago
>
diff mbox series

Patch

--- a/drivers/char/exynos-gpiomem.c
+++ b/drivers/char/exynos-gpiomem.c
@@ -255,7 +255,6 @@  MODULE_DEVICE_TABLE(of, exynos_gpiomem_o
 static struct platform_driver exynos_gpiomem_driver = {
 	.driver			= {
 		.name		= DRIVER_NAME,
-		.owner		= THIS_MODULE,
 		.of_match_table	= exynos_gpiomem_of_match,
 	},
 	.probe			= exynos_gpiomem_probe,