From patchwork Mon Sep 17 16:08:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avri Altman X-Patchwork-Id: 10602993 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DEF5E15E8 for ; Mon, 17 Sep 2018 16:09:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CCE2229FA4 for ; Mon, 17 Sep 2018 16:09:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF00729FB4; Mon, 17 Sep 2018 16:09:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3EEB629FA4 for ; Mon, 17 Sep 2018 16:09:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728090AbeIQVha (ORCPT ); Mon, 17 Sep 2018 17:37:30 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:63409 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727775AbeIQVh3 (ORCPT ); Mon, 17 Sep 2018 17:37:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1537200569; x=1568736569; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=xNiqc5QhUBp1NT7LeS0zA7bRQ2sE4OOGbaJdoXUJowQ=; b=Vgd7l8jufaKl+sgXwgzqsgSfdsyShQ4ficU7LtF62PXPmM0uATwIbcFX 4pTQ6YcTb2lnDxqtkqQUt3sRU18xw5jadhY6M42qhuIe55xErMATmx82i IxO+5LZXs9JL9Flsy/+X7lJTtfYgWh+fCiOVUqkNnu9IoE1u8TfPCwTce 2NOx8pZLRa1SEGdzakz3OMCVICSYtKEGJ/iQmtNfXaVvfbzV9XqCPTbPS oKZS1+JV2IWAqC2TOEBLZTzFDxEl2nNu7o8teLWgL7efjX+b64sr3VNcI zw7Xt8gKfRKXu0BSMsMgVnEtldIYalKfLZOT9gesSp0BLFNjwqY8VDPAA Q==; X-IronPort-AV: E=Sophos;i="5.53,386,1531756800"; d="scan'208";a="91572809" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 18 Sep 2018 00:09:29 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP; 17 Sep 2018 08:55:40 -0700 Received: from kfae422988.sdcorp.global.sandisk.com ([10.0.231.37]) by uls-op-cesaip01.wdc.com with ESMTP; 17 Sep 2018 09:09:25 -0700 From: Avri Altman To: Christoph Hellwig , Johannes Thumshirn , Hannes Reinecke , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org Cc: Stanislav Nijnikov , Avi Shchislowski , Alex Lemberg , Subhash Jadavani , Vinayak Holikatti , Avri Altman Subject: [PATCH v5 0/6] scsi: Add ufs bsg endpoint Date: Mon, 17 Sep 2018 19:08:50 +0300 Message-Id: <1537200536-8817-1-git-send-email-avri.altman@wdc.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Here is a proposal to use a bsg endpoint to manage ufs devices. We will do that by adding a bsg device node to the ufs driver, and use it to send UPIU transactions to the ufs device. It will serve as a ufs device management infrastructure, for device configuration, provisioning, testing and validation, etc. We added a new ufs-bsg module, and some new API to the ufs driver. For the time being, we will not use it for data transfer, but just for device management per-se. This has nothing to do with the recent removal of bsg read/write support, we might add this capability in the future, but it is not our current focus. We tested it on a Hikey-960 platform with a V4.14 kernel, "modernized" by recent bsg and ufs patches. We also used a htc11 with a V4.4 kernel, but needed much more transport/bsg/ufs patches to make it relevant. Many thanks to Christoph and Bart for their much appreciated support and comments. V4->v5: use the new lower-level __ufshcd_issue_tm_cmd directly, so "Allow ufshcd_issue_tm_cmd accept raw upiu" is not needed any more. Get rid of struct ufs_bsg_node which simplifies ufs_bsg_probe(). Also some small adjustments to v4 fixes. Have only one length and format for the reply. Add a documentation of the API as a paragraph in Documentation/scsi/ufs.txt. V3->v4: Squashed the bsg node Instantiation into "Add ufs-bsg". Build ufs-bsg as part of ufshcd-core and not as a separate module. Also merged the ufs_bsg_node into the ufs_hba structure. Christoph refactored the task management code, cleaning it up and making it much more readable - attached as the first 2 patches In the series. Afterward passing an external upiu to ufshcd_issue_tm_cmd Just blends in. V2->v3: We dropped the scsi transport code (and changed this patch title to account for it) as we actually just need the bsg device node. We also withdraw (brokenhearted) from our intension to create several bsg devices, and add just one. Rephrased the doc in Kconfig. V1->v2: Use inline functions instead of defines, and ida to obtain the port indices, in scsi_transport_ufs module. Remove the closing data pointer and __packed notation from struct ufs_bsg_{request_reply}. Re-use ufshcd_issue_tm_cmd code - needed a couple of patches for that, and call req_upiu and rsp_upio with their appropriate struct pointers. Use a more appropriate name when checking if enough memory was allocated for write descriptor, and remove redundant goto. Add reference to the spec to explain uic command size. Fix a lot of typos. Avri Altman (4): scsi: ufs: Add ufs-bsg module scsi: ufs: Add API to execute raw upiu commands scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request() scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request() Christoph Hellwig (2): scsi: ufs: cleanup struct utp_task_req_desc scsi: ufs: add a low-level __ufshcd_issue_tm_cmd helper Documentation/scsi/ufs.txt | 20 +++ drivers/scsi/ufs/Kconfig | 19 +++ drivers/scsi/ufs/Makefile | 3 +- drivers/scsi/ufs/ufs.h | 31 +--- drivers/scsi/ufs/ufs_bsg.c | 258 +++++++++++++++++++++++++++++++++ drivers/scsi/ufs/ufs_bsg.h | 68 +++++++++ drivers/scsi/ufs/ufshcd.c | 353 ++++++++++++++++++++++++++++++--------------- drivers/scsi/ufs/ufshcd.h | 9 ++ drivers/scsi/ufs/ufshci.h | 25 ++-- 9 files changed, 630 insertions(+), 156 deletions(-) create mode 100644 drivers/scsi/ufs/ufs_bsg.c create mode 100644 drivers/scsi/ufs/ufs_bsg.h