| Message ID | 154422079293.1218.12539829857034151457.stgit@brunhilda (mailing list archive) |
|---|---|
| Headers | show |
| Series | smartpqi updates | expand |
Hi Brace, In this patch series, do you have fixed and verified the timeout issue? https://patchwork.kernel.org/patch/10637797/ Thanks, - Alex Don Brace <don.brace@microsemi.com> 于2018年12月8日周六 上午6:28写道： > > These patches are based on Linus's tree > > The changes are: > > - smartpqi-add-support-for-PQI-Config-Table-handshake > . add support for get/set controller features. > - smartpqi-add-retries-for-device-resets > . re-attempt device reset. > - smartpqi-add-no_write_same-for-logical-volumes > . turn off WRITE SAME for logical volumes. > - smartpqi-correct-host-serial-num-for-ssa > . update host serial number > - smartpqi-turn-off-lun-data-caching-for-ptraid > . get fresh lun list from RBODS. > - smartpqi-refactor-sending-controller-raid-requests > . condense commonly used code. > - smartpqi-add-sysfs-attributes > . add in driver attributes. > - smartpqi-add-h3c-ssid > . add support for more controllers. > - smartpqi-fix-disk-name-mount-point > . correct sysfs attribute for unique ids. > - smartpqi-wake-up-drives-after-os-resumes-from-suspend > . have OS start up disks after resume. > - smartpqi-enhance-numa-node-detection > . set pci device to correct NUMA node. > - smartpqi-add-support-for-huawei-controllers > . add support for more controllers. > - smartpqi-check-for-null-device-pointers > . wait for all outstanding I/O to complete before removing a volume > - smartpqi-allow-for-larger-raid-maps > . correct rare case for very large volume configurations. > - smartpqi-do-not-offline-disks-for-transient-did-no-connect-conditions > . remove call to scsi_device_set_state > - smartpqi-correct-volume-status > . correct rare case for volume deletion during a scan operation. > - smartpqi-correct-lun-reset-issues > . clear scsi cmd result after a reset. > - smartpqi-add-module-param-to-disable-irq-affinity > . allow some customers to change IRQ affinity. > - smartpqi-add-smp_utils-support > . add support for smp_utils. > - smartpqi-bump-driver-version > > --- > > Ajish Koshy (2): > smartpqi: add support for huawei controllers > smartpqi: allow for larger raid maps > > Dave Carroll (7): > smartpqi: add no_write_same for logical volumes > smartpqi: turn off lun data caching for ptraid > smartpqi: refactor sending controller raid requests > smartpqi: add sysfs attributes > smartpqi: wake up drives after os resumes from suspend > smartpqi: do not offline disks for transient did no connect conditions > smartpqi: correct volume status > > Don Brace (3): > smartpqi: add module param to disable irq affinity > smartpqi: add smp_utils support > smartpqi: bump driver version > > Kevin Barnett (2): > smartpqi: add support for PQI Config Table handshake > smartpqi: correct lun reset issues > > Mahesh Rajashekhara (3): > Add retries for device reset > smartpqi: correct host serial num for ssa > smartpqi: check for null device pointers > > Murthy Bhat (2): > smartpqi: add h3c ssid > smartpqi: fix disk name mount point > > Sagar Biradar (1): > smartpqi: enhance numa node detection > > > drivers/scsi/smartpqi/smartpqi.h | 144 +++ > drivers/scsi/smartpqi/smartpqi_init.c | 992 ++++++++++++++++++++---- > drivers/scsi/smartpqi/smartpqi_sas_transport.c | 164 ++++ > 3 files changed, 1131 insertions(+), 169 deletions(-) > > -- > Signature -- Thanks and Best Regards, Feng Li(Alex)
There was a patch submitted locally that is a lot like the one you proposed, but it was very recent and has not been fully tested. But it changed the same value from 30 to 180 seconds where your proposed patch change the value to 90. #define SIS_CTRL_READY_TIMEOUT_SECS 180 I'll send this patch up soon when testing has completed. Thanks, Don -----Original Message----- From: Feng Li [mailto:lifeng1519@gmail.com] Sent: Friday, December 7, 2018 9:07 PM To: Don Brace <don.brace@microsemi.com> Cc: Kevin Barnett - C33748 <Kevin.Barnett@microchip.com>; Scott Teel - C33730 <Scott.Teel@microchip.com>; Justin Lindley - C33718 <Justin.Lindley@microchip.com>; Scott Benesh - C33703 <Scott.Benesh@microchip.com>; bader.alisaleh@microchip.com; Gerry Morong - C33720 <Gerry.Morong@microchip.com>; Mahesh Rajashekhara - I30583 <Mahesh.Rajashekhara@microchip.com>; hch@infradead.org; James E.J. Bottomley <jejb@linux.vnet.ibm.com>; joseph.szczypek@hpe.com; POSWALD@suse.com; shunyong.yang@hxt-semitech.com; linux-scsi@vger.kernel.org Subject: Re: [PATCH 00/20] smartpqi updates EXTERNAL EMAIL Hi Brace, In this patch series, do you have fixed and verified the timeout issue? https://patchwork.kernel.org/patch/10637797/ Thanks, - Alex Don Brace <don.brace@microsemi.com> 于2018年12月8日周六 上午6:28写道： > > These patches are based on Linus's tree > > The changes are: > > - smartpqi-add-support-for-PQI-Config-Table-handshake > . add support for get/set controller features. > - smartpqi-add-retries-for-device-resets > . re-attempt device reset. > - smartpqi-add-no_write_same-for-logical-volumes > . turn off WRITE SAME for logical volumes. > - smartpqi-correct-host-serial-num-for-ssa > . update host serial number > - smartpqi-turn-off-lun-data-caching-for-ptraid > . get fresh lun list from RBODS. > - smartpqi-refactor-sending-controller-raid-requests > . condense commonly used code. > - smartpqi-add-sysfs-attributes > . add in driver attributes. > - smartpqi-add-h3c-ssid > . add support for more controllers. > - smartpqi-fix-disk-name-mount-point > . correct sysfs attribute for unique ids. > - smartpqi-wake-up-drives-after-os-resumes-from-suspend > . have OS start up disks after resume. > - smartpqi-enhance-numa-node-detection > . set pci device to correct NUMA node. > - smartpqi-add-support-for-huawei-controllers > . add support for more controllers. > - smartpqi-check-for-null-device-pointers > . wait for all outstanding I/O to complete before removing a volume > - smartpqi-allow-for-larger-raid-maps > . correct rare case for very large volume configurations. > - smartpqi-do-not-offline-disks-for-transient-did-no-connect-conditions > . remove call to scsi_device_set_state > - smartpqi-correct-volume-status > . correct rare case for volume deletion during a scan operation. > - smartpqi-correct-lun-reset-issues > . clear scsi cmd result after a reset. > - smartpqi-add-module-param-to-disable-irq-affinity > . allow some customers to change IRQ affinity. > - smartpqi-add-smp_utils-support > . add support for smp_utils. > - smartpqi-bump-driver-version > > --- > > Ajish Koshy (2): > smartpqi: add support for huawei controllers > smartpqi: allow for larger raid maps > > Dave Carroll (7): > smartpqi: add no_write_same for logical volumes > smartpqi: turn off lun data caching for ptraid > smartpqi: refactor sending controller raid requests > smartpqi: add sysfs attributes > smartpqi: wake up drives after os resumes from suspend > smartpqi: do not offline disks for transient did no connect conditions > smartpqi: correct volume status > > Don Brace (3): > smartpqi: add module param to disable irq affinity > smartpqi: add smp_utils support > smartpqi: bump driver version > > Kevin Barnett (2): > smartpqi: add support for PQI Config Table handshake > smartpqi: correct lun reset issues > > Mahesh Rajashekhara (3): > Add retries for device reset > smartpqi: correct host serial num for ssa > smartpqi: check for null device pointers > > Murthy Bhat (2): > smartpqi: add h3c ssid > smartpqi: fix disk name mount point > > Sagar Biradar (1): > smartpqi: enhance numa node detection > > > drivers/scsi/smartpqi/smartpqi.h | 144 +++ > drivers/scsi/smartpqi/smartpqi_init.c | 992 ++++++++++++++++++++---- > drivers/scsi/smartpqi/smartpqi_sas_transport.c | 164 ++++ > 3 files changed, 1131 insertions(+), 169 deletions(-) > > -- > Signature -- Thanks and Best Regards, Feng Li(Alex)
Ok, thanks for the update. <Don.Brace@microchip.com> 于2018年12月14日周五 上午5:09写道： > > There was a patch submitted locally that is a lot like the one you proposed, but it was very recent and has not been fully tested. > > But it changed the same value from 30 to 180 seconds where your proposed patch change the value to 90. > #define SIS_CTRL_READY_TIMEOUT_SECS 180 > > I'll send this patch up soon when testing has completed. > > Thanks, > Don > > > -----Original Message----- > From: Feng Li [mailto:lifeng1519@gmail.com] > Sent: Friday, December 7, 2018 9:07 PM > To: Don Brace <don.brace@microsemi.com> > Cc: Kevin Barnett - C33748 <Kevin.Barnett@microchip.com>; Scott Teel - C33730 <Scott.Teel@microchip.com>; Justin Lindley - C33718 <Justin.Lindley@microchip.com>; Scott Benesh - C33703 <Scott.Benesh@microchip.com>; bader.alisaleh@microchip.com; Gerry Morong - C33720 <Gerry.Morong@microchip.com>; Mahesh Rajashekhara - I30583 <Mahesh.Rajashekhara@microchip.com>; hch@infradead.org; James E.J. Bottomley <jejb@linux.vnet.ibm.com>; joseph.szczypek@hpe.com; POSWALD@suse.com; shunyong.yang@hxt-semitech.com; linux-scsi@vger.kernel.org > Subject: Re: [PATCH 00/20] smartpqi updates > > EXTERNAL EMAIL > > > Hi Brace, > > In this patch series, do you have fixed and verified the timeout issue? > https://patchwork.kernel.org/patch/10637797/ > > Thanks, > - Alex > > Don Brace <don.brace@microsemi.com> 于2018年12月8日周六 上午6:28写道： > > > > These patches are based on Linus's tree > > > > The changes are: > > > > - smartpqi-add-support-for-PQI-Config-Table-handshake > > . add support for get/set controller features. > > - smartpqi-add-retries-for-device-resets > > . re-attempt device reset. > > - smartpqi-add-no_write_same-for-logical-volumes > > . turn off WRITE SAME for logical volumes. > > - smartpqi-correct-host-serial-num-for-ssa > > . update host serial number > > - smartpqi-turn-off-lun-data-caching-for-ptraid > > . get fresh lun list from RBODS. > > - smartpqi-refactor-sending-controller-raid-requests > > . condense commonly used code. > > - smartpqi-add-sysfs-attributes > > . add in driver attributes. > > - smartpqi-add-h3c-ssid > > . add support for more controllers. > > - smartpqi-fix-disk-name-mount-point > > . correct sysfs attribute for unique ids. > > - smartpqi-wake-up-drives-after-os-resumes-from-suspend > > . have OS start up disks after resume. > > - smartpqi-enhance-numa-node-detection > > . set pci device to correct NUMA node. > > - smartpqi-add-support-for-huawei-controllers > > . add support for more controllers. > > - smartpqi-check-for-null-device-pointers > > . wait for all outstanding I/O to complete before removing a volume > > - smartpqi-allow-for-larger-raid-maps > > . correct rare case for very large volume configurations. > > - smartpqi-do-not-offline-disks-for-transient-did-no-connect-conditions > > . remove call to scsi_device_set_state > > - smartpqi-correct-volume-status > > . correct rare case for volume deletion during a scan operation. > > - smartpqi-correct-lun-reset-issues > > . clear scsi cmd result after a reset. > > - smartpqi-add-module-param-to-disable-irq-affinity > > . allow some customers to change IRQ affinity. > > - smartpqi-add-smp_utils-support > > . add support for smp_utils. > > - smartpqi-bump-driver-version > > > > --- > > > > Ajish Koshy (2): > > smartpqi: add support for huawei controllers > > smartpqi: allow for larger raid maps > > > > Dave Carroll (7): > > smartpqi: add no_write_same for logical volumes > > smartpqi: turn off lun data caching for ptraid > > smartpqi: refactor sending controller raid requests > > smartpqi: add sysfs attributes > > smartpqi: wake up drives after os resumes from suspend > > smartpqi: do not offline disks for transient did no connect conditions > > smartpqi: correct volume status > > > > Don Brace (3): > > smartpqi: add module param to disable irq affinity > > smartpqi: add smp_utils support > > smartpqi: bump driver version > > > > Kevin Barnett (2): > > smartpqi: add support for PQI Config Table handshake > > smartpqi: correct lun reset issues > > > > Mahesh Rajashekhara (3): > > Add retries for device reset > > smartpqi: correct host serial num for ssa > > smartpqi: check for null device pointers > > > > Murthy Bhat (2): > > smartpqi: add h3c ssid > > smartpqi: fix disk name mount point > > > > Sagar Biradar (1): > > smartpqi: enhance numa node detection > > > > > > drivers/scsi/smartpqi/smartpqi.h | 144 +++ > > drivers/scsi/smartpqi/smartpqi_init.c | 992 ++++++++++++++++++++---- > > drivers/scsi/smartpqi/smartpqi_sas_transport.c | 164 ++++ > > 3 files changed, 1131 insertions(+), 169 deletions(-) > > > > -- > > Signature > > > > -- > Thanks and Best Regards, > Feng Li(Alex)
These patches are based on Linus's tree The changes are: - smartpqi-add-support-for-PQI-Config-Table-handshake . add support for get/set controller features. - smartpqi-add-retries-for-device-resets . re-attempt device reset. - smartpqi-add-no_write_same-for-logical-volumes . turn off WRITE SAME for logical volumes. - smartpqi-correct-host-serial-num-for-ssa . update host serial number - smartpqi-turn-off-lun-data-caching-for-ptraid . get fresh lun list from RBODS. - smartpqi-refactor-sending-controller-raid-requests . condense commonly used code. - smartpqi-add-sysfs-attributes . add in driver attributes. - smartpqi-add-h3c-ssid . add support for more controllers. - smartpqi-fix-disk-name-mount-point . correct sysfs attribute for unique ids. - smartpqi-wake-up-drives-after-os-resumes-from-suspend . have OS start up disks after resume. - smartpqi-enhance-numa-node-detection . set pci device to correct NUMA node. - smartpqi-add-support-for-huawei-controllers . add support for more controllers. - smartpqi-check-for-null-device-pointers . wait for all outstanding I/O to complete before removing a volume - smartpqi-allow-for-larger-raid-maps . correct rare case for very large volume configurations. - smartpqi-do-not-offline-disks-for-transient-did-no-connect-conditions . remove call to scsi_device_set_state - smartpqi-correct-volume-status . correct rare case for volume deletion during a scan operation. - smartpqi-correct-lun-reset-issues . clear scsi cmd result after a reset. - smartpqi-add-module-param-to-disable-irq-affinity . allow some customers to change IRQ affinity. - smartpqi-add-smp_utils-support . add support for smp_utils. - smartpqi-bump-driver-version --- Ajish Koshy (2): smartpqi: add support for huawei controllers smartpqi: allow for larger raid maps Dave Carroll (7): smartpqi: add no_write_same for logical volumes smartpqi: turn off lun data caching for ptraid smartpqi: refactor sending controller raid requests smartpqi: add sysfs attributes smartpqi: wake up drives after os resumes from suspend smartpqi: do not offline disks for transient did no connect conditions smartpqi: correct volume status Don Brace (3): smartpqi: add module param to disable irq affinity smartpqi: add smp_utils support smartpqi: bump driver version Kevin Barnett (2): smartpqi: add support for PQI Config Table handshake smartpqi: correct lun reset issues Mahesh Rajashekhara (3): Add retries for device reset smartpqi: correct host serial num for ssa smartpqi: check for null device pointers Murthy Bhat (2): smartpqi: add h3c ssid smartpqi: fix disk name mount point Sagar Biradar (1): smartpqi: enhance numa node detection drivers/scsi/smartpqi/smartpqi.h | 144 +++ drivers/scsi/smartpqi/smartpqi_init.c | 992 ++++++++++++++++++++---- drivers/scsi/smartpqi/smartpqi_sas_transport.c | 164 ++++ 3 files changed, 1131 insertions(+), 169 deletions(-) -- Signature