From patchwork Mon Aug 3 09:04:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Can Guo X-Patchwork-Id: 11697637 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 96001138A for ; Mon, 3 Aug 2020 09:04:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 875DB2075A for ; Mon, 3 Aug 2020 09:04:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725933AbgHCJEr (ORCPT ); Mon, 3 Aug 2020 05:04:47 -0400 Received: from labrats.qualcomm.com ([199.106.110.90]:8658 "EHLO labrats.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbgHCJEr (ORCPT ); Mon, 3 Aug 2020 05:04:47 -0400 IronPort-SDR: uNaNh3jHGg1gd7mNTWJItxCpxmOhYcuj2AhPOAskeQyvIFLKZIPYjsMax6Ypsx6wk5QfdtCLK/ ohIHEeSr8wk15tBCYi+Dk9QFqEsdWFO1k6HEuo65k+KdiPBGn3yvKNytMgJpk60NBPH+N/0pFl cpkJglpvj2v0F11xRm/9fkcgwP9o1WBk6HKz8cVEKlfXw8TlhDu/E4+NFo4VtMoXKxvWDyQsKz cQ2xRBj42T9e4FhoE+RuqwjoHVG3W/VEg1KB0NoKn+besMl+eVRzzyOqc7nW8aw/eRkMqlIsHe Ba8= X-IronPort-AV: E=Sophos;i="5.75,429,1589266800"; d="scan'208";a="47240951" Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by labrats.qualcomm.com with ESMTP; 03 Aug 2020 02:04:47 -0700 Received: from wsp769891wss.qualcomm.com (HELO stor-presley.qualcomm.com) ([192.168.140.85]) by ironmsg01-sd.qualcomm.com with ESMTP; 03 Aug 2020 02:04:46 -0700 Received: by stor-presley.qualcomm.com (Postfix, from userid 359480) id 351C5214E4; Mon, 3 Aug 2020 02:04:46 -0700 (PDT) From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Subject: [PATCH v9 0/9] Fix up and simplify error recovery mechanism Date: Mon, 3 Aug 2020 02:04:35 -0700 Message-Id: <1596445485-19834-1-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 2.7.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org The changes have been tested with error injections of multiple error types (and all kinds of mixture of them) during runtime, e.g. hibern8 enter/ exit error, power mode change error and fatal/non-fatal error from IRQ context. During the test, error injections happen randomly across all contexts, e.g. clk scaling, clk gate/ungate, runtime suspend/resume and IRQ. There are a few more fixes to resolve other minor problems based on the main change, such as LINERESET handling and racing btw error handler and system suspend/resume/shutdown, but they will be pushed after this series is taken, due to there are already too many lines in these changes. Change since v8: - Added one more fix to ufshcd_abort as requested by Stanley Chu Change since v7: - Incorporated Asutosh's comments - Refined patch "scsi: ufs: Recover hba runtime PM error in error handler" Change since v6: - Modified change "scsi: ufs-qcom: Fix schedule while atomic error in ufs_qcom_dump_dbg_regs" to "scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs" Change since v5: - Dropped change "scsi: ufs: Fix imbalanced scsi_block_reqs_cnt caused by ufshcd_hold()" as it is not quite related with this series - Refined func ufshcd_err_handling_prepare in change "scsi: ufs: Recover hba runtime PM error in error handler" Change since v4: - Split the original change "ufs: ufs-qcom: Fix a few BUGs in func ufs_qcom_dump_dbg_regs()" to 2 small changes Change since v3: - Split the original change "scsi: ufs: Fix up and simplify error recovery mechanism" into 5 changes Change since v2: - Incorporate Bart's comment to change "scsi: ufs: Add checks before setting clk-gating states" - Revised the commit msg of change "scsi: ufs: Fix up and simplify error recovery mechanism" Change since v1: - Fixed a compilation error in case that CONFIG_PM is N Can Guo (9): scsi: ufs: Add checks before setting clk-gating states ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs scsi: ufs: Add some debug infos to ufshcd_print_host_state scsi: ufs: Fix concurrency of error handler and other error recovery paths scsi: ufs: Recover hba runtime PM error in error handler scsi: ufs: Move dumps in IRQ handler to error handler scsi: ufs: Fix a racing problem btw error handler and runtime PM ops scsi: ufs: Properly release resources if a task is aborted successfully drivers/scsi/ufs/ufs-qcom.c | 37 ---- drivers/scsi/ufs/ufs-sysfs.c | 1 + drivers/scsi/ufs/ufshcd.c | 508 +++++++++++++++++++++++++++---------------- drivers/scsi/ufs/ufshcd.h | 14 ++ 4 files changed, 338 insertions(+), 222 deletions(-) Reviewed-by: Asutosh Das