mbox series

[V3,0/2] scsi/sd: make disk cmd retries configurable

Message ID 1601566554-26752-1-git-send-email-michael.christie@oracle.com (mailing list archive)
Headers show
Series scsi/sd: make disk cmd retries configurable | expand

Message

Mike Christie Oct. 1, 2020, 3:35 p.m. UTC
The following patches made over Martin's staging branch allow
the user to config sd cmd retries. I didn't allow the user to
set any old value and kept the max at 5. However, you can now
turn it off and rely on the transport error handler to decide
when to stop retrying. You can also decrease retries for cases
for disks where there is no use in retrying 5 times.

V3:
- really drop excess ()s

V2:
- Drop excess ()
- Add comment about forcing completion in the request sense
case
- Use kstrtoint

Comments

Martin K. Petersen Oct. 2, 2020, 10:53 p.m. UTC | #1
Mike,

> The following patches made over Martin's staging branch allow the user
> to config sd cmd retries. I didn't allow the user to set any old value
> and kept the max at 5. However, you can now turn it off and rely on
> the transport error handler to decide when to stop retrying. You can
> also decrease retries for cases for disks where there is no use in
> retrying 5 times.

Applied to 5.10/scsi-staging, thanks!