[v5,0/2] Introduce hba performance monitoring sysfs nodes

Message

Can Guo April 22, 2021, 2:28 a.m. UTC

Add a new sysfs group which has nodes to monitor data/request transfer
performance. This sysfs group has nodes showing total sectors/requests
transferred, total busy time spent and max/min/avg/sum latencies. This
group can be enhanced later to show more UFS driver layer performance
data during runtime.

It works like:
/sys/bus/platform/drivers/ufshcd/*/monitor # echo 4096 > monitor_chunk_size
/sys/bus/platform/drivers/ufshcd/*/monitor # echo 1 > monitor_enable
/sys/bus/platform/drivers/ufshcd/*/monitor # grep ^ /dev/null *
monitor_chunk_size:4096
monitor_enable:1
read_nr_requests:17
read_req_latency_avg:169
read_req_latency_max:594
read_req_latency_min:66
read_req_latency_sum:2887
read_total_busy:2639
read_total_sectors:136
write_nr_requests:116
write_req_latency_avg:440
write_req_latency_max:4921
write_req_latency_min:23
write_req_latency_sum:51052
write_total_busy:19584
write_total_sectors:928

Change since v4:
- Use lrbp->compl_time_stamp as now in ufshcd_update_monitor()

Change since v3:
- Rebased

Change since v2:
- Fixed a sparse error

Change since v1:
- Moved code from ufs-qcom.c to ufshcd.c


Can Guo (2):
  scsi: ufs: Introduce hba performance monitor sysfs nodes
  scsi: ufs: Add support for hba performance monitor

 Documentation/ABI/testing/sysfs-driver-ufs | 126 +++++++++++++++
 drivers/scsi/ufs/ufs-sysfs.c               | 237 +++++++++++++++++++++++++++++
 drivers/scsi/ufs/ufshcd.c                  |  62 ++++++++
 drivers/scsi/ufs/ufshcd.h                  |  21 +++
 4 files changed, 446 insertions(+)

Comments

Daejun Park May 6, 2021, 5 a.m. UTC | #1

Hi Can Guo,

>Add a new sysfs group which has nodes to monitor data/request transfer
>performance. This sysfs group has nodes showing total sectors/requests
>transferred, total busy time spent and max/min/avg/sum latencies. This
>group can be enhanced later to show more UFS driver layer performance
>data during runtime.

This series looks good to me.
Reviewed-by: Daejun Park <[e-mail]>

Thanks,
Daejun

Martin K. Petersen May 15, 2021, 2:56 a.m. UTC | #2

Can,

> Add a new sysfs group which has nodes to monitor data/request transfer
> performance. This sysfs group has nodes showing total sectors/requests
> transferred, total busy time spent and max/min/avg/sum latencies. This
> group can be enhanced later to show more UFS driver layer performance
> data during runtime.

Applied to 5.14/scsi-staging, thanks!