[v2,0/7] sd patches for kernel v5.1

Message

Bart Van Assche Jan. 16, 2019, 12:49 a.m. UTC

Hi Martin,

This patch series includes the following patches:
- Six patches that clean up/rearrange the code in the sd driver.
- One micro-optimization for the SCSI core.

Please consider these patches for kernel v5.1.

Thanks,

Bart.

Changes compared to v1:
- Left out the two patches that increase SCSI probing concurrency.
- Added a micro-optimization patch for the SCSI core.

Bart Van Assche (3):
  sd: Remove a local variable
  sd: Rename 'SCpnt' into 'cmd'
  Remove an atomic instruction from the hot path

Martin K. Petersen (4):
  sd: Be consistent about blocks vs. sectors
  sd: Simplify misaligned I/O check
  sd: Create helper functions for read/write commands
  sd: Clean up sd_setup_read_write_cmnd()

 drivers/scsi/scsi_lib.c |   2 +-
 drivers/scsi/sd.c       | 374 ++++++++++++++++++----------------------
 2 files changed, 166 insertions(+), 210 deletions(-)

Comments

Martin K. Petersen Jan. 16, 2019, 3:11 a.m. UTC | #1

Bart,

> This patch series includes the following patches:
> - Six patches that clean up/rearrange the code in the sd driver.
> - One micro-optimization for the SCSI core.

Thanks for posting these, about time we get them in.

Can you share the rationale behind the changes you left out from my
original series?

Martin K. Petersen Jan. 16, 2019, 3:12 a.m. UTC | #2

> Can you share the rationale behind the changes you left out from my
> original series?

The rationale for leaving out some of the changes, I mean.

Bart Van Assche Jan. 16, 2019, 3:18 a.m. UTC | #3

On 1/15/19 7:12 PM, Martin K. Petersen wrote:
>> Can you share the rationale behind the changes you left out from my
>> original series?
> 
> The rationale for leaving out some of the changes, I mean.

Hi Martin,

Did you mean leaving out patches or leaving out changes from individual 
patches? The git tree I used as the basis for this patch series is 
available at 
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git/log/?h=scsi-work. 
No changes have been left out intentionally. If any changes have been 
left out that is the result of an oversight. Can you clarify which 
changes you think are missing?

Thanks,

Bart.

Martin K. Petersen Jan. 16, 2019, 3:24 a.m. UTC | #4

Hi Bart,

> The git tree I used as the basis for this patch series is available at
> https://git.kernel.org/pub/scm/linux/kernel/git/mkp/linux.git/log/?h=scsi-work. No
> changes have been left out intentionally. If any changes have been
> left out that is the result of an oversight. Can you clarify which
> changes you think are missing?

Oh, that's an older branch. 4.19/scsi is the latest, I'll take a look
tomorrow.

Martin K. Petersen Jan. 17, 2019, 3:26 a.m. UTC | #5

Bart,

> If any changes have been left out that is the result of an
> oversight. Can you clarify which changes you think are missing?

It appears you got everything. Things were just sliced and diced
slightly differently.

I'll run some tests and apply unless something breaks.

Thanks again for dusting these off!

Martin K. Petersen Jan. 23, 2019, 2:39 a.m. UTC | #6

Bart,

> This patch series includes the following patches:
> - Six patches that clean up/rearrange the code in the sd driver.
> - One micro-optimization for the SCSI core.

Applied to 5.1/scsi-queue. Thanks again.