From patchwork Thu Apr 11 21:53:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10896943 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B508514DB for ; Thu, 11 Apr 2019 21:53:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CEA628E23 for ; Thu, 11 Apr 2019 21:53:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9161128E2E; Thu, 11 Apr 2019 21:53:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3198128E29 for ; Thu, 11 Apr 2019 21:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726739AbfDKVxi (ORCPT ); Thu, 11 Apr 2019 17:53:38 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45583 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726714AbfDKVxi (ORCPT ); Thu, 11 Apr 2019 17:53:38 -0400 Received: by mail-pf1-f195.google.com with SMTP id e24so4061371pfi.12 for ; Thu, 11 Apr 2019 14:53:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=O3wymDeNwiGVYtaJJrYl3pk9s9bffDwxeRCEgqzyG/Y=; b=m5IXFm0FoIgOtfekWYJPWQzD17DnhQCQcWVLOURYTfyGrc2pBmJ/nJ/4PIpLEiohEQ duIGXTPDuOdDVi4bl/ENVSTNvrE3/XJ3SoG502ua92QdZHpuBktKaxiXA5UxZWmgOka+ EmFbMfdLjbo/KoRgF7TY8ca7Bgsqaa++QocjrKS3hyUb5uPf4lX7FldjlaBfCgueh+TA 21s5his13WnWF1VeUFFfROUZgINXvA/gzk3vEvansqKOnINAbe979Hk63tYLR8nyR454 OKlALRSW0o+16c+UAa13P4gQjKCc9wzT83h3My5ahmTBj2eTx62TFtJwL+pj/GJjDCAS dy0g== X-Gm-Message-State: APjAAAWe3gNCBjO5q7UlXLzy34O7D/FIIBbTVIxBiuWx71AH3rwM0g7K CwjQzSvpCT8Z+wkcjqXsUws= X-Google-Smtp-Source: APXvYqz7R+pNJCkjWQ4cl66+6MvzYuXpY2JLVv7cEiRSfNUBkGzmz8zocGMna9KQ35M6FsDbrQrIEQ== X-Received: by 2002:a65:654c:: with SMTP id a12mr2053316pgw.101.1555019617450; Thu, 11 Apr 2019 14:53:37 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id o67sm91651066pga.55.2019.04.11.14.53.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 14:53:36 -0700 (PDT) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Christoph Hellwig , Bart Van Assche Subject: [PATCH 00/10] Improve qla2xxx coding style Date: Thu, 11 Apr 2019 14:53:15 -0700 Message-Id: <20190411215325.122837-1-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Martin, While preparing a few bug fixes for the qla2xxx driver I noticed several stylistic issues in that driver. I'm sending the patches with stylistic improvements ahead to avoid having to post too many patches at once (another 20 patches will follow at a later time). Please consider these patches for kernel v5.2. Thanks, Bart. Bart Van Assche (10): qla2xxx: Use tabs to indent code qla2xxx: Leave a blank line after declarations qla2xxx: Fix formatting of pointer types qla2xxx: Insert spaces where required qla2xxx: Move the port_state_str[] definition from a .h to a .c file qla2xxx: Declare qla24xx_build_scsi_crc_2_iocbs() static qla2xxx: Move the include directive qla2xxx: Remove qla_tgt_cmd.data_work and qla_tgt_cmd.data_work_free qla2xxx: Remove two superfluous casts qla2xxx: Move qla2x00_set_fcport_state() from a .h into a .c file drivers/scsi/qla2xxx/qla_attr.c | 15 +++++-- drivers/scsi/qla2xxx/qla_bsg.c | 5 +++ drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_def.h | 10 +---- drivers/scsi/qla2xxx/qla_dfs.c | 3 ++ drivers/scsi/qla2xxx/qla_gbl.h | 5 +-- drivers/scsi/qla2xxx/qla_gs.c | 4 +- drivers/scsi/qla2xxx/qla_init.c | 70 ++++++++++++++++++++---------- drivers/scsi/qla2xxx/qla_inline.h | 19 -------- drivers/scsi/qla2xxx/qla_iocb.c | 18 ++++---- drivers/scsi/qla2xxx/qla_isr.c | 15 ++++++- drivers/scsi/qla2xxx/qla_mbx.c | 5 ++- drivers/scsi/qla2xxx/qla_mr.c | 2 + drivers/scsi/qla2xxx/qla_nvme.c | 1 + drivers/scsi/qla2xxx/qla_nx.c | 13 ++++++ drivers/scsi/qla2xxx/qla_nx.h | 2 +- drivers/scsi/qla2xxx/qla_nx2.c | 3 +- drivers/scsi/qla2xxx/qla_os.c | 11 +++-- drivers/scsi/qla2xxx/qla_sup.c | 2 +- drivers/scsi/qla2xxx/qla_target.c | 25 +++++++++-- drivers/scsi/qla2xxx/qla_target.h | 4 +- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 - 22 files changed, 149 insertions(+), 87 deletions(-) Reviewed-by: Johannes Thumshirn Acked-by: Himanshu Madhani