From patchwork Tue Jun 25 02:46:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 11014459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE105186E for ; Tue, 25 Jun 2019 02:46:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D1EA1289C9 for ; Tue, 25 Jun 2019 02:46:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C64E828B0D; Tue, 25 Jun 2019 02:46:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A25428AB1 for ; Tue, 25 Jun 2019 02:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730591AbfFYCq2 (ORCPT ); Mon, 24 Jun 2019 22:46:28 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:51033 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730581AbfFYCq2 (ORCPT ); Mon, 24 Jun 2019 22:46:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1561430789; x=1592966789; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=oQYTRRb4w7hg1e0SdjKzlTX0Gjm46D514gz8bl+y+aA=; b=MgpOZDQqh1+oivw8s8aXHR6fCywjL0P60FY2JP8rOEDd76WiU7JBV6RY Qernn2iU5zEhQAtsoBn2SNho0s/5czX1r9D8To3G/omjLQjoO0AuyzvVa XGWDTlxBQInhIVgr1IM7LToP35EukQqfiVocWfPYC/m7nkfMaWzFgdzT5 shf1S3TPg8gapCGMtEqsjJkc6yIKlG6kA8vpJ0i1olrHhJxhNOa3osv2e lIyOb8vkOemRmWnojhPaMeCEDpG21w4Td0M69nb9+aRJ1iX9knY5gCdih d1wVwA76+nBuP9rRCK3jJDt75XtRIJO41Wrt7FEStWVNofZ0W60Q/lZDn g==; X-IronPort-AV: E=Sophos;i="5.63,413,1557158400"; d="scan'208";a="112654037" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 25 Jun 2019 10:46:28 +0800 IronPort-SDR: gZwptn6SYaogOGWg5mug86EHFZUaHPZ+XXDUAPvPLtIZNUsT4qvXUkeq0GP5uy2rO2WtfJ3R/G bMmZk9BDpJlC8Cs6ThqTyutCwzkK0+TKp05Kb39v1yRHxUXAKpnJ2lxbTxuztRCuCyoV07up4t NsaVEp7Oi6uEpxxaCyHzAis4fBXjr4/mlRgwSRk9qmXBfH74gDF/gXMPDiKB6cKU7gr+X5csOU gnk48TFfvMqj7lejacotxxcjtDjoXmlvQyGqUqr7rFYzDZkTi6s4vo03BFwthmGZjGAaVElkh5 Lz/Qa6+d1tWCz1v6LQQz2OpI Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP; 24 Jun 2019 19:45:45 -0700 IronPort-SDR: ZxB01YmPsaiImBCl+TUFfap8Et9tixPw4umy1n0o/B9GU5icNVQq0VYR4PyasY3g+SUt1/rDUT mqwzJXEFLS+YWaKofIXdmRI+7y0SiaDMro29i22IkNdK74C6hBYXWceZUTLcTAGRHslx81braI NTPURWcrXkhUm2P0GWTMnNd7cw0Z9VE6zQz6LNZkbArjt3BtkjZW+b+ElJ0grJEeWEV2C/GU7E GfU7igE6pRdaraYVUOmSZNy8Mlo+cTo0uN3lQxPzOzQ/lordNTBU7OZSfiUwSiuRJja1XQukXt gNw= Received: from washi.fujisawa.hgst.com ([10.149.53.254]) by uls-op-cesaip01.wdc.com with ESMTP; 24 Jun 2019 19:46:26 -0700 From: Damien Le Moal To: linux-scsi@vger.kernel.org, "Martin K . Petersen" , linux-block@vger.kernel.org, Jens Axboe Cc: Christoph Hellwig , Bart Van Assche Subject: [PATCH 0/3] Fix zone revalidation memory allocation failures Date: Tue, 25 Jun 2019 11:46:22 +0900 Message-Id: <20190625024625.23976-1-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This series addresses a reccuring problem with zone revalidation failures observed during extensive testing with memory constrained system and device hot-plugging. The problem source is failure to allocate large memory areas with alloc_pages() or kmalloc() in blk_revalidate_disk_zones() to store the disk array of zones (struct blk_zone) or in sd_zbc_report_zones() for the report zones command reply buffer. The solution proposed here is to: 1) limit the number of zones to be reported with a single report zones command execution, and 2) Use vmalloc to allocate large-ish arrays and buffers in place of alloc_pages() and kmalloc(). With these changes, tests do not show any zone revalidation failures while not impacting the time taken for a disk initial zone inspection during device scan. Damien Le Moal (3): block: Allow mapping of vmalloc-ed buffers sd_zbc: Fix report zones buffer allocation block: Limit zone array allocation size block/bio.c | 8 ++++- block/blk-zoned.c | 29 +++++++--------- drivers/scsi/sd_zbc.c | 79 +++++++++++++++++++++++++++++++----------- include/linux/blkdev.h | 5 +++ 4 files changed, 84 insertions(+), 37 deletions(-)