From patchwork Wed Jul 24 09:00:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannes Reinecke X-Patchwork-Id: 11056461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8AF79112C for ; Wed, 24 Jul 2019 09:01:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7B5C1287A4 for ; Wed, 24 Jul 2019 09:01:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FAAF287A6; Wed, 24 Jul 2019 09:01:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A5F1287A5 for ; Wed, 24 Jul 2019 09:01:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726843AbfGXJBN (ORCPT ); Wed, 24 Jul 2019 05:01:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:55388 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726070AbfGXJBN (ORCPT ); Wed, 24 Jul 2019 05:01:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 3E1FFAFBD; Wed, 24 Jul 2019 09:01:12 +0000 (UTC) From: Hannes Reinecke To: "Martin K. Petersen" Cc: Christoph Hellwig , James Bottomley , Linus Torvalds , linux-scsi@vger.kernel.org, Hannes Reinecke Subject: [PATCHv3 0/3] fcoe: cleanup fc_rport_priv usage Date: Wed, 24 Jul 2019 11:00:53 +0200 Message-Id: <20190724090056.7506-1-hare@suse.de> X-Mailer: git-send-email 2.16.4 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi all, the fcoe vn2vn code is using the 'fc_rport_priv' structure as argument to its internal function, but is really expecting a struct fcoe_rport to immediately follow this one. This is not only confusing but also an error for new compilers. So clean up the usage by embedding fc_rport_priv into fcoe_rport, and use the fcoe_rport structure wherever possible. This patchset also contains some minor whitespace cleanups for libfc.h. As usual, comments and reviews are welcome. Changes to v1: - Drop patch to remove lld_event_callback Changes to v2: - Include reviews from Christoph Hannes Reinecke (3): libfc: Whitespqce cleanup in libfc.h fcoe: Embed fc_rport_priv in fcoe_rport structure fcoe: pass in fcoe_rport structure instead of fc_rport_priv drivers/scsi/fcoe/fcoe_ctlr.c | 138 ++++++++++++++++++++---------------------- drivers/scsi/libfc/fc_rport.c | 5 +- include/scsi/libfc.h | 52 ++++++++-------- include/scsi/libfcoe.h | 1 + 4 files changed, 96 insertions(+), 100 deletions(-)