| Message ID | 20190807144948.28265-1-maier@linux.ibm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: core: regression fixes for request batching | expand |
On 07/08/19 16:49, Steffen Maier wrote: > Hi James, Martin, Paolo, Ming, > > multipathing with linux-next is broken since 20190723 in our CI. > The patches fix a memleak and a severe dh/multipath functional regression. > It would be nice if we could get them to 5.4/scsi-queue and also next. > > I would have preferred if such a new feature had used its own > new copy scsi_mq_ops_batching instead of changing the use case and > semantics of the existing scsi_mq_ops, because this would likely > cause less regressions for all the other users not using the new feature. > > Steffen Maier (2): > scsi: core: fix missing .cleanup_rq for SCSI hosts without request > batching > scsi: core: fix dh and multipathing for SCSI hosts without request > batching > > drivers/scsi/scsi_lib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
On 8/7/19 7:49 AM, Steffen Maier wrote: > Hi James, Martin, Paolo, Ming, > > multipathing with linux-next is broken since 20190723 in our CI. > The patches fix a memleak and a severe dh/multipath functional regression. > It would be nice if we could get them to 5.4/scsi-queue and also next. > > I would have preferred if such a new feature had used its own > new copy scsi_mq_ops_batching instead of changing the use case and > semantics of the existing scsi_mq_ops, because this would likely > cause less regressions for all the other users not using the new feature. For both patches: Reviewed-by: Bart Van Assche <bvanassche@acm.org> BTW, these two patches fix several nvmeof-mp blktests regressions. Bart.
Hi James, Martin, Paolo, Ming, multipathing with linux-next is broken since 20190723 in our CI. The patches fix a memleak and a severe dh/multipath functional regression. It would be nice if we could get them to 5.4/scsi-queue and also next. I would have preferred if such a new feature had used its own new copy scsi_mq_ops_batching instead of changing the use case and semantics of the existing scsi_mq_ops, because this would likely cause less regressions for all the other users not using the new feature. Steffen Maier (2): scsi: core: fix missing .cleanup_rq for SCSI hosts without request batching scsi: core: fix dh and multipathing for SCSI hosts without request batching drivers/scsi/scsi_lib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)