From patchwork Fri May 8 08:01:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 11535855 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CBEA014C0 for ; Fri, 8 May 2020 08:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4913207DD for ; Fri, 8 May 2020 08:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="QzDKXpbm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727122AbgEHIBZ (ORCPT ); Fri, 8 May 2020 04:01:25 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:40573 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727105AbgEHIBY (ORCPT ); Fri, 8 May 2020 04:01:24 -0400 X-UUID: 02ec54b3ad4841108a70f865eba87e39-20200508 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=q41jnBLZkm5OYDzNGhSl4Dj8ltKLKW6wmqZStHtz2CA=; b=QzDKXpbm3bkTCmkLMebgJgCfKKMZYA2t+VS2l7NzhWVBiFaczjvlhKJxVJri6zV3cfmg1gSY93jJmtp8eNGZMLK6GqZnlr3GM9Ei6aRF3rSK8wREafFtZLs8bt8oL7HqLlxqmy+Ag7DyC+V3en1fgzqzJS9qff3lp+Zx/kuEp3A=; X-UUID: 02ec54b3ad4841108a70f865eba87e39-20200508 Received: from mtkcas07.mediatek.inc [(172.21.101.84)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1874186833; Fri, 08 May 2020 16:01:19 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 8 May 2020 16:01:17 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 8 May 2020 16:01:17 +0800 From: Stanley Chu To: , , , , , CC: , , , , , , , , , , , Stanley Chu Subject: [PATCH v8 0/8] scsi: ufs: support LU Dedicated buffer mode for WriteBooster Date: Fri, 8 May 2020 16:01:07 +0800 Message-ID: <20200508080115.24233-1-stanley.chu@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi, This patchset adds LU dedicated buffer mode support for WriteBooster. In the meanwhile, enable WriteBooster capability on MediaTek UFS platforms. v7 -> v8: - In exported funtion ufshcd_fixup_dev_quirks(), add null checking for parameter "fixups" (Avri Altman) v6 -> v7: - Add device descriptor length check in ufshcd_wb_probe() back to prevent out-of-boundary access in ufshcd_wb_probe() - Fix the check of device descriptor length (Avri Altman) - Provide a new ufs_fixup_device_setup() function to pack both device fixup methods by general quirk table and vendor-specific way (Avri Altman) v5 -> v6: - Remove device descriptor length check in ufshcd_wb_probe() v4 -> v5: - Check LUN ID for available WriteBooster buffer only from 0 to 7 according to spec (Avri Altman) - Skip checking any possible errors from ufshcd_read_unit_desc_param(hba, lun, UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS) in ufshcd_wb_probe() and check returned d_lu_wb_buf_alloc (shall be zero if error happens) (Avri Altman) v3 -> v4: - Introduce "fixup_dev_quirks" vops to allow vendors to fix and modify device quirks, and provide an initial vendor-specific device quirk table on MediaTek UFS platforms - Avoid relying on common device quirk table for pre-3.1 UFS device with non-standard WriteBooster support (Can Guo) - Fix comments for ufshcd_wb_probe() (Can Guo) - Make ufshcd_wb_get_flag_index() inline and fix ufshcd_is_wb_flags() (Avri Altman) v2 -> v3: - Introduce a device quirk to support WriteBooster in pre-3.1 UFS devices (Avri Altman) - Fix WriteBooster related sysfs nodes. Now all WriteBooster related sysfs nodes are specifically mapped to the LUN with WriteBooster enabled in LU Dedicated buffer mode (Avri Altman) v1 -> v2: - Change the definition name of WriteBooster buffer mode to correspond to specification (Bean Huo) - Add patch #5: "scsi: ufs: cleanup WriteBooster feature" Stanley Chu (8): scsi: ufs: enable WriteBooster on some pre-3.1 UFS devices scsi: ufs: introduce fixup_dev_quirks vops scsi: ufs: export ufs_fixup_device_setup() function scsi: ufs-mediatek: add fixup_dev_quirks vops scsi: ufs: add "index" in parameter list of ufshcd_query_flag() scsi: ufs: add LU Dedicated buffer mode support for WriteBooster scsi: ufs-mediatek: enable WriteBooster capability scsi: ufs: cleanup WriteBooster feature drivers/scsi/ufs/ufs-mediatek.c | 25 ++++- drivers/scsi/ufs/ufs-sysfs.c | 11 ++- drivers/scsi/ufs/ufs.h | 10 ++ drivers/scsi/ufs/ufs_quirks.h | 7 ++ drivers/scsi/ufs/ufshcd.c | 166 +++++++++++++++++++++----------- drivers/scsi/ufs/ufshcd.h | 19 +++- 6 files changed, 176 insertions(+), 62 deletions(-)