mbox series

[RESENT,v5,0/5] scsi: ufs: cleanup ufs initialization

Message ID 20200603091959.27618-1-huobean@gmail.com (mailing list archive)
Headers show
Series scsi: ufs: cleanup ufs initialization | expand

Message

Bean Huo June 3, 2020, 9:19 a.m. UTC
From: Bean Huo <beanhuo@micron.com>

Resent this patchset since linux-scsi@vger.kernel.org and
linux-kernel@vger.kernel.org rejected my email


Cleanup UFS descriptor length initialization, and delete some unnecessary code.

Changelog:
v4 - v5:
    1. Rebased patch
    2. In the patch 3/5, change "param_size > buff_len" to
       "(param_offset + param_size) > buff_len"

v3 - v4:
    1. add desc_id >= QUERY_DESC_IDN_MAX check in patch 4/5 (Avri Altman)
    2. update buff_len to hold the true descriptor size in 4/5 (Avri Altman)
    3. add new patch 3/5

v2 - v3:
    1. Fix typo in the commit message (Avri Altman & Bart van Assche)
    2. Delete ufshcd_init_desc_sizes() in patch 3/4 (Stanley Chu)
    3. Remove max_t() and buff_len in patch 1/4 (Bart van Assche)
    4. Add patch 4/4 to compatable with 3.1 UFS unit descriptor length

v1 - v2:
    1. split patch
    2. fix one compiling WARNING (Reported-by: kbuild test robot <lkp@intel.com>)

Bart van Assche (1):
  scsi: ufs: remove max_t in ufs_get_device_desc

Bean Huo (4):
  scsi: ufs: delete ufshcd_read_desc()
  scsi: ufs: fix potential access NULL pointer while memcpy
  scsi: ufs: cleanup ufs initialization path
  scsi: ufs: add compatibility with 3.1 UFS unit descriptor length

 drivers/scsi/ufs/ufs.h     |  11 +-
 drivers/scsi/ufs/ufs_bsg.c |   5 +-
 drivers/scsi/ufs/ufshcd.c  | 207 +++++++++----------------------------
 drivers/scsi/ufs/ufshcd.h  |  16 +--
 4 files changed, 54 insertions(+), 185 deletions(-)

Comments

Avri Altman June 3, 2020, 10:33 a.m. UTC | #1
Looks fine to me.
Thanks,
Avri

 
> 
> From: Bean Huo <beanhuo@micron.com>
> 
> Resent this patchset since linux-scsi@vger.kernel.org and
> linux-kernel@vger.kernel.org rejected my email
> 
> 
> Cleanup UFS descriptor length initialization, and delete some unnecessary
> code.
> 
> Changelog:
> v4 - v5:
>     1. Rebased patch
>     2. In the patch 3/5, change "param_size > buff_len" to
>        "(param_offset + param_size) > buff_len"
> 
> v3 - v4:
>     1. add desc_id >= QUERY_DESC_IDN_MAX check in patch 4/5 (Avri Altman)
>     2. update buff_len to hold the true descriptor size in 4/5 (Avri Altman)
>     3. add new patch 3/5
> 
> v2 - v3:
>     1. Fix typo in the commit message (Avri Altman & Bart van Assche)
>     2. Delete ufshcd_init_desc_sizes() in patch 3/4 (Stanley Chu)
>     3. Remove max_t() and buff_len in patch 1/4 (Bart van Assche)
>     4. Add patch 4/4 to compatable with 3.1 UFS unit descriptor length
> 
> v1 - v2:
>     1. split patch
>     2. fix one compiling WARNING (Reported-by: kbuild test robot
> <lkp@intel.com>)
> 
> Bart van Assche (1):
>   scsi: ufs: remove max_t in ufs_get_device_desc
> 
> Bean Huo (4):
>   scsi: ufs: delete ufshcd_read_desc()
>   scsi: ufs: fix potential access NULL pointer while memcpy
>   scsi: ufs: cleanup ufs initialization path
>   scsi: ufs: add compatibility with 3.1 UFS unit descriptor length
> 
>  drivers/scsi/ufs/ufs.h     |  11 +-
>  drivers/scsi/ufs/ufs_bsg.c |   5 +-
>  drivers/scsi/ufs/ufshcd.c  | 207 +++++++++----------------------------
>  drivers/scsi/ufs/ufshcd.h  |  16 +--
>  4 files changed, 54 insertions(+), 185 deletions(-)
> 
> --
> 2.17.1
Martin K. Petersen June 16, 2020, 3:59 a.m. UTC | #2
On Wed, 3 Jun 2020 11:19:54 +0200, Bean Huo wrote:

> Resent this patchset since linux-scsi@vger.kernel.org and
> linux-kernel@vger.kernel.org rejected my email
> 
> 
> Cleanup UFS descriptor length initialization, and delete some unnecessary code.
> 
> Changelog:
> v4 - v5:
>     1. Rebased patch
>     2. In the patch 3/5, change "param_size > buff_len" to
>        "(param_offset + param_size) > buff_len"
> 
> [...]

Applied to 5.9/scsi-queue, thanks!

[1/5] scsi: ufs: Remove max_t in ufs_get_device_desc
      https://git.kernel.org/mkp/scsi/c/458a45f5262b
[2/5] scsi: ufs: Delete ufshcd_read_desc()
      https://git.kernel.org/mkp/scsi/c/c4607a09450d
[3/5] scsi: ufs: Fix potential NULL pointer access during memcpy
      https://git.kernel.org/mkp/scsi/c/cbe193f6f093
[4/5] scsi: ufs: Clean up ufs initialization path
      https://git.kernel.org/mkp/scsi/c/7a0bf85b5e18
[5/5] scsi: ufs: Add compatibility with 3.1 UFS unit descriptor length
      https://git.kernel.org/mkp/scsi/c/72fb690eece1