mbox series

[00/10] Fix compilation warnings

Message ID 20200706123344.451738-1-damien.lemoal@wdc.com (mailing list archive)
Headers show
Series Fix compilation warnings | expand

Message

Damien Le Moal July 6, 2020, 12:33 p.m. UTC 
These patches fix various compilation warnings showing with W=1 for
the megaraid and mpt3sas drivers as well as sd and sd_zbc drivers.
The warnings are mostly due to incorrectly formatted kdoc comments.
Some "set but unused variable" warnings are also fixed.

Overall, there is no functional change introduced by these patches.

Damien Le Moal (10):
  scsi: megaraid: Fix kdoc comments format
  scsi: megaraid: Fix compilation warnings
  scsi: megaraid: Remove set but unused variable
  scsi: megaraid: Remove set but unused variable
  scsi: megaraid: Fix set but unused variable
  scsi: megaraid: Remove set but unused variable
  scsi: sd: Fix kdoc comment format
  scsi: sd_zbc: Fix kdoc comment format
  scsi: mpt3sas: Fix set but unused variable
  scsi: mpt3sas: Fix kdoc comments format

 drivers/scsi/megaraid.c                     | 222 ++++++++++----------
 drivers/scsi/megaraid/megaraid_mbox.c       |   4 +-
 drivers/scsi/megaraid/megaraid_mm.c         |   1 -
 drivers/scsi/megaraid/megaraid_sas.h        |  20 ++
 drivers/scsi/megaraid/megaraid_sas_base.c   | 175 ++++++++-------
 drivers/scsi/megaraid/megaraid_sas_fp.c     |  11 +-
 drivers/scsi/megaraid/megaraid_sas_fusion.c |  93 ++++----
 drivers/scsi/mpt3sas/mpt3sas_base.c         |  14 +-
 drivers/scsi/mpt3sas/mpt3sas_config.c       |   7 +-
 drivers/scsi/mpt3sas/mpt3sas_ctl.c          |  16 +-
 drivers/scsi/sd.c                           |   2 +-
 drivers/scsi/sd_zbc.c                       |   2 +-
 12 files changed, 304 insertions(+), 263 deletions(-)

Comments

Martin K. Petersen July 8, 2020, 6:11 a.m. UTC | #1 
On Mon, 6 Jul 2020 09:04:50 +0900, Damien Le Moal wrote:

> Commit c7e4dd5d84fc ("scsi: mpt3sas: Fix error returns in
> BRM_status_show") introduced a compilation warning:
> [...]

Not sure what was up with this series. Neither b4, nor lore could
figure it out. Had to do each patch individually. In any case: Applied
to 5.9/scsi-queue, thanks!
Damien Le Moal July 8, 2020, 6:24 a.m. UTC | #2 
On 2020/07/08 15:11, Martin K. Petersen wrote:
> On Mon, 6 Jul 2020 09:04:50 +0900, Damien Le Moal wrote:
> 
>> Commit c7e4dd5d84fc ("scsi: mpt3sas: Fix error returns in
>> BRM_status_show") introduced a compilation warning:
>> [...]
> 
> Not sure what was up with this series. Neither b4, nor lore could
> figure it out. Had to do each patch individually. In any case: Applied
> to 5.9/scsi-queue, thanks!

Weird... It was all based on 5.9/scsi-queue and generated with normal git
format-patch + git send-email.

By the way, the patch mentioned above is not part of that series and should go
in 5.8/scsi-fixes, no ?
Martin K. Petersen July 8, 2020, 6:30 a.m. UTC | #3 
Damien,

> By the way, the patch mentioned above is not part of that series and
> should go in 5.8/scsi-fixes, no ?

Oh, sorry. I replied to the wrong ty email.

I amended the offending mpt3sas commit in 5.8/scsi-fixes.
Damien Le Moal July 8, 2020, 6:36 a.m. UTC | #4 
On 2020/07/08 15:33, Martin K. Petersen wrote:
> 
> Damien,
> 
>> By the way, the patch mentioned above is not part of that series and
>> should go in 5.8/scsi-fixes, no ?
> 
> Oh, sorry. I replied to the wrong ty email.

I thought so :)

> 
> I amended the offending mpt3sas commit in 5.8/scsi-fixes.

Thanks !

>