| Message ID | 20200906012219.17893-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Rework runtime suspend and SCSI domain validation | expand |
On Sat, Sep 05, 2020 at 06:22:10PM -0700, Bart Van Assche wrote: > Hi Jens, > > The SCSI runtime suspend and domain validation mechanisms both use > scsi_device_quiesce(). scsi_device_quiesce() restricts blk_queue_enter() to > BLK_MQ_REQ_PREEMPT requests. There is a conflict between the requirements > of runtime suspend and SCSI domain validation: no requests must be sent to > runtime suspended devices that are in the state RPM_SUSPENDED while > BLK_MQ_REQ_PREEMPT requests must be processed during SCSI domain > validation. This conflict is resolved by reworking the SCSI domain > validation implementation. > > Hybernation and runtime suspend have been retested but SCSI domain > validation not yet. > > Please consider this patch series for kernel v5.10. > > Thanks, > > Bart. > > Alan Stern (1): > block: Do not accept any requests while suspended > > Bart Van Assche (8): > block: Fix a race in the runtime power management code > ide: Do not set the RQF_PREEMPT flag for sense requests > scsi: Pass a request queue pointer to __scsi_execute() > scsi: Rework scsi_mq_alloc_queue() > scsi: Do not wait for a request in scsi_eh_lock_door() > scsi_transport_spi: Make spi_execute() accept a request queue pointer > scsi_transport_spi: Freeze request queues instead of quiescing > block, scsi, ide: Only process PM requests if rpm_status != RPM_ACTIVE I don't know enough about the IDE subsystem to judge patches 2 or 8. For patches 3 - 7: Reviewed-by: Alan Stern <stern@rowland.harvard.edu> Alan Stern
On 2020-09-05 18:22, Bart Van Assche wrote: > The SCSI runtime suspend and domain validation mechanisms both use > scsi_device_quiesce(). scsi_device_quiesce() restricts blk_queue_enter() to > BLK_MQ_REQ_PREEMPT requests. There is a conflict between the requirements > of runtime suspend and SCSI domain validation: no requests must be sent to > runtime suspended devices that are in the state RPM_SUSPENDED while > BLK_MQ_REQ_PREEMPT requests must be processed during SCSI domain > validation. This conflict is resolved by reworking the SCSI domain > validation implementation. > > Hybernation and runtime suspend have been retested but SCSI domain > validation not yet. Hi Martin and James, Please advise how to proceed with this patch series. This patch series includes an important fix for runtime power management. Unfortunately the only way to fix runtime powermanagement is by reworking SPI DV and I don't have access to a setup on which I can test the SPI DV changes. Thanks, Bart.
On 9/19/20 5:45 AM, Bart Van Assche wrote: > On 2020-09-05 18:22, Bart Van Assche wrote: >> The SCSI runtime suspend and domain validation mechanisms both use >> scsi_device_quiesce(). scsi_device_quiesce() restricts blk_queue_enter() to >> BLK_MQ_REQ_PREEMPT requests. There is a conflict between the requirements >> of runtime suspend and SCSI domain validation: no requests must be sent to >> runtime suspended devices that are in the state RPM_SUSPENDED while >> BLK_MQ_REQ_PREEMPT requests must be processed during SCSI domain >> validation. This conflict is resolved by reworking the SCSI domain >> validation implementation. >> >> Hybernation and runtime suspend have been retested but SCSI domain >> validation not yet. > > Hi Martin and James, > > Please advise how to proceed with this patch series. This patch series > includes an important fix for runtime power management. Unfortunately > the only way to fix runtime powermanagement is by reworking SPI DV and > I don't have access to a setup on which I can test the SPI DV changes. > I'll check if I can resurrect my setup. Cheers, Hannes
On 19.09.20 05:45, Bart Van Assche wrote: > On 2020-09-05 18:22, Bart Van Assche wrote: >> The SCSI runtime suspend and domain validation mechanisms both use >> scsi_device_quiesce(). scsi_device_quiesce() restricts blk_queue_enter() to >> BLK_MQ_REQ_PREEMPT requests. There is a conflict between the requirements >> of runtime suspend and SCSI domain validation: no requests must be sent to >> runtime suspended devices that are in the state RPM_SUSPENDED while >> BLK_MQ_REQ_PREEMPT requests must be processed during SCSI domain >> validation. This conflict is resolved by reworking the SCSI domain >> validation implementation. >> >> Hybernation and runtime suspend have been retested but SCSI domain >> validation not yet. > > Hi Martin and James, > > Please advise how to proceed with this patch series. This patch series > includes an important fix for runtime power management. Unfortunately > the only way to fix runtime powermanagement is by reworking SPI DV and > I don't have access to a setup on which I can test the SPI DV changes. > > Thanks, > > Bart. > I only have my setup: SD cardreader connected via USB. I run this series which fixes runtime PM in the block layer for me. Sidenote: I need the following hack for my particular device too: https://lore.kernel.org/linux-scsi/20200824190400.12339-1-martin.kepplinger@puri.sm/ I hope someone else can test the rest for us! thanks for working on this, martin
Hi Hannes,
> I'll check if I can resurrect my setup.
I'm afraid I don't have any SPI stuff to test with and it would be good
to get at least a basic smoke test performed on this series. So if you
have a setup to try it on that would be much appreciated.
Thanks!