[v2,0/3] Improve error handling

Message

Damien Le Moal Sept. 10, 2020, 7:48 a.m. UTC

A small series to improve command error hadling.

The first patch is a simple code cleanup. The second patch updates
asc/ascq sense codes list. Finally, the third patch adds zone resource
errors handling for zoned block deives to return BLK_STS_DEV_RESOURCE,
similarly to what the NVMe driver does for ZNS devices.

Changes form v1:
* Removed unnecessary temporary debug message in patch 3

Damien Le Moal (3):
  scsi: Cleanup scsi_noretry_cmd()
  scsi: update additional sense codes list
  scsi: handle zone resources errors

 drivers/scsi/scsi_error.c  |  4 +--
 drivers/scsi/scsi_lib.c    |  9 +++++++
 drivers/scsi/sense_codes.h | 54 +++++++++++++++++++++++++++++++++++++-
 3 files changed, 64 insertions(+), 3 deletions(-)

Comments

Martin K. Petersen Sept. 16, 2020, 12:29 a.m. UTC | #1

Damien,

> A small series to improve command error hadling.
>
> The first patch is a simple code cleanup. The second patch updates
> asc/ascq sense codes list. Finally, the third patch adds zone resource
> errors handling for zoned block deives to return BLK_STS_DEV_RESOURCE,
> similarly to what the NVMe driver does for ZNS devices.

Applied 1+2 to 5.10/scsi-staging. I'll wait to see where the BLK_STS
stuff lands before applying patch 3. Thanks!

Damien Le Moal Sept. 16, 2020, 1:11 a.m. UTC | #2

On 2020/09/16 9:29, Martin K. Petersen wrote:
> 
> Damien,
> 
>> A small series to improve command error hadling.
>>
>> The first patch is a simple code cleanup. The second patch updates
>> asc/ascq sense codes list. Finally, the third patch adds zone resource
>> errors handling for zoned block deives to return BLK_STS_DEV_RESOURCE,
>> similarly to what the NVMe driver does for ZNS devices.
> 
> Applied 1+2 to 5.10/scsi-staging. I'll wait to see where the BLK_STS
> stuff lands before applying patch 3. Thanks!

Working on that with  Keith. Thanks !

Martin K. Petersen Sept. 22, 2020, 3:56 a.m. UTC | #3

On Thu, 10 Sep 2020 16:48:40 +0900, Damien Le Moal wrote:

> A small series to improve command error hadling.
> 
> The first patch is a simple code cleanup. The second patch updates
> asc/ascq sense codes list. Finally, the third patch adds zone resource
> errors handling for zoned block deives to return BLK_STS_DEV_RESOURCE,
> similarly to what the NVMe driver does for ZNS devices.
> 
> [...]

Applied to 5.10/scsi-queue, thanks!

[1/3] scsi: core: Clean up scsi_noretry_cmd()
      https://git.kernel.org/mkp/scsi/c/342c81eeaaf0
[2/3] scsi: core: Update additional sense codes list
      https://git.kernel.org/mkp/scsi/c/46c9d608f989