[00/14] scsi: Remove in_interrupt() usage.

Message

Sebastian Andrzej Siewior Nov. 26, 2020, 1:29 p.m. UTC

Folks,

in the discussion about preempt count consistency across kernel
configurations:

 https://lore.kernel.org/r/[e-mail]/

it was concluded that the usage of in_interrupt() and related context
checks should be removed from non-core code.

This includes allocation mode (GFP_*) decisions and avoidance of code paths
which might sleep.
In the long run, usage of 'preemptible, in_*irq etc.' should be banned from
driver code completely.

This series addresses most of the SCSI subsystem.
The first three patches have Fixes tags and address bugs were noticed during
review.

Sebastian

Comments

Martin K. Petersen Dec. 1, 2020, 5:06 a.m. UTC | #1

Sebastian,

> This series addresses most of the SCSI subsystem.  The first three
> patches have Fixes tags and address bugs were noticed during review.

Applied series to 5.11/scsi-staging except for the NCR patch. Would like
to see where that lands first.

Thanks!

Sebastian Andrzej Siewior Dec. 1, 2020, 9:08 a.m. UTC | #2

On 2020-12-01 00:06:55 [-0500], Martin K. Petersen wrote:
>
> Applied series to 5.11/scsi-staging except for the NCR patch. Would like
> to see where that lands first.

Thank you Martin.

> Thanks!

Sebastian

Martin K. Petersen Dec. 8, 2020, 4:51 a.m. UTC | #3

On Thu, 26 Nov 2020 14:29:38 +0100, Sebastian Andrzej Siewior wrote:

> Folks,
> 
> in the discussion about preempt count consistency across kernel
> configurations:
> 
>  https://lore.kernel.org/r/[e-mail]/
> 
> [...]

Applied to 5.11/scsi-queue, thanks!

[01/14] scsi: pm80xx: Do not sleep in atomic context.
        https://git.kernel.org/mkp/scsi/c/4ba9e516573e
[02/14] scsi: hisi_sas: Remove preemptible().
        https://git.kernel.org/mkp/scsi/c/18577cdcaeeb
[03/14] scsi: qla4xxx: qla4_82xx_crb_win_lock(): Remove in_interrupt().
        https://git.kernel.org/mkp/scsi/c/a93c38353198
[04/14] scsi: qla2xxx: qla82xx: Remove in_interrupt().
        https://git.kernel.org/mkp/scsi/c/8ac246bdd07a
[05/14] scsi: qla2xxx: tcm_qla2xxx: Remove BUG_ON(in_interrupt()).
        https://git.kernel.org/mkp/scsi/c/9fef41f25d60
[06/14] scsi: qla2xxx: init/os: Remove in_interrupt().
        https://git.kernel.org/mkp/scsi/c/4f6a57c23b1e
[07/14] scsi: qla4xxx: qla4_82xx_idc_lock(): Remove in_interrupt().
        https://git.kernel.org/mkp/scsi/c/3627668c2e2c
[08/14] scsi: qla4xxx: qla4_82xx_rom_lock(): Remove in_interrupt().
        https://git.kernel.org/mkp/scsi/c/014aced18aff
[09/14] scsi: mpt3sas: Remove in_interrupt().
        https://git.kernel.org/mkp/scsi/c/547c0d1aeb76
[10/14] scsi: myrb: Remove WARN_ON(in_interrupt()).
        https://git.kernel.org/mkp/scsi/c/3bc08b9545da
[11/14] scsi: myrs: Remove WARN_ON(in_interrupt()).
        https://git.kernel.org/mkp/scsi/c/ca6853693cbd
[12/14] scsi: NCR5380: Remove in_interrupt().
        (no commit info)
[13/14] scsi: message: fusion: Remove in_interrupt() usage in mpt_config().
        https://git.kernel.org/mkp/scsi/c/b8a5144370bc
[14/14] scsi: message: fusion: Remove in_interrupt() usage in mptsas_cleanup_fw_event_q().
        https://git.kernel.org/mkp/scsi/c/817a7c996786