From patchwork Tue Jan 5 18:58:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 12000133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE2EC433E6 for ; Tue, 5 Jan 2021 19:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3C7622D04 for ; Tue, 5 Jan 2021 19:01:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729239AbhAETB0 (ORCPT ); Tue, 5 Jan 2021 14:01:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbhAETBZ (ORCPT ); Tue, 5 Jan 2021 14:01:25 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56C34C061793; Tue, 5 Jan 2021 11:00:45 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id p22so1814872edu.11; Tue, 05 Jan 2021 11:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c5LZXFqIn7R6ClYrbd/6/3ilXkYKGJa1HfU8I20ifNQ=; b=UMo2yfkpB8AvlnBYGmcSD+GN0v2P93kzIO5HmMuC4rlmA0G38BGILNalSWjga7yuma PDhNzqGFsUHfF7NsgEbiaJ4vLrT9CrFi9Z5QN7S0R340K9THPaA2sxGoi8mblbUNwMo9 VAdBZzA/K00rP6mn+SHFHzg0ifqumdugVQEZx3kBb92drt6ga7l9KFaPwkSeJOOlFctq /izyzfBgxJpjaHkGgF75ptYsm4TJHGp6rxzZQbBDG4n21lHlMp3bS6eWPe52jRD0YOxa YcUB6NlOBCtAGM+lFmU+0rIXlp4CmfaSc8owGCAWKNxpakuTfgYBEZ0OCs+F3L5pftMr 6mEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c5LZXFqIn7R6ClYrbd/6/3ilXkYKGJa1HfU8I20ifNQ=; b=Iv+mrDE9gLFLiP/+ISRBUF9G78PCoZBwv0C1i7GTrhYDDAwwiXq5GJg+bFgYExlowU La5/362gQarPr+0LLGIadFURqoW2P2CEp5hR7GKrUXwRbaYnlVRlKA6ULtZwzXEFp8ui vpY4qYCPXXtOQ65QLvrpSgPq/Aj2mXxEzR/0Ucrf+o7u7qGhCXwhYQyBRdGL+68vfYXj Mpgs7p3qjg3eWYsw4Cq4Do9xTExfC+LRzfYKoYcbLnQuERkd84z6+p7Zn4rdfGq/f5o+ b4gVFK9nLTmQYUCEVikcNF5GCHlWtHps69BJDrSPQANKI3ib0zuCHH4rt4Zj8Wkrmdfh ntIw== X-Gm-Message-State: AOAM532bL8alQ5NOU79tQuqsxJ15ilSROyMj9AtcqNMOZQdDYn5dbaTL liV5hQXq+ThOG4o3Rc3n/ZA= X-Google-Smtp-Source: ABdhPJznueE1o/c0JdMAL2zDb2vf4Kz/hlQoaaf+SWuxB9TPtU7OsSSGi6W7WVwfCNZENmLZhaZ1wA== X-Received: by 2002:aa7:c698:: with SMTP id n24mr1166300edq.277.1609873244092; Tue, 05 Jan 2021 11:00:44 -0800 (PST) Received: from localhost.localdomain (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id z13sm205084edq.48.2021.01.05.11.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 11:00:43 -0800 (PST) From: Vladimir Oltean To: "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Paul Gortmaker , Pablo Neira Ayuso , Jiri Benc , Cong Wang , Jamal Hadi Salim , Stephen Hemminger , Eric Dumazet , George McCollister , Oleksij Rempel , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Arnd Bergmann , Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , Taehee Yoo , Jiri Pirko , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= , Paolo Abeni , Christian Brauner , Florian Westphal , linux-s390@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-parisc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, dev@openvswitch.org Subject: [RFC PATCH v2 net-next 00/12] Make .ndo_get_stats64 sleepable Date: Tue, 5 Jan 2021 20:58:50 +0200 Message-Id: <20210105185902.3922928-1-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Vladimir Oltean Changes in v2: - Addressed the recursion issues in .ndo_get_stats64 from bonding and net_failover. - Renamed netdev_lists_lock to netif_lists_lock - Stopped taking netif_lists_lock from drivers as much as possible. This series converts all callers of dev_get_stats() to be in sleepable context, so that we can do more work in the .ndo_get_stats64 method. The situation today is that if we have hardware that needs to be accessed through a slow bus like SPI, or through a firmware, we cannot do that directly in .ndo_get_stats64, so we have to poll counters periodically and return a cached (not up to date) copy in the atomic NDO callback. This is undesirable on both ends: more work than strictly needed is being done, and the end result is also worse (not guaranteed to be up to date). So converting the code paths to be compatible with sleeping seems to make more sense. This is marked as Request For Comments for a reason. Cc: Leon Romanovsky Cc: Heiko Carstens Cc: Vasily Gorbik Cc: linux-s390@vger.kernel.org Cc: Jay Vosburgh Cc: Veaceslav Falico Cc: Andy Gospodarek Cc: Sridhar Samudrala Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-parisc@vger.kernel.org Cc: Christian Brauner Vladimir Oltean (12): net: mark dev_base_lock for deprecation net: introduce a mutex for the netns interface lists net: procfs: hold netif_lists_lock when retrieving device statistics net: sysfs: don't hold dev_base_lock while retrieving device statistics s390/appldata_net_sum: hold the netdev lists lock when retrieving device statistics parisc/led: reindent the code that gathers device statistics parisc/led: hold the netdev lists lock when retrieving device statistics net: make dev_get_stats return void net: net_failover: ensure .ndo_get_stats64 can sleep net: bonding: ensure .ndo_get_stats64 can sleep net: mark ndo_get_stats64 as being able to sleep net: remove obsolete comments about ndo_get_stats64 context from eth drivers Documentation/networking/netdevices.rst | 8 +- Documentation/networking/statistics.rst | 9 +- arch/s390/appldata/appldata_net_sum.c | 33 ++--- drivers/leds/trigger/ledtrig-netdev.c | 9 +- drivers/net/bonding/bond_main.c | 121 +++++++++--------- drivers/net/ethernet/cisco/enic/enic_main.c | 1 - .../net/ethernet/hisilicon/hns/hns_ethtool.c | 51 ++++---- .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 7 +- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 7 +- drivers/net/ethernet/nvidia/forcedeth.c | 2 - drivers/net/ethernet/sfc/efx_common.c | 1 - drivers/net/ethernet/sfc/falcon/efx.c | 1 - drivers/net/net_failover.c | 63 ++++++--- drivers/parisc/led.c | 37 +++--- drivers/scsi/fcoe/fcoe_transport.c | 6 +- drivers/usb/gadget/function/rndis.c | 45 +++---- include/linux/netdevice.h | 13 +- include/net/bonding.h | 52 +++++++- include/net/net_failover.h | 9 +- include/net/net_namespace.h | 6 + net/8021q/vlanproc.c | 15 +-- net/core/dev.c | 69 ++++++---- net/core/net-procfs.c | 48 +++---- net/core/net-sysfs.c | 10 +- net/openvswitch/vport.c | 25 ++-- 25 files changed, 372 insertions(+), 276 deletions(-)