[v4,00/10] libata cleanups and improvements

Message

Damien Le Moal Aug. 7, 2021, 4:18 a.m. UTC

The first three patches of this series fix sparse and kernel bot
warnings (potential NULL pointer dereference and locking imbalance).

The following three patches cleanup libata-core code in the area of
device configuration (ata_dev_configure() function).

Patch 7 improves ata_read_log_page() to avoid unnecessary warning
messages and patch 8 adds an informational message on device scan to
advertize the features supported by a device.

Path 9 adds the new sysfs ahci device attribute ncq_prio_supported to
indicate that a disk supports NCQ priority. Patch 10 does the same for
the mpt3sas driver, adding the sas_ncq_prio_supported device attribute.

Changes from v3:
* Reworked patch 1
* Added patch 3 to fix a sparse warning discovered while checking
  patch 1 & 2
* Added reviewed-by tags

Changes from v2:
* Reworked patch 4 to avoid the need for an additional on-stack string
  for device information messages
* Added reviewed-by tags

Changes from v1:
* Added patch 1 and 2 to fix problems reported by the kernel test robot
* Use strscpy() instead of strcpy in patch 4
* Use sysfs_emit in patch 8 and 9 as suggested by Bart
* Fix typos in comments of the new sas_ncq_prio_supported attribute in
  patch 9

Damien Le Moal (10):
  libata: fix ata_host_alloc_pinfo()
  libata: fix ata_host_start()
  libata: fix sparse warning
  libata: cleanup device sleep capability detection
  libata: cleanup ata_dev_configure()
  libata: cleanup NCQ priority handling
  libata: fix ata_read_log_page() warning
  libata: print feature list on device scan
  libahci: Introduce ncq_prio_supported sysfs sttribute
  scsi: mpt3sas: Introduce sas_ncq_prio_supported sysfs sttribute

 drivers/ata/libahci.c              |   1 +
 drivers/ata/libata-core.c          | 288 ++++++++++++++++-------------
 drivers/ata/libata-sata.c          |  61 +++---
 drivers/ata/libata-scsi.c          |  60 +-----
 drivers/scsi/mpt3sas/mpt3sas_ctl.c |  19 ++
 include/linux/libata.h             |   5 +
 6 files changed, 227 insertions(+), 207 deletions(-)