| Message ID | 20211006030959.20533-1-peter.wang@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: ufs: support vops pre suspend for mediatek to disable auto-hibern8 | expand |
On 10/5/21 20:09, peter.wang@mediatek.com wrote: > Mediatek UFS design need disable auto-hibern8 before suspend. > This patch introduce an solution to do pre suspned before SSU > (sleep) command. > > Peter Wang (2): > scsi: ufs: support vops pre suspend > scsi: ufs: ufs-mediatek: disable auto-hibern8 before suspend Please always include a changelog when posting a new version of a patch series. I have the same comment about v3 as for v2: I don't think that this series is bisectable so please combine the two patches into one patch or add "if (status == PRE_CHANGE) return" in ufshcd_vops_suspend() in patch 1/2 and remove this again in patch 2/2. Thanks, Bart.
On Tue, 2021-10-05 at 21:02 -0700, Bart Van Assche wrote: > On 10/5/21 20:09, peter.wang@mediatek.com wrote: > > Mediatek UFS design need disable auto-hibern8 before suspend. > > This patch introduce an solution to do pre suspned before SSU > > (sleep) command. > > > > Peter Wang (2): > > scsi: ufs: support vops pre suspend > > scsi: ufs: ufs-mediatek: disable auto-hibern8 before suspend > > Please always include a changelog when posting a new version of a > patch > series. > > I have the same comment about v3 as for v2: I don't think that this > series is bisectable so please combine the two patches into one patch > or add "if (status == PRE_CHANGE) return" in ufshcd_vops_suspend() in > patch 1/2 and remove this again in patch 2/2. > > Thanks, > > Bart. Hi Bart, OK, will merge to one patch. Thanks for review. Peter
From: Peter Wang <peter.wang@mediatek.com> Mediatek UFS design need disable auto-hibern8 before suspend. This patch introduce an solution to do pre suspned before SSU (sleep) command. Peter Wang (2): scsi: ufs: support vops pre suspend scsi: ufs: ufs-mediatek: disable auto-hibern8 before suspend drivers/scsi/ufs/ufs-exynos.c | 6 ++- drivers/scsi/ufs/ufs-hisi.c | 6 ++- drivers/scsi/ufs/ufs-mediatek.c | 68 ++++++++++++++++++++++++++++++++- drivers/scsi/ufs/ufs-mediatek.h | 20 ++++++++++ drivers/scsi/ufs/ufs-qcom.c | 6 ++- drivers/scsi/ufs/ufshcd.c | 9 ++++- drivers/scsi/ufs/ufshcd.h | 8 ++-- 7 files changed, 114 insertions(+), 9 deletions(-)