mbox series

[0/1] scsi: ufs-pci: Force a full restore after suspend-to-disk

Message ID 20211012125914.21977-1-adrian.hunter@intel.com (mailing list archive)
Headers show
Series scsi: ufs-pci: Force a full restore after suspend-to-disk | expand

Message

Adrian Hunter Oct. 12, 2021, 12:59 p.m. UTC 
Hi

This patch ensures suspend-to-disk works with Host Performance Booster.
Since the Host Perfomance Booster feature was added in v5.15, please
consider this for v5.15 fixes.


Adrian Hunter (1):
      scsi: ufs-pci: Force a full restore after suspend-to-disk

 drivers/scsi/ufs/ufshcd-pci.c | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)


Regards
Adrian

Comments

Avri Altman Oct. 13, 2021, 10:46 a.m. UTC | #1 
> Hi
> 
> This patch ensures suspend-to-disk works with Host Performance Booster.
What is "suspend-to-disk"?
What power mode is used for that?

Thanks,
Avri

> Since the Host Perfomance Booster feature was added in v5.15, please
> consider this for v5.15 fixes.
> 
> 
> Adrian Hunter (1):
>       scsi: ufs-pci: Force a full restore after suspend-to-disk
> 
>  drivers/scsi/ufs/ufshcd-pci.c | 31 ++++++++++++++++---------------
>  1 file changed, 16 insertions(+), 15 deletions(-)
> 
> 
> Regards
> Adrian
Adrian Hunter Oct. 13, 2021, 11:41 a.m. UTC | #2 
On 13/10/2021 13:46, Avri Altman wrote:
>> Hi
>>
>> This patch ensures suspend-to-disk works with Host Performance Booster.
> What is "suspend-to-disk"?

Hibernation, refer kernel config CONFIG_HIBERNATION
i.e.

echo disk > /sys/power/state

> What power mode is used for that?

Same as spm_lvl except ufshcd_wl_poweroff() naturally uses the same as
shutdown i.e. POWERDOWN 

> 
> Thanks,
> Avri
> 
>> Since the Host Perfomance Booster feature was added in v5.15, please
>> consider this for v5.15 fixes.
>>
>>
>> Adrian Hunter (1):
>>       scsi: ufs-pci: Force a full restore after suspend-to-disk
>>
>>  drivers/scsi/ufs/ufshcd-pci.c | 31 ++++++++++++++++---------------
>>  1 file changed, 16 insertions(+), 15 deletions(-)
>>
>>
>> Regards
>> Adrian
Avri Altman Oct. 13, 2021, 12:33 p.m. UTC | #3 
> On 13/10/2021 13:46, Avri Altman wrote:
> >> Hi
> >>
> >> This patch ensures suspend-to-disk works with Host Performance Booster.
> > What is "suspend-to-disk"?
> 
> Hibernation, refer kernel config CONFIG_HIBERNATION i.e.
> 
> echo disk > /sys/power/state
> 
> > What power mode is used for that?
> 
> Same as spm_lvl except ufshcd_wl_poweroff() naturally uses the same as
> shutdown i.e. POWERDOWN
If spm_lvl is SSU3 - the device maintains its RAM.
On SSU4 however, the RAM is powered down.

> 
> >
> > Thanks,
> > Avri
> >
> >> Since the Host Perfomance Booster feature was added in v5.15, please
> >> consider this for v5.15 fixes.
> >>
> >>
> >> Adrian Hunter (1):
> >>       scsi: ufs-pci: Force a full restore after suspend-to-disk
> >>
> >>  drivers/scsi/ufs/ufshcd-pci.c | 31 ++++++++++++++++---------------
> >>  1 file changed, 16 insertions(+), 15 deletions(-)
> >>
> >>
> >> Regards
> >> Adrian