| Message ID | 20211021145918.2691762-1-ming.lei@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | block: keep quiesce & unquiesce balanced for scsi/dm | expand |
Verified with the blktests srp/, thanks Ming. Tested-by: Yi Zhang <yi.zhang@redhat.com> On Thu, Oct 21, 2021 at 11:00 PM Ming Lei <ming.lei@redhat.com> wrote: > > Hello Jens, > > Recently we merge the patch of e70feb8b3e68 ("blk-mq: support concurrent queue > quiesce/unquiesce") for fixing race between driver and block layer wrt. > queue quiesce. > > Yi reported that srp/002 is broken with this patch, turns out scsi and > dm don't keep the two balanced actually. > > So fix dm and scsi and make srp/002 pass again. > > > Ming Lei (3): > scsi: avoid to quiesce sdev->request_queue two times > scsi: make sure that request queue queiesce and unquiesce balanced > dm: don't stop request queue after the dm device is suspended > > drivers/md/dm.c | 10 ------ > drivers/scsi/scsi_lib.c | 70 ++++++++++++++++++++++++++------------ > include/scsi/scsi_device.h | 1 + > 3 files changed, 49 insertions(+), 32 deletions(-) > > -- > 2.31.1 >
On Thu, 21 Oct 2021 22:59:15 +0800, Ming Lei wrote: > Recently we merge the patch of e70feb8b3e68 ("blk-mq: support concurrent queue > quiesce/unquiesce") for fixing race between driver and block layer wrt. > queue quiesce. > > Yi reported that srp/002 is broken with this patch, turns out scsi and > dm don't keep the two balanced actually. > > [...] Applied, thanks! [1/3] scsi: avoid to quiesce sdev->request_queue two times commit: 256117fb3b4f8832d6b29485d49d37ccc4c314d5 [2/3] scsi: make sure that request queue queiesce and unquiesce balanced commit: fba9539fc2109740e70e77c303dec50d1411e11f [3/3] dm: don't stop request queue after the dm device is suspended commit: e719593760c34fbf346fc6e348113e042feb5f63 Best regards,
Hello Jens, Recently we merge the patch of e70feb8b3e68 ("blk-mq: support concurrent queue quiesce/unquiesce") for fixing race between driver and block layer wrt. queue quiesce. Yi reported that srp/002 is broken with this patch, turns out scsi and dm don't keep the two balanced actually. So fix dm and scsi and make srp/002 pass again. Ming Lei (3): scsi: avoid to quiesce sdev->request_queue two times scsi: make sure that request queue queiesce and unquiesce balanced dm: don't stop request queue after the dm device is suspended drivers/md/dm.c | 10 ------ drivers/scsi/scsi_lib.c | 70 ++++++++++++++++++++++++++------------ include/scsi/scsi_device.h | 1 + 3 files changed, 49 insertions(+), 32 deletions(-)