mbox series

[v4,0/3] block: show crypto capabilities in sysfs

Message ID 20220124215938.2769-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series block: show crypto capabilities in sysfs | expand

Message

Eric Biggers Jan. 24, 2022, 9:59 p.m. UTC
This series adds sysfs files that expose the inline encryption
capabilities of request queues.

Patches 1 and 2 are some related cleanups for existing blk-sysfs code.
Patch 3 is the real change; see there for more details.

This series applies to v5.17-rc1.

Changed v3 => v4:
   - Reworded a comment in patch 2.
   - Updated dates in sysfs documentation.
   - Added more Reviewed-by tags.

Changed v2 => v3:
   - Moved the documentation into Documentation/ABI/stable/sysfs-block,
     and improved it a bit.
   - Write "/sys/block/" instead of "/sys/class/block/".
   - Added Reviewed-by tags.

Changed v1 => v2:
   - Use sysfs_emit() instead of sprintf().
   - Use __ATTR_RO().

Eric Biggers (3):
  block: simplify calling convention of elv_unregister_queue()
  block: don't delete queue kobject before its children
  blk-crypto: show crypto capabilities in sysfs

 Documentation/ABI/stable/sysfs-block |  49 ++++++++
 block/Makefile                       |   3 +-
 block/blk-crypto-internal.h          |  12 ++
 block/blk-crypto-sysfs.c             | 172 +++++++++++++++++++++++++++
 block/blk-crypto.c                   |   3 +
 block/blk-sysfs.c                    |  17 ++-
 block/elevator.c                     |   8 +-
 include/linux/blkdev.h               |   1 +
 8 files changed, 255 insertions(+), 10 deletions(-)
 create mode 100644 block/blk-crypto-sysfs.c


base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07

Comments

Eric Biggers Feb. 21, 2022, 2:23 a.m. UTC | #1
On Mon, Jan 24, 2022 at 01:59:35PM -0800, Eric Biggers wrote:
> This series adds sysfs files that expose the inline encryption
> capabilities of request queues.
> 
> Patches 1 and 2 are some related cleanups for existing blk-sysfs code.
> Patch 3 is the real change; see there for more details.
> 
> This series applies to v5.17-rc1.
> 
> Changed v3 => v4:
>    - Reworded a comment in patch 2.
>    - Updated dates in sysfs documentation.
>    - Added more Reviewed-by tags.
> 
> Changed v2 => v3:
>    - Moved the documentation into Documentation/ABI/stable/sysfs-block,
>      and improved it a bit.
>    - Write "/sys/block/" instead of "/sys/class/block/".
>    - Added Reviewed-by tags.
> 
> Changed v1 => v2:
>    - Use sysfs_emit() instead of sprintf().
>    - Use __ATTR_RO().
> 
> Eric Biggers (3):
>   block: simplify calling convention of elv_unregister_queue()
>   block: don't delete queue kobject before its children
>   blk-crypto: show crypto capabilities in sysfs
> 

Any more feedback on this?

- Eric
Eric Biggers Feb. 28, 2022, 8:11 a.m. UTC | #2
On Sun, Feb 20, 2022 at 06:23:29PM -0800, Eric Biggers wrote:
> On Mon, Jan 24, 2022 at 01:59:35PM -0800, Eric Biggers wrote:
> > This series adds sysfs files that expose the inline encryption
> > capabilities of request queues.
> > 
> > Patches 1 and 2 are some related cleanups for existing blk-sysfs code.
> > Patch 3 is the real change; see there for more details.
> > 
> > This series applies to v5.17-rc1.
> > 
> > Changed v3 => v4:
> >    - Reworded a comment in patch 2.
> >    - Updated dates in sysfs documentation.
> >    - Added more Reviewed-by tags.
> > 
> > Changed v2 => v3:
> >    - Moved the documentation into Documentation/ABI/stable/sysfs-block,
> >      and improved it a bit.
> >    - Write "/sys/block/" instead of "/sys/class/block/".
> >    - Added Reviewed-by tags.
> > 
> > Changed v1 => v2:
> >    - Use sysfs_emit() instead of sprintf().
> >    - Use __ATTR_RO().
> > 
> > Eric Biggers (3):
> >   block: simplify calling convention of elv_unregister_queue()
> >   block: don't delete queue kobject before its children
> >   blk-crypto: show crypto capabilities in sysfs
> > 
> 
> Any more feedback on this?
> 

Jens, can you apply this for 5.18?  Is there anything else you're waiting for?

- Eric
Jens Axboe Feb. 28, 2022, 1:40 p.m. UTC | #3
On Mon, 24 Jan 2022 13:59:35 -0800, Eric Biggers wrote:
> This series adds sysfs files that expose the inline encryption
> capabilities of request queues.
> 
> Patches 1 and 2 are some related cleanups for existing blk-sysfs code.
> Patch 3 is the real change; see there for more details.
> 
> This series applies to v5.17-rc1.
> 
> [...]

Applied, thanks!

[1/3] block: simplify calling convention of elv_unregister_queue()
      commit: f5ec592dd3bcf7c91f7c262a7f5011e001d269cd
[2/3] block: don't delete queue kobject before its children
      commit: 0f69288253e9fc7c495047720e523b9f1aba5712
[3/3] blk-crypto: show crypto capabilities in sysfs
      commit: 20f01f163203666010ee1560852590a0c0572726

Best regards,