| Message ID | 20221213150942.988371-1-yanaijie@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | scsi: libsas: Some coding style fixes and cleanups | expand |
On 13/12/2022 15:09, Jason Yan wrote: > A few coding style fixes and cleanups. There should be no functional > changes in this series besides the debug log prints. > > v1->v2: > 1. Drop patch #2 in v1. > 2. Other misc changes suggested by John. Note: it would be better to concisely mention the actual changes, so that we know what to look for in the new version. Just writing something like "incorporate changes suggested by <insert name>" is unfortunately not much use. Thanks, John > > Jason Yan (5): > scsi: libsas: move sas_get_ata_command_set() up to save the > declaration > scsi: libsas: change the coding style of sas_discover_sata() > scsi: libsas: remove useless dev_list delete in > sas_ex_discover_end_dev() > scsi: libsas: factor out sas_ata_add_dev() > scsi: libsas: factor out sas_ex_add_dev() > > drivers/scsi/libsas/sas_ata.c | 88 ++++++++++++++++---- > drivers/scsi/libsas/sas_discover.c | 6 -- > drivers/scsi/libsas/sas_expander.c | 125 ++++++++++------------------- > include/scsi/libsas.h | 1 - > include/scsi/sas_ata.h | 15 ++++ > 5 files changed, 129 insertions(+), 106 deletions(-) >
On 2022/12/14 0:12, John Garry wrote: > On 13/12/2022 15:09, Jason Yan wrote: >> A few coding style fixes and cleanups. There should be no functional >> changes in this series besides the debug log prints. >> >> v1->v2: >> 1. Drop patch #2 in v1. >> 2. Other misc changes suggested by John. > > Note: it would be better to concisely mention the actual changes, so > that we know what to look for in the new version. Just writing something > like "incorporate changes suggested by <insert name>" is unfortunately > not much use. > Yeah, my bad. Thank you for your patience, John.
A few coding style fixes and cleanups. There should be no functional changes in this series besides the debug log prints. v1->v2: 1. Drop patch #2 in v1. 2. Other misc changes suggested by John. Jason Yan (5): scsi: libsas: move sas_get_ata_command_set() up to save the declaration scsi: libsas: change the coding style of sas_discover_sata() scsi: libsas: remove useless dev_list delete in sas_ex_discover_end_dev() scsi: libsas: factor out sas_ata_add_dev() scsi: libsas: factor out sas_ex_add_dev() drivers/scsi/libsas/sas_ata.c | 88 ++++++++++++++++---- drivers/scsi/libsas/sas_discover.c | 6 -- drivers/scsi/libsas/sas_expander.c | 125 ++++++++++------------------- include/scsi/libsas.h | 1 - include/scsi/sas_ata.h | 15 ++++ 5 files changed, 129 insertions(+), 106 deletions(-)