[v5,0/4] scsi: mpi3mr: fix issues found by KASAN

Message

Shinichiro Kawasaki Feb. 14, 2023, 12:50 a.m. UTC

While I downloaded new firmware to eHBA-9600 on KASAN enabled kernel, I observed
three BUGs. The first two patches resolve one of the BUGs and related issues
found during the review. The last two patches resolve the two left BUGs
respectively.

Changes from v4:
* Squashed 1st and 2nd patch and reflected more fixes Sathya identified
* 3rd patch: replaced kfree with bitmap_free and added a missing bitmap_free

Changes from v3:
* Moved 1st patch to 3rd to resolve a compiler warning

Changes from v2:
* Added 1st and 2nd patches to address issues found during review
* 3rd patch: changed fix approach per comment on the list
* Added Acked-by and Reviewed-by tags

Changes from v1:
* 2nd patch: Modified to use bitmap helper functions and number of bits
* 1st/3rd patches: Reflected a comment on the list and added Reviewed-by tags

Shin'ichiro Kawasaki (4):
  scsi: mpi3mr: fix issues in mpi3mr_get_all_tgt_info
  scsi: mpi3mr: remove unnecessary memcpy to alltgt_info->dmi
  scsi: mpi3mr: use number of bits to manage bitmap sizes
  scsi: mpi3mr: fix missing mrioc->evtack_cmds initialization

 drivers/scsi/mpi3mr/mpi3mr.h     | 10 +----
 drivers/scsi/mpi3mr/mpi3mr_app.c | 28 +++++-------
 drivers/scsi/mpi3mr/mpi3mr_fw.c  | 75 +++++++++++++-------------------
 drivers/scsi/mpi3mr/mpi3mr_os.c  |  4 ++
 4 files changed, 47 insertions(+), 70 deletions(-)

Comments

Martin K. Petersen Feb. 22, 2023, 12:57 a.m. UTC | #1

Shin'ichiro,

> While I downloaded new firmware to eHBA-9600 on KASAN enabled kernel,
> I observed three BUGs. The first two patches resolve one of the BUGs
> and related issues found during the review. The last two patches
> resolve the two left BUGs respectively.

Applied to 6.3/scsi-staging, thanks!