[v3,0/3] scsi: libsas: remove empty branches and code simplification

Message

Jason Yan April 21, 2023, 9:37 a.m. UTC

Three patches to remove two empty branches and a little code
simplification.

v2->v3:
  1. Drop patch #3.
  2. Factor out sas_check_edge_expander_topo().
  3. Factor out sas_check_fanout_expander_topo().

v1->v2:
  1. Add blank line after declaration in sas_eeds_valid().
  2. Drop the inner-most and outter-most parenthesis in sas_eeds_valid().
  3. Break the long line in the declaration of sas_check_phy_topology().
  4. Move "else if" to the same line after "}".

Jason Yan (3):
  scsi: libsas: Simplify sas_check_eeds()
  scsi: libsas: Remove an empty branch in sas_check_parent_topology()
  scsi: libsas: factor out sas_check_fanout_expander_topo()

 drivers/scsi/libsas/sas_expander.c | 124 +++++++++++++++++------------
 1 file changed, 71 insertions(+), 53 deletions(-)

Comments

Martin K. Petersen May 6, 2023, 10:20 p.m. UTC | #1

Jason,

> Three patches to remove two empty branches and a little code
> simplification.

Applied to 6.5/scsi-staging, thanks!

Martin K. Petersen May 17, 2023, 2:12 a.m. UTC | #2

On Fri, 21 Apr 2023 17:37:41 +0800, Jason Yan wrote:

> Three patches to remove two empty branches and a little code
> simplification.
> 
> v2->v3:
>   1. Drop patch #3.
>   2. Factor out sas_check_edge_expander_topo().
>   3. Factor out sas_check_fanout_expander_topo().
> 
> [...]

Applied to 6.5/scsi-queue, thanks!

[1/3] scsi: libsas: Simplify sas_check_eeds()
      https://git.kernel.org/mkp/scsi/c/e3be011e8280
[2/3] scsi: libsas: Remove an empty branch in sas_check_parent_topology()
      https://git.kernel.org/mkp/scsi/c/ba9be7e70e15
[3/3] scsi: libsas: factor out sas_check_fanout_expander_topo()
      https://git.kernel.org/mkp/scsi/c/cf3cd61e7660