mbox series

[00/12] smartpqi updates

Message ID 20230428153712.297638-1-don.brace@microchip.com (mailing list archive)
Headers show
Series smartpqi updates | expand

Message

Don Brace April 28, 2023, 3:37 p.m. UTC
These patches are based on Martin Petersen's 6.4/scsi-queue tree
  https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
  6.4/scsi-queue

This set of changes consists of:

 * Map entire BAR 0.
   The driver was mapping up to and including the controller registers,
   but not all of BAR 0.
 * Add PCI IDs to support new controllers.
 * Clean up some code by removing unnecessary NULL checks. 
   This cleanup is a result of a Coverity report.
 * Correct a rare memory leak whenever pqi_sas_port_add_rhpy() returns
   an error. This was Suggested by: Yang Yingliang <yangyingliang@huawei.com>
 * Remove atomic operations on variable raid_bypass_cnt. Accuracy is not
   required for driver operation. Change type from atomic_t to unsigned int.
 * Correct a rare drive hot-plug removal issue where we get a NULL
   io_request. We added a check for this condition.
 * Turn on NCQ priority for AIO requests to disks comprising RAID devices.
 * Correct byte aligned writew() operations on some ARM servers. Changed
   the writew() to two writeb() operations.
 * Change how the driver checks for a sanitize operation in progress.
   We were using TEST UNIT READY. We removed the TEST UNIT READY code and
   are now using the controller's firmware information in order to avoid
   issues caused by drives failing to complete TEST UNIT READY.
 * Some customers have been requesting that we add the NUMA node
   to /sys/block/sd<scsi device>/device like the nvme driver does.
 * Update the copyright information to match the current year.
 * Bump the driver version to 2.1.22-040.

---

David Strahan (1):
  smartpqi: Add new controller PCI IDs

Don Brace (5):
  smartpqi: fix-rare-sas-transport-mem-leak
  smartpqi: fix byte aligned writew for ARM servers
  smartpqi: Add sysfs entry for numa node in /sys/block/sdX/device.
  smartpqi: update copyright to 2023
  smartpqi: update version to 2.1.22-040

Gilbert Wu (1):
  smartpqi: Add support for RAID NCQ priority

Kevin Barnett (2):
  smartpqi: remove null pointer check
  smartpqi: stop sending driver initiated TURs

Mike McGowen (2):
  smartpqi: map full length of PCI BAR 0
  smartpqi: Remove contention for raid_bypass_cnt

Murthy Bhat (1):
  smartpqi: validate block layer host tag

 drivers/scsi/smartpqi/Kconfig                 |   2 +-
 drivers/scsi/smartpqi/smartpqi.h              |   6 +-
 drivers/scsi/smartpqi/smartpqi_init.c         | 284 ++++++++++--------
 .../scsi/smartpqi/smartpqi_sas_transport.c    |  34 +--
 drivers/scsi/smartpqi/smartpqi_sis.c          |   2 +-
 drivers/scsi/smartpqi/smartpqi_sis.h          |   2 +-
 6 files changed, 178 insertions(+), 152 deletions(-)

Comments

Martin K. Petersen May 6, 2023, 10:43 p.m. UTC | #1
Don,

> This set of changes consists of:
>
>  * Map entire BAR 0.
>    The driver was mapping up to and including the controller registers,
>    but not all of BAR 0.
>  * Add PCI IDs to support new controllers.
>  * Clean up some code by removing unnecessary NULL checks. 
>    This cleanup is a result of a Coverity report.
>  * Correct a rare memory leak whenever pqi_sas_port_add_rhpy() returns
>    an error. This was Suggested by: Yang Yingliang <yangyingliang@huawei.com>
>  * Remove atomic operations on variable raid_bypass_cnt. Accuracy is not
>    required for driver operation. Change type from atomic_t to unsigned int.
>  * Correct a rare drive hot-plug removal issue where we get a NULL
>    io_request. We added a check for this condition.
>  * Turn on NCQ priority for AIO requests to disks comprising RAID devices.
>  * Correct byte aligned writew() operations on some ARM servers. Changed
>    the writew() to two writeb() operations.
>  * Change how the driver checks for a sanitize operation in progress.
>    We were using TEST UNIT READY. We removed the TEST UNIT READY code and
>    are now using the controller's firmware information in order to avoid
>    issues caused by drives failing to complete TEST UNIT READY.
>  * Some customers have been requesting that we add the NUMA node
>    to /sys/block/sd<scsi device>/device like the nvme driver does.
>  * Update the copyright information to match the current year.
>  * Bump the driver version to 2.1.22-040.

Applied to 6.5/scsi-staging, thanks!
Martin K. Petersen May 17, 2023, 2:12 a.m. UTC | #2
On Fri, 28 Apr 2023 10:37:00 -0500, Don Brace wrote:

> These patches are based on Martin Petersen's 6.4/scsi-queue tree
>   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git
>   6.4/scsi-queue
> 
> This set of changes consists of:
> 
> * Map entire BAR 0.
>    The driver was mapping up to and including the controller registers,
>    but not all of BAR 0.
>  * Add PCI IDs to support new controllers.
>  * Clean up some code by removing unnecessary NULL checks.
>    This cleanup is a result of a Coverity report.
>  * Correct a rare memory leak whenever pqi_sas_port_add_rhpy() returns
>    an error. This was Suggested by: Yang Yingliang <yangyingliang@huawei.com>
>  * Remove atomic operations on variable raid_bypass_cnt. Accuracy is not
>    required for driver operation. Change type from atomic_t to unsigned int.
>  * Correct a rare drive hot-plug removal issue where we get a NULL
>    io_request. We added a check for this condition.
>  * Turn on NCQ priority for AIO requests to disks comprising RAID devices.
>  * Correct byte aligned writew() operations on some ARM servers. Changed
>    the writew() to two writeb() operations.
>  * Change how the driver checks for a sanitize operation in progress.
>    We were using TEST UNIT READY. We removed the TEST UNIT READY code and
>    are now using the controller's firmware information in order to avoid
>    issues caused by drives failing to complete TEST UNIT READY.
>  * Some customers have been requesting that we add the NUMA node
>    to /sys/block/sd<scsi device>/device like the nvme driver does.
>  * Update the copyright information to match the current year.
>  * Bump the driver version to 2.1.22-040.
> 
> [...]

Applied to 6.5/scsi-queue, thanks!

[01/12] smartpqi: map full length of PCI BAR 0
        https://git.kernel.org/mkp/scsi/c/3e7e55aa3df2
[02/12] smartpqi: Add new controller PCI IDs
        https://git.kernel.org/mkp/scsi/c/fe0375d48513
[03/12] smartpqi: remove null pointer check
        https://git.kernel.org/mkp/scsi/c/889cda36db99
[04/12] smartpqi: fix-rare-sas-transport-mem-leak
        https://git.kernel.org/mkp/scsi/c/2312e844dc8d
[05/12] smartpqi: Remove contention for raid_bypass_cnt
        https://git.kernel.org/mkp/scsi/c/80d560d94fa9
[06/12] smartpqi: validate block layer host tag
        https://git.kernel.org/mkp/scsi/c/5c9e3c1c5276
[07/12] smartpqi: Add support for RAID NCQ priority
        https://git.kernel.org/mkp/scsi/c/68f7920492be
[08/12] smartpqi: fix byte aligned writew for ARM servers
        https://git.kernel.org/mkp/scsi/c/c23efd9eadd8
[09/12] smartpqi: stop sending driver initiated TURs
        https://git.kernel.org/mkp/scsi/c/2eddf98d0152
[10/12] smartpqi: Add sysfs entry for numa node in /sys/block/sdX/device.
        https://git.kernel.org/mkp/scsi/c/d2c7583f27cc
[11/12] smartpqi: update copyright to 2023
        https://git.kernel.org/mkp/scsi/c/49fd52d4991f
[12/12] smartpqi: update version to 2.1.22-040
        https://git.kernel.org/mkp/scsi/c/fcb405111a24