| Message ID | 20230912085338.434381-1-dlemoal@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Minor cleanups | expand |
On 12.09.23 10:53, Damien Le Moal wrote: > 3 patches to cleanup libsas functions declarations. No functional > changes. > > Changes from v1: > * Added sas_init_dev() declaration change to patch 1 > * Added John's review tag > > Damien Le Moal (3): > scsi: libsas: Move local functions declarations to sas_internal.h > scsi: libsas: Declare sas_set_phy_speed() static > scsi: libsas: Declare sas_discover_end_dev() static > > drivers/scsi/libsas/sas_discover.c | 2 +- > drivers/scsi/libsas/sas_init.c | 4 ++-- > drivers/scsi/libsas/sas_internal.h | 12 ++++++++++++ > include/scsi/libsas.h | 17 ----------------- > 4 files changed, 15 insertions(+), 20 deletions(-) > When applying the patches checkpatch.pl spits out this warning: Applying: scsi: libsas: Move local functions declarations to sas_internal.h WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct asd_sas_port *' should also have an identifier name #16: FILE: drivers/scsi/libsas/sas_internal.h:49: +void sas_discover_event(struct asd_sas_port *, enum discover_event ev); total: 0 errors, 1 warnings, 46 lines checked Other than the above nit: Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 9/12/23 22:43, Johannes Thumshirn wrote: > On 12.09.23 10:53, Damien Le Moal wrote: >> 3 patches to cleanup libsas functions declarations. No functional >> changes. >> >> Changes from v1: >> * Added sas_init_dev() declaration change to patch 1 >> * Added John's review tag >> >> Damien Le Moal (3): >> scsi: libsas: Move local functions declarations to sas_internal.h >> scsi: libsas: Declare sas_set_phy_speed() static >> scsi: libsas: Declare sas_discover_end_dev() static >> >> drivers/scsi/libsas/sas_discover.c | 2 +- >> drivers/scsi/libsas/sas_init.c | 4 ++-- >> drivers/scsi/libsas/sas_internal.h | 12 ++++++++++++ >> include/scsi/libsas.h | 17 ----------------- >> 4 files changed, 15 insertions(+), 20 deletions(-) >> > > When applying the patches checkpatch.pl spits out this warning: > > Applying: scsi: libsas: Move local functions declarations to sas_internal.h > WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct > asd_sas_port *' should also have an identifier name > #16: FILE: drivers/scsi/libsas/sas_internal.h:49: > +void sas_discover_event(struct asd_sas_port *, enum discover_event ev); > > total: 0 errors, 1 warnings, 46 lines checked > > Other than the above nit: > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Thanks. Sent v3 to fix that, and also a repeated word in the commit message of patch 3 that checkpatch complains about.