[v2,0/2] Fix runtime suspended device resume

Message

Damien Le Moal Nov. 20, 2023, 10:56 p.m. UTC

The first patch changes the use of the bool type back to the regular
unsigned:1 for the manage_xxx scsi device flags. This is marked as a fix
and CC-stable to avoid issues with later eventual fixes in this area.

The second patch addresses an issue with system resume with devices that
were runtime suspended. For ATA devices, this leads to a disk still
being reported as suspended while it is in fact spun up due to how ATA
resume is done (port reset).

Changes from v1:
 - Fixed typos in patch 2 commit message.

Damien Le Moal (2):
  scsi: Change scsi device boolean fields to single bit flags
  scsi: sd: fix system start for ATA devices

 drivers/ata/libata-scsi.c  |  9 +++++++--
 drivers/firewire/sbp2.c    |  6 +++---
 drivers/scsi/sd.c          |  9 ++++++++-
 include/scsi/scsi_device.h | 12 +++++++++---
 4 files changed, 27 insertions(+), 9 deletions(-)

Comments

Martin K. Petersen Nov. 25, 2023, 2:53 a.m. UTC | #1

On Tue, 21 Nov 2023 07:56:29 +0900, Damien Le Moal wrote:

> The first patch changes the use of the bool type back to the regular
> unsigned:1 for the manage_xxx scsi device flags. This is marked as a fix
> and CC-stable to avoid issues with later eventual fixes in this area.
> 
> The second patch addresses an issue with system resume with devices that
> were runtime suspended. For ATA devices, this leads to a disk still
> being reported as suspended while it is in fact spun up due to how ATA
> resume is done (port reset).
> 
> [...]

Applied to 6.7/scsi-fixes, thanks!

[1/2] scsi: Change scsi device boolean fields to single bit flags
      https://git.kernel.org/mkp/scsi/c/6371be7aeb98
[2/2] scsi: sd: fix system start for ATA devices
      https://git.kernel.org/mkp/scsi/c/b09d7f8fd50f