From patchwork Fri Oct 25 13:14:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 13850684 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 886531632E9 for ; Fri, 25 Oct 2024 13:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729862092; cv=none; b=CDQncSvgtcGIZdzQ1YWJZupc04d5bpfJBh5vWYfc2dVel6jwJ+midTe0xrnBRlHNxGs4KZYtxkQn7stg0kbEHxNPBfZHDkx/dXeV5+cVC3oACQ+pJzX6H5kYXXH6ReTdWSQr+83sz0KIApm7OFGevCro9onJOpQhXjXtAtiWHaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729862092; c=relaxed/simple; bh=ZwDNgPLe3JseppPOXSDpV9E+7gvgETuHHerjXax3kFk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mvFixRtvFuWuE0EwmOqApnvGtUrAJoGbTcyUNug8KJGPBqbA5P8vCnbqh+fQXblOUvWwA5PGPLVHikpvuwgOCgNj5Y5oZGzIlS3J11ED3R4me8myJCedjO7QPSvXf16XEqPFbYnl7pbOj+5ckTudSlGvBfNJfEDmjXLYFfiEB5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=R4EYUh8R; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R4EYUh8R" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43161c0068bso19984175e9.1 for ; Fri, 25 Oct 2024 06:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729862088; x=1730466888; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6vAbSDgK0b1SDTMA/GPAVlnGTwcx5lchK0srsbvvoMo=; b=R4EYUh8RCBfXSUxtsxryBMFdYrhAU17tE4Updv8CoV1AUxZCr9d1yQWTLLlXHiCkq5 nxtPoGwgn0Z96BcVhgY399Kfh9arN3SCtW5wVBtL5BUPaRWXvZ6vMdFc3vzi+D3ZTEeu cttF/q5WM8S/57x+cXg6WOz9x1rsb30IWZSx2s58EZ8T90Ht8v1D2CkIq/pVcsG77YyU dTDiUpbDpOyQb/wu0QftoJVZQs4NwNY9JoVGBG9bOIijiCnzfAuJg/Ux66McgBH+NUkV N24759cQA/q9tmFJ5qn6C38/vg2JWuoKjjA1ncvKMY1H0f4iDR6CX2b6rm8deLhODN0i 2brA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729862088; x=1730466888; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6vAbSDgK0b1SDTMA/GPAVlnGTwcx5lchK0srsbvvoMo=; b=i3iZytVSFYXQ+LbcXBBBJdoqrTWO6Jq7s7PBvRwrJqKjrWBwsapRlGBZ9teHt9v+cs CicJWQmWZPugWNo7YuXicWEufXtNgLdFAhDtqCC33b6vr4BCRMpID/sLR5gcoWRIEboF 52nJi9aPW+Otkb3xfJIUdg1ArvkkTGHTDB5xUNSC8kZBqmiijz56Ifo/EXtbNlNf0R+B yn1OfmayBXVHM8+Yu73Ibt14XFq8+Fk/vGzpVvif7ibOr44IVgk2XMNiI9S7Y2wJffgo u3vHjqLEbWRgkzflHE3Uxa9QtetFeRg6kH0Y4UjV2edyqzzeLZNX+pfPT3O8cVxICGvp 2/+A== X-Forwarded-Encrypted: i=1; AJvYcCWk4Q5yB+2TrV2LLSirczYjkGHevDNWeLWYoXeP4AtPbE9Nj4kDbzobPeg5mIfaA0Ja6ry/SgWtlwFN@vger.kernel.org X-Gm-Message-State: AOJu0YwkbEl4154obFlw7iJRSr+Im5PYLAsA8zdI+4KE3AgQoeK6V/zU e7Igt3CDJFAezpTFTmnF6GThX3KIIfYr3mL4v8yziYEQ5idyOTgQG2i6Xw9WthuwHTJIzgTaend HIbU= X-Google-Smtp-Source: AGHT+IFHcTwJLU6dRFhjx0/7uuUyXfb0Sw0nQJJsfub37C8aAlLQ3WhmzctGx6Mxs5zTAXbGyd3rng== X-Received: by 2002:a05:600c:3b90:b0:431:5ba1:a513 with SMTP id 5b1f17b1804b1-431841fdca7mr89863325e9.10.1729862087824; Fri, 25 Oct 2024 06:14:47 -0700 (PDT) Received: from gpeter-l.lan ([145.224.67.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4318b58b6bdsm47616685e9.45.2024.10.25.06.14.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 06:14:46 -0700 (PDT) From: Peter Griffin To: alim.akhtar@samsung.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, avri.altman@wdc.com, bvanassche@acm.org, krzk@kernel.org Cc: tudor.ambarus@linaro.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, ebiggers@kernel.org, Peter Griffin Subject: [PATCH v2 00/11] UFS cleanups and enhancements to ufs-exynos for gs101 Date: Fri, 25 Oct 2024 14:14:31 +0100 Message-ID: <20241025131442.112862-1-peter.griffin@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi folks, This series provides a few cleanups, bug fixes and feature enhancements for the ufs-exynos driver, particularly for gs101 SoC. Regarding cleanup we remove some unused phy attribute data that isn't required when EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR is not set. Regarding bug fixes the check for EXYNOS_UFS_OPT_UFSPR_SECURE is moved inside exynos_ufs_config_smu() which fixes a Serror in the resume path for gs101. Regarding feature enhancements: * Gear 4 is enabled which has higher speeds and better power management. * WriteBooster capability is enabled for gs101 which increases write performance. In v2 of this series additionally I've added following patches 8-11 which add * Clock gating and hibern8 capabilities are enabled for gs101. This leads to a significantly cooler phone when running the upstream kernel on Pixel 6. Approximately 10 degrees cooler after 20 minutes at a shell prompt. * AXI bus on gs101 is correctly configured for write line unique transactions * ACG is set to be controlled by UFS_ACG_DISABLE for gs101 In v1 I mentioned the phy hibern8 series in [1] that is still under discussion however further testing reveals hibern8 feature still works without the additional UFS phy register writes done in [1]. So this series can be merged as is. [1] https://lore.kernel.org/linux-arm-kernel/20241002201555.3332138-3-peter.griffin@linaro.org/T/ regards, Peter Changes since v1: - Remove superfluous struct device parameter to exynos_ufs_shareability() (Peter) - Add patches 8-11 (hibern8 fixes, WLU support etc) Peter Griffin (11): scsi: ufs: exynos: Allow UFS Gear 4 scsi: ufs: exynos: add check inside exynos_ufs_config_smu() scsi: ufs: exynos: gs101: remove EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL scsi: ufs: exynos: Add EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR check scsi: ufs: exynos: gs101: remove unused phy attribute fields scsi: ufs: exynos: remove tx_dif_p_nsec from exynosauto_ufs_drv_init() scsi: ufs: exynos: add gs101_ufs_drv_init() hook and enable WriteBooster scsi: ufs: exynos: enable write line unique transactions on gs101 scsi: ufs: exynos: set ACG to be controlled by UFS_ACG_DISABLE scsi: ufs: exynos: fix hibern8 notify callbacks scsi: ufs: exynos: gs101: enable clock gating with hibern8 drivers/ufs/host/ufs-exynos.c | 126 +++++++++++++++++++--------------- 1 file changed, 70 insertions(+), 56 deletions(-)