From patchwork Tue Nov 8 07:47:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiwoong Kim X-Patchwork-Id: 9416821 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E4C866022E for ; Tue, 8 Nov 2016 07:58:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D533C28A9E for ; Tue, 8 Nov 2016 07:58:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7A1E28AA8; Tue, 8 Nov 2016 07:58:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E23028A9E for ; Tue, 8 Nov 2016 07:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752920AbcKHH64 convert rfc822-to-8bit (ORCPT ); Tue, 8 Nov 2016 02:58:56 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:47379 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751998AbcKHH6z (ORCPT ); Tue, 8 Nov 2016 02:58:55 -0500 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OGB02ADHCAKRD20@mailout4.samsung.com> for linux-scsi@vger.kernel.org; Tue, 08 Nov 2016 16:47:08 +0900 (KST) X-AuditID: cbfee61b-f796f6d000004092-c1-582182fc063b Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 57.65.16530.CF281285; Tue, 8 Nov 2016 16:47:08 +0900 (KST) Received: from DOKWMADKIM02 ([12.36.166.218]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OGB00273CAKP670@mmp1.samsung.com>; Tue, 08 Nov 2016 16:47:08 +0900 (KST) From: Kiwoong Kim To: linux-scsi@vger.kernel.org, "Martin K. Petersen" , vinholikatti@gmail.com, "James E.J. Bottomley" Cc: =?UTF-8?B?7LaU7ZeM6rSR?= Subject: [PATCH v1] ufs: introduce setup_task_mgmt Date: Tue, 08 Nov 2016 16:47:08 +0900 Message-id: <001e01d23994$4eca9cd0$ec5fd670$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT X-Mailer: Microsoft Outlook 15.0 Thread-index: AdI5lEuYF3W2PKWbSi+dfQwScZmIKA== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t9jAd0/TYoRBnc2GVvMvtDEaLFqYp5F 9/UdbBbLj/9jstixsMqB1WPnrLvsHg8ObWbx+Pj0FotH35ZVjB6fN8kFsEa52WSkJqakFimk 5iXnp2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWPiY6eC T0IV9098YW1g3MvfxcjJISFgItExayYThC0mceHeerYuRi4OIYGljBIX/2xhhHDeM0rsXNDE CFLFJqAp8fTmVCaQhIjAfEaJvw8Xg7UzCxhKbLg/GaxIWMBIYv/xNWwgNouAqkTnor2sXYwc HLwClhKXjoSBhHkFBCV+TL7HAtGqLjFp3iJmCFtb4sm7C6wQFylI7P50FMwWEdCTuLvkPytE jYjEvhfvGCcwCsxCMmoWklGzkIyahaRlASPLKkaJ1ILkguKk9FyjvNRyveLE3OLSvHS95Pzc TYzgGHsmvYPx8C73Q4wCHIxKPLwOdxUihFgTy4orcw8xSnAwK4nwclcrRgjxpiRWVqUW5ccX leakFh9iNAX6dSKzlGhyPjD+80riDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhPLEnNTk0tSC2C 6WPi4JRqYNyx9ZrVActGk4cT5l42WVW44Z+pylbuE7+SVVj9nho+r9jBrzJbRjSw7tUUxsAj E1jbzsw3l132Se+57KsZ7S9eFfqd7N8R8EExSaDnGGvWP2XOtNdFZ5atY3nBat/3QsWNW+Tr zLmfilftvn2h+8XtBWKPfmWt2nnUUFzn21zFm/z692yeKh5VYinOSDTUYi4qTgQATwkLlccC AAA= X-MTR: 20000000000000000@CPGS Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some UFS host controller may need to configure some things before any task management request is issued Signed-off-by: Kiwoong Kim --- drivers/scsi/ufs/ufshcd.c | 1 + drivers/scsi/ufs/ufshcd.h | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index bf78321..fdb0502 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -4358,6 +4358,7 @@ static int ufshcd_issue_tm_cmd(struct ufs_hba *hba, int lun_id, int task_id, task_req_upiup->input_param2 = cpu_to_be32(task_id); /* send command to the controller */ + ufshcd_vops_setup_task_mgmt(hba, free_slot, tm_function); __set_bit(free_slot, &hba->outstanding_tasks); /* Make sure descriptors are ready before ringing the task doorbell */ diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h index f2a69c0..b084d89 100644 --- a/drivers/scsi/ufs/ufshcd.h +++ b/drivers/scsi/ufs/ufshcd.h @@ -263,6 +263,8 @@ struct ufs_pwr_mode_info { * to be set. * @setup_xfer_req: called before any transfer request is issued * to set some things + * @setup_task_mgmt: called before any task management request is issued + * to set some things * @suspend: called during host controller PM callback * @resume: called during host controller PM callback * @dbg_register_dump: used to dump controller debug information @@ -287,6 +289,7 @@ struct ufs_hba_variant_ops { struct ufs_pa_layer_attr *, struct ufs_pa_layer_attr *); void (*setup_xfer_req)(struct ufs_hba *, int, bool); + void (*setup_task_mgmt)(struct ufs_hba *, int, u8); int (*suspend)(struct ufs_hba *, enum ufs_pm_op); int (*resume)(struct ufs_hba *, enum ufs_pm_op); void (*dbg_register_dump)(struct ufs_hba *hba); @@ -811,6 +814,13 @@ static inline void ufshcd_vops_setup_xfer_req(struct ufs_hba *hba, int tag, return hba->vops->setup_xfer_req(hba, tag, is_cmd_not_null); } +static inline void ufshcd_vops_setup_task_mgmt(struct ufs_hba *hba, + int tag, u8 tm_function) +{ + if (hba->vops && hba->vops->setup_task_mgmt) + return hba->vops->setup_task_mgmt(hba, tag, tm_function); +} + static inline int ufshcd_vops_suspend(struct ufs_hba *hba, enum ufs_pm_op op) { if (hba->vops && hba->vops->suspend)