From patchwork Wed Jun 24 05:57:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Saxena X-Patchwork-Id: 6665781 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D0462C05AC for ; Wed, 24 Jun 2015 05:57:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EDF31203C2 for ; Wed, 24 Jun 2015 05:57:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3740205B1 for ; Wed, 24 Jun 2015 05:57:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751331AbbFXF5b (ORCPT ); Wed, 24 Jun 2015 01:57:31 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:33473 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbbFXF52 (ORCPT ); Wed, 24 Jun 2015 01:57:28 -0400 Received: by laka10 with SMTP id a10so19511542lak.0 for ; Tue, 23 Jun 2015 22:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=avagotech.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc:content-type; bh=hxbV31RDgp+qoK+s+bSkcrx5g01qGZf8GAplJ7jiig0=; b=Q6+L4xUqjzHwsacpzEkFcLe9aZ6frDavJPKfptYMCRb5f5QRlMkHfSt/N3jxcst4Vb 2jhw2J7g5/pWOXbURLbj5VOs+iDCegSBb2qoQjVvW8Ig9AoxjeokaNwRkdFzPsxCd7tP Cz1GTP4nWr2cxp0V+uP2tzEiaLMXKr9qgrUJU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc:content-type; bh=hxbV31RDgp+qoK+s+bSkcrx5g01qGZf8GAplJ7jiig0=; b=K5P7gck34STj76SE224b7GZePlJGUp5K5HYz1KinFss2uL77tZtWMp4ad0AZJ8WuMK OS4V1Q7h0JVh8oZznqePJ7SN/IMZdqyQ3F1P5Ic+NnKh1AiOcjdllkx4ZSlu1P9N14Rk vkMMBmS3gTvfmL9Fc+hfLmsZQVfm9ceCuB87ZltDw5tPbh2oJaNpYOKY4jEfpsnS4fxx 6/3LqIeSp5GQ0cKcd1d/Xp/P66mJGNht1dW/6/6mKE8eu3kUukZ96SABDbgjtMVvLYKU ggVJVw0mZn0mhkvRKK6FhwoyigFDFXQS4iA8VhNv/mFLBzgxi16sJD3QO8hXsr01Kz1k l2FA== X-Gm-Message-State: ALoCoQlkXs50nZgFKPntskqwX87BDYXk+RMEuK/Dh80CrHMyQtFL+4tqDJJL59+i6yMjWIqEDn4E X-Received: by 10.152.3.33 with SMTP id 1mr38434738laz.109.1435125445018; Tue, 23 Jun 2015 22:57:25 -0700 (PDT) From: Sumit Saxena References: <1435104805-11346-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1435104805-11346-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQE5QgfkA6UrzVhlIuHmmHAizOpK8J7qARig Date: Wed, 24 Jun 2015 11:27:22 +0530 Message-ID: <05b203753393a523dfc3873996c3760c@mail.gmail.com> Subject: RE: [PATCH] megaraid:Make functions static in the file megaraid_sas_base.c To: Nicholas Krause , Kashyap Desai Cc: Uday Lingala , JBottomley@odin.com, "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP -----Original Message----- From: Nicholas Krause [mailto:xerofoify@gmail.com] Sent: Wednesday, June 24, 2015 5:43 AM To: kashyap.desai@avagotech.com Cc: sumit.saxena@avagotech.com; uday.lingala@avagotech.com; JBottomley@odin.com; megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [PATCH] megaraid:Make functions static in the file megaraid_sas_base.c This makes various functions that have no external callers outside their definition/declaration in the file megaraid_sas_base.c to be declared as static now. Signed-off-by: Nicholas Krause --- drivers/scsi/megaraid/megaraid_sas_base.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) instance->instancet->fire_cmd(instance, @@ -1698,7 +1698,7 @@ static int megasas_slave_alloc(struct scsi_device *sdev) * @instance: Adapter soft state * */ -void megasas_complete_outstanding_ioctls(struct megasas_instance *instance) +static void megasas_complete_outstanding_ioctls(struct megasas_instance +*instance) { int i; struct megasas_cmd *cmd_mfi; @@ -1856,7 +1856,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance); static void process_fw_state_change_wq(struct work_struct *work); -void megasas_do_ocr(struct megasas_instance *instance) +static void megasas_do_ocr(struct megasas_instance *instance) { if ((instance->pdev->device == PCI_DEVICE_ID_LSI_SAS1064R) || (instance->pdev->device == PCI_DEVICE_ID_DELL_PERC5) || Acked-by: Sumit Saxena -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 4c3fc0e..dad2393 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -190,7 +190,7 @@ static int megasas_get_ld_vf_affiliation(struct megasas_instance *instance, int megasas_check_mpio_paths(struct megasas_instance *instance, struct scsi_cmnd *scmd); -void +static void megasas_issue_dcmd(struct megasas_instance *instance, struct megasas_cmd *cmd) {