From patchwork Thu Jun 1 12:08:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Milan P. Gandhi" X-Patchwork-Id: 9759485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BC4FC602BF for ; Thu, 1 Jun 2017 12:09:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C75020453 for ; Thu, 1 Jun 2017 12:09:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9102D2849A; Thu, 1 Jun 2017 12:09:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3585F20453 for ; Thu, 1 Jun 2017 12:09:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751083AbdFAMJB (ORCPT ); Thu, 1 Jun 2017 08:09:01 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:34558 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbdFAMJA (ORCPT ); Thu, 1 Jun 2017 08:09:00 -0400 Received: by mail-io0-f173.google.com with SMTP id k91so33812263ioi.1 for ; Thu, 01 Jun 2017 05:09:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:to:from:subject:organization:message-id :date:user-agent:mime-version:content-transfer-encoding; bh=bERDdjm7WozzQJ5wEv1gHvYqqsPYm+7NgbH6IF1Wqa8=; b=L2Wp+t54b++5eNMItbdhwNXAft8K79mH7/b2koW/7sTw+vXV0m+VqqNv0CuarO4R84 5Da8r0HyILIgkWLfbu+wzszK9cR8wXBkMPUmzHh5bPoW164tHdz3YBzjrpvs2g2r/1Qc +sJerT5UpEZTJSPgIVRv/MNE/OuFEXQLvdSOB/Ko0abfNEcYrw/4KK5LtFI/iywD+vu9 +D9etPFo2+FjcZfc1O+i/BV0Q7aotCjpT+KNeCw8NVz2WfvUsWc5d2UwJ4WICbBXKY6U UduC/NJnpTKCk3b4V4a5fULYnKFaUdXpw6Q3pasqaEzFlUama8Hb2W5hJp70qpIce7qD /f1Q== X-Gm-Message-State: AODbwcBjGVXa1jEPO4mrAkPJLaO7zS+RiJ6tlNcGZBTEsICWlMDWFO2x G6CC6gz76CHnNrvo X-Received: by 10.98.130.1 with SMTP id w1mr838750pfd.128.1496318939352; Thu, 01 Jun 2017 05:08:59 -0700 (PDT) Received: from [10.76.1.230] ([125.16.97.121]) by smtp.gmail.com with ESMTPSA id w67sm34947838pfi.2.2017.06.01.05.08.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Jun 2017 05:08:58 -0700 (PDT) Reply-To: mgandhi@redhat.com To: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, Laurence Oberman , Johannes Thumshirn From: "Milan P. Gandhi" Subject: [PATCH] Remove an extra out label in _fcoe_create function Organization: Red Hat Message-ID: <0d0539e8-ec2e-eac3-a91b-bfda55e83eca@redhat.com> Date: Thu, 1 Jun 2017 17:38:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes an extra out label in _fcoe_create function where we return if creation of FCOE interface is failed. Signed-off-by: Milan P. Gandhi Acked-by: Johannes Thumshirn --- drivers/scsi/fcoe/fcoe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 7b960d3..ea21e7b 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -2258,7 +2258,7 @@ static int _fcoe_create(struct net_device *netdev, enum fip_mode fip_mode, fcoe_interface_cleanup(fcoe); mutex_unlock(&fcoe_config_mutex); fcoe_ctlr_device_delete(ctlr_dev); - goto out; + return rc; } /* Make this the "master" N_Port */ @@ -2299,7 +2299,7 @@ static int _fcoe_create(struct net_device *netdev, enum fip_mode fip_mode, out_nodev: rtnl_unlock(); mutex_unlock(&fcoe_config_mutex); -out: + return rc; }