| Message ID | 0dbfe7a07c205bde3fc60408ce7aa55a@208suo.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | drivers/scsi: Fix typos in comments | expand |
On Fri, Jul 21, 2023 at 12:06:11AM +0800, pangzizhen001@208suo.com wrote: > Delete duplicate word "the" > > Signed-off-by: Zizhen Pang <pangzizhen001@208suo.com> > --- > drivers/scsi/dc395x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c > index c8e86f8a631e..077e76407c58 100644 > --- a/drivers/scsi/dc395x.c > +++ b/drivers/scsi/dc395x.c > @@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *acb, > struct ScsiReqBlk *srb, > /* > * KG: We should wait for the DMA FIFO to be empty ... > * but: it would be better to wait first for the SCSI FIFO and then > the > - * the DMA FIFO to become empty? How do we know, that the device > not already > + * DMA FIFO to become empty? How do we know, that the device not > already > * sent data to the FIFO in a MsgIn phase, eg.? > */ > if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) { I'd like to write the comment above instead as "We should wait for the DMA FIFO to be empty, but it would be better to wait first for the SCSI one and then the DMA one to be emptied..." But hey, you did not read review comments to all your submissions, many of them (including mine) asking you to not corrupt your patches like this one did. Hence NAK from me. Bye!
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index c8e86f8a631e..077e76407c58 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *acb, struct ScsiReqBlk *srb, /* * KG: We should wait for the DMA FIFO to be empty ... * but: it would be better to wait first for the SCSI FIFO and then the - * the DMA FIFO to become empty? How do we know, that the device not already + * DMA FIFO to become empty? How do we know, that the device
Delete duplicate word "the" Signed-off-by: Zizhen Pang <pangzizhen001@208suo.com> --- drivers/scsi/dc395x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) not already * sent data to the FIFO in a MsgIn phase, eg.? */ if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {