From patchwork Tue Aug 25 07:06:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murthy Bhat X-Patchwork-Id: 7068681 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 43151C05AC for ; Tue, 25 Aug 2015 07:06:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2E74120835 for ; Tue, 25 Aug 2015 07:06:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3933120833 for ; Tue, 25 Aug 2015 07:06:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbbHYHGi (ORCPT ); Tue, 25 Aug 2015 03:06:38 -0400 Received: from bby1mta03.pmc-sierra.com ([216.241.235.118]:60733 "EHLO bby1mta03.pmc-sierra.bc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbbHYHGh convert rfc822-to-8bit (ORCPT ); Tue, 25 Aug 2015 03:06:37 -0400 Received: from bby1mta03.pmc-sierra.bc.ca (localhost.pmc-sierra.bc.ca [127.0.0.1]) by localhost (Postfix) with SMTP id 83A52107083B; Tue, 25 Aug 2015 00:06:37 -0700 (PDT) Received: from smtp.pmcs.com (bby1cas01.pmc-sierra.internal [216.241.227.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by bby1mta03.pmc-sierra.bc.ca (Postfix) with ESMTP id 6331210707D3; Tue, 25 Aug 2015 00:06:37 -0700 (PDT) Received: from BBYEXM02.pmc-sierra.internal ([169.254.2.226]) by bby1cas01.pmc-sierra.internal ([2002:d8f1:e38e::d8f1:e38e]) with mapi id 14.03.0123.003; Tue, 25 Aug 2015 00:06:37 -0700 From: Murthy Bhat To: Karthikeya Sunkesula , Mahesh Rajashekhara , Tomas Henzl , "JBottomley@Parallels.com" , "linux-scsi@vger.kernel.org" CC: "aacraid@pmc-sierra.com" , Harry Yang , Rich Bono Subject: RE: [PATCH V6 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller Thread-Topic: [PATCH V6 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller Thread-Index: AQHQ0/rQoJGlFL+wz0iL7QOPLKpV5Z4cVg7AgAALHgA= Date: Tue, 25 Aug 2015 07:06:36 +0000 Message-ID: <13272BDD18A5F44CB23C497D29A37252DAB0F79C@BBYEXM02.pmc-sierra.internal> References: <1439272701-15344-1-git-send-email-Mahesh.Rajashekhara@pmcs.com> <1439272701-15344-4-git-send-email-Mahesh.Rajashekhara@pmcs.com> In-Reply-To: Accept-Language: en-US, en-CA Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [216.241.227.4] MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pmcs.com; h=from:to:cc:subject:date:message-id:references:in-reply-to:content-type:content-transfer-encoding:mime-version; s=default; bh=HKmDaoMwhmp2Fx6/tK5Cvno4uBuPOcHIa31z5ABXhSg=; b=mFU1wn78LngbTPhAewwiD+NwwP2amNVV6Spp58Ftzy/v0gF311OjbJb0vPB2Vyj/dgpp09Mp1kH+HNaadcLC2IpNWKgpwPXWxpDzuXWi/uHwktGVQ/ZgyKubUCiavKdoGi+vY4vTFynuUSAkFcGycvR5vUHMMPiC1p62Ro4DMzc= Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Reviewed-by: Murthy Bhat -----Original Message----- From: Karthikeya Sunkesula Sent: Tuesday, August 25, 2015 11:57 AM To: Mahesh Rajashekhara; Tomas Henzl; JBottomley@Parallels.com; linux-scsi@vger.kernel.org Cc: aacraid@pmc-sierra.com; Harry Yang; Rich Bono; Murthy Bhat Subject: RE: [PATCH V6 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller Reviewed-by: Karthikeya Sunkesula -----Original Message----- From: Mahesh Rajashekhara Sent: Tuesday, August 11, 2015 11:28 AM To: Tomas Henzl; JBottomley@Parallels.com; linux-scsi@vger.kernel.org Cc: aacraid@pmc-sierra.com; Harry Yang; Rich Bono; Mahesh Rajashekhara Subject: [PATCH V6 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller Description: This change always sets MSI interrupt mode for series-6 controller. Changes from V2: aac_msi option description and subject change. Signed-off-by: Mahesh Rajashekhara --- drivers/scsi/aacraid/aachba.c | 2 +- drivers/scsi/aacraid/src.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index fe59b00..05f2a02 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -259,7 +259,7 @@ MODULE_PARM_DESC(commit, "Control whether a COMMIT_CONFIG is issued to the" " 0=off, 1=on"); module_param_named(msi, aac_msi, int, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(msi, "IRQ handling." - " 0=PIC(default), 1=MSI, 2=MSI-X(unsupported, uses MSI)"); + " 0=PIC(default), 1=MSI, 2=MSI-X)"); module_param(startup_timeout, int, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(startup_timeout, "The duration of time in seconds to wait for" " adapter to have it's kernel up and\n" diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c index b147341..eb07b3d 100644 --- a/drivers/scsi/aacraid/src.c +++ b/drivers/scsi/aacraid/src.c @@ -742,7 +742,7 @@ int aac_src_init(struct aac_dev *dev) if (dev->comm_interface != AAC_COMM_MESSAGE_TYPE1) goto error_iounmap; - dev->msi = aac_msi && !pci_enable_msi(dev->pdev); + dev->msi = !pci_enable_msi(dev->pdev); dev->aac_msix[0].vector_no = 0; dev->aac_msix[0].dev = dev;