From patchwork Fri Mar 20 18:40:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Nicholas A. Bellinger" X-Patchwork-Id: 6059201 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6DD02BF90F for ; Fri, 20 Mar 2015 18:40:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8E0B120483 for ; Fri, 20 Mar 2015 18:40:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 400E420522 for ; Fri, 20 Mar 2015 18:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751376AbbCTSkW (ORCPT ); Fri, 20 Mar 2015 14:40:22 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:54036 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbbCTSkD (ORCPT ); Fri, 20 Mar 2015 14:40:03 -0400 Received: from [172.18.3.80] (unknown [157.22.22.146]) (using SSLv3 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: nab) by linux-iscsi.org (Postfix) with ESMTPSA id D351A22D9FF; Fri, 20 Mar 2015 18:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=linux-iscsi.org; s=default.private; t=1426876776; bh=Q3ig881TGtcWlaN978IyQoPGAOzdtio HkEy7Xx3P+W8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To: References:Content-Type:Mime-Version:Content-Transfer-Encoding; b=LixFAm2h8AFbjzv+wM7zIQ+Ue9vivWt4mv1SfmAPho5HZ3IjbWO4KsGl4GMRufoh6 OyRGeLvk2f+wS1ZbxMV2w1jYLDJe+4g529Hs5e0DXZ09IESYy2FeLyLVf+aGkudUP/N KiA3N+8pcFOwQPyou17SgP0rdYtCzbCA5nOYDlk= Message-ID: <1426876802.16687.4.camel@haakon3.risingtidesystems.com> Subject: Re: noise in target_core_register_fabric From: "Nicholas A. Bellinger" To: Olaf Hering Cc: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org Date: Fri, 20 Mar 2015 11:40:02 -0700 In-Reply-To: <20150318074947.GA21195@aepfle.de> References: <20150304154620.GA32023@aepfle.de> <20150318074947.GA21195@aepfle.de> X-Mailer: Evolution 3.4.4-1 Mime-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2015-03-18 at 08:49 +0100, Olaf Hering wrote: > On Wed, Mar 04, Olaf Hering wrote: > > > Is there a need to fill dmesg with noise like shown below whenever > > targetcli-3.0 runs a command? I think the pr_err calls in those functions > > should be converted to pr_debug. > > Any update on this? > > > [ 1240.045518] target_core_register_fabric() trying autoload for fc > > [ 1240.045520] target_core_get_fabric() failed for fc > Hi Olaf, Applying the following patch to target-pending/for-next. Thank you, --nab From 62554910a94a62f7b9b79cee3ca6bac95abe3c29 Mon Sep 17 00:00:00 2001 From: Nicholas Bellinger Date: Fri, 20 Mar 2015 11:36:50 -0700 Subject: [PATCH] target: Convert fabric module autoload failures to pr_debug This patch converts the fabric module autoload failures from pr_err to pr_debug in target_core_register_fabric() code, to reduce the amount of noise during normal operation. Reported-by: Olaf Hering Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_configfs.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 75d89ad..69baf1c 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -142,8 +142,8 @@ static struct config_group *target_core_register_fabric( tf = target_core_get_fabric(name); if (!tf) { - pr_err("target_core_register_fabric() trying autoload for %s\n", - name); + pr_debug("target_core_register_fabric() trying autoload for %s\n", + name); /* * Below are some hardcoded request_module() calls to automatically @@ -165,8 +165,8 @@ static struct config_group *target_core_register_fabric( */ ret = request_module("iscsi_target_mod"); if (ret < 0) { - pr_err("request_module() failed for" - " iscsi_target_mod.ko: %d\n", ret); + pr_debug("request_module() failed for" + " iscsi_target_mod.ko: %d\n", ret); return ERR_PTR(-EINVAL); } } else if (!strncmp(name, "loopback", 8)) { @@ -178,8 +178,8 @@ static struct config_group *target_core_register_fabric( */ ret = request_module("tcm_loop"); if (ret < 0) { - pr_err("request_module() failed for" - " tcm_loop.ko: %d\n", ret); + pr_debug("request_module() failed for" + " tcm_loop.ko: %d\n", ret); return ERR_PTR(-EINVAL); } } @@ -188,8 +188,8 @@ static struct config_group *target_core_register_fabric( } if (!tf) { - pr_err("target_core_get_fabric() failed for %s\n", - name); + pr_debug("target_core_get_fabric() failed for %s\n", + name); return ERR_PTR(-EINVAL); } pr_debug("Target_Core_ConfigFS: REGISTER -> Located fabric:"