diff mbox

[9/9] scsi_dh: don't allow to detach device handlers at runtime

Message ID 1430415151-30948-10-git-send-email-hch@lst.de (mailing list archive)
State New, archived
Headers show

Commit Message

Christoph Hellwig April 30, 2015, 5:32 p.m. UTC 
The I/O submission and completion pathes call into the device handler
without any synchronization agains detachment.  So disallow detaching
device handlers at runtime.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/scsi/device_handler/scsi_dh.c | 31 ++++++++++++++-----------------
 1 file changed, 14 insertions(+), 17 deletions(-)

Comments

Hannes Reinecke May 1, 2015, 7:19 a.m. UTC | #1 
On 04/30/2015 07:32 PM, Christoph Hellwig wrote:
> The I/O submission and completion pathes call into the device handler
> without any synchronization agains detachment.  So disallow detaching
> device handlers at runtime.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
Martin K. Petersen May 1, 2015, 3:46 p.m. UTC | #2 
>>>>> "Christoph" == Christoph Hellwig <hch@lst.de> writes:

Christoph> The I/O submission and completion pathes call into the device
Christoph> handler without any synchronization agains detachment.  So
Christoph> disallow detaching device handlers at runtime.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
diff mbox

Patch

diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
index 0d6ab33..1e945aa 100644
--- a/drivers/scsi/device_handler/scsi_dh.c
+++ b/drivers/scsi/device_handler/scsi_dh.c
@@ -142,17 +142,6 @@  static int scsi_dh_handler_attach(struct scsi_device *sdev,
 }
 
 /*
- * scsi_dh_handler_detach - Detach a device handler from a device
- * @sdev - SCSI device the device handler should be detached from
- */
-static void scsi_dh_handler_detach(struct scsi_device *sdev)
-{
-	sdev->handler->detach(sdev);
-	sdev_printk(KERN_NOTICE, sdev, "%s: Detached\n", sdev->handler->name);
-	module_put(sdev->handler->module);
-}
-
-/*
  * Functions for sysfs attribute 'dh_state'
  */
 static ssize_t
@@ -179,8 +168,9 @@  store_dh_state(struct device *dev, struct device_attribute *attr,
 			/*
 			 * Detach from a device handler
 			 */
-			scsi_dh_handler_detach(sdev);
-			err = 0;
+			sdev_printk(KERN_WARNING, sdev,
+				"can't detach handler %s!\n", buf);
+			err = -EINVAL;
 		} else if (!strncmp(buf, "activate", 8)) {
 			/*
 			 * Activate a device handler
@@ -230,8 +220,11 @@  int scsi_dh_add_device(struct scsi_device *sdev)
 
 void scsi_dh_remove_device(struct scsi_device *sdev)
 {
-	if (sdev->handler)
-		scsi_dh_handler_detach(sdev);
+	if (sdev->handler) {
+		sdev->handler->detach(sdev);
+		module_put(sdev->handler->module);
+	}
+
 	device_remove_file(&sdev->sdev_gendev, &scsi_dh_state_attr);
 }
 
@@ -393,15 +386,19 @@  int scsi_dh_attach(struct request_queue *q, const char *name)
 		goto out_put_device;
 	}
 
+	if (err)
+		return err;
+
 	if (sdev->handler) {
 		if (sdev->handler == scsi_dh)
 			goto out_put_device;
 
 		sdev_printk(KERN_WARNING, sdev,
-			"replacing device handler %s with %s!, "
+			"can't replace device handler %s with %s!, "
 			"please fix the device handler tables.\n",
 			sdev->handler->name, name);
-		scsi_dh_handler_detach(sdev);
+		err = -EINVAL;
+		goto out_put_device;
 	}
 
 	err = scsi_dh_handler_attach(sdev, scsi_dh);