From patchwork Thu Apr 30 17:32:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 6306481 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 38221BEEE1 for ; Thu, 30 Apr 2015 17:33:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7FA6D2013A for ; Thu, 30 Apr 2015 17:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9079D2012B for ; Thu, 30 Apr 2015 17:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751773AbbD3Rdq (ORCPT ); Thu, 30 Apr 2015 13:33:46 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:55076 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbbD3Rdp (ORCPT ); Thu, 30 Apr 2015 13:33:45 -0400 Received: from [83.175.99.196] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.80.1 #2 (Red Hat Linux)) id 1YnsLI-0005Gj-Hw; Thu, 30 Apr 2015 17:33:45 +0000 From: Christoph Hellwig To: linux-scsi@vger.kernel.org Cc: Hannes Reinecke , Mike Snitzer , Mike Christie , "Martin K. Petersen" Subject: [PATCH 1/9] dm-mpath: check kstrdup return value in parse_hw_handler Date: Thu, 30 Apr 2015 19:32:23 +0200 Message-Id: <1430415151-30948-2-git-send-email-hch@lst.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1430415151-30948-1-git-send-email-hch@lst.de> References: <1430415151-30948-1-git-send-email-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Acked-by: Mike Snitzer Reviewed-by: Martin K. Petersen --- drivers/md/dm-mpath.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 6395347..01e5f8e 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -732,6 +732,9 @@ static int parse_hw_handler(struct dm_arg_set *as, struct multipath *m) return 0; m->hw_handler_name = kstrdup(dm_shift_arg(as), GFP_KERNEL); + if (!m->hw_handler_name) + return -ENOMEM; + if (!try_then_request_module(scsi_dh_handler_exist(m->hw_handler_name), "scsi_dh_%s", m->hw_handler_name)) { ti->error = "unknown hardware handler type";