From patchwork Tue May 12 14:52:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 6388921 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D5B5CBEEE1 for ; Tue, 12 May 2015 15:00:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EC01D2038D for ; Tue, 12 May 2015 15:00:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1EAD2038A for ; Tue, 12 May 2015 15:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933149AbbELPAO (ORCPT ); Tue, 12 May 2015 11:00:14 -0400 Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:45580 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932488AbbELPAN (ORCPT ); Tue, 12 May 2015 11:00:13 -0400 X-Greylist: delayed 470 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 May 2015 11:00:13 EDT Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave08.hostedemail.com (Postfix) with ESMTP id DFC6B21229D for ; Tue, 12 May 2015 14:52:24 +0000 (UTC) Received: from filter.hostedemail.com (unknown [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 82037C2137; Tue, 12 May 2015 14:52:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::::::::::, RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:4321:4384:5007:6261:7576:9545:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12050:12296:12438:12517:12519:12555:12740:13095:13149:13161:13229:13230:21080, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0 X-HE-Tag: blood13_311db2dacd427 X-Filterd-Recvd-Size: 3317 Received: from joe-X200MA.home (pool-173-51-221-2.lsanca.fios.verizon.net [173.51.221.2]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Tue, 12 May 2015 14:52:17 +0000 (UTC) Message-ID: <1431442336.2884.57.camel@perches.com> Subject: Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster From: Joe Perches To: Rasmus Villemoes , Eugene Crosser , Frank Blaschka , Ursula Braun Cc: Kashyap Desai , Sumit Saxena , Uday Lingala , "James E.J. Bottomley" , "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 May 2015 07:52:16 -0700 In-Reply-To: <87iobx7uzv.fsf@rasmusvillemoes.dk> References: <1423233221-27069-1-git-send-email-linux@rasmusvillemoes.dk> <87iobx7uzv.fsf@rasmusvillemoes.dk> X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2015-05-12 at 16:04 +0200, Rasmus Villemoes wrote: > On Tue, Feb 10 2015, Kashyap Desai wrote: > > > Acked-by: Kashyap Desai > > > >> -----Original Message----- > >> From: Rasmus Villemoes [mailto:linux@rasmusvillemoes.dk] > >> Sent: Friday, February 06, 2015 8:04 PM > >> To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley > >> Cc: Rasmus Villemoes; megaraidlinux.pdl@avagotech.com; linux- > >> scsi@vger.kernel.org; linux-kernel@vger.kernel.org > >> Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster > >> > >> There is currently no %po format extension, so currently the letters > > "on" are > >> simply skipped and the pointer is printed as expected (while missing the > > word > >> on). However, it is probably only a matter of time before someone comes > > up > >> with a %po extension, at which point this is likely to fail > > spectacularly. > >> > >> Signed-off-by: Rasmus Villemoes > > Any chance either this minimal fix or Joe's more thorough cleanup could > get applied? There's still no %po extension, but there's certainly a lot > of proposals for more %p extensions flying around LKML, so I still think > the "only a matter of time" holds. There's also this one with %pM6: --- drivers/s390/net/qeth_l2_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c index 0ea0869..dc783047 100644 --- a/drivers/s390/net/qeth_l2_main.c +++ b/drivers/s390/net/qeth_l2_main.c @@ -1420,8 +1420,8 @@ static void qeth_bridge_emit_host_event(struct qeth_card *card, env[i] = str[i]; i++; } if (code & IPA_ADDR_CHANGE_CODE_MACADDR) { - snprintf(str[i], sizeof(str[i]), "MAC=%pM6", - &addr_lnid->mac); + snprintf(str[i], sizeof(str[i]), "MAC=%pM", + addr_lnid->mac); env[i] = str[i]; i++; } snprintf(str[i], sizeof(str[i]), "NTOK_BUSID=%x.%x.%04x",