From patchwork Tue May 12 15:01:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 6388961 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E0DABBEEE1 for ; Tue, 12 May 2015 15:01:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4709D2038D for ; Tue, 12 May 2015 15:01:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 823DB203E1 for ; Tue, 12 May 2015 15:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933327AbbELPBa (ORCPT ); Tue, 12 May 2015 11:01:30 -0400 Received: from smtprelay0013.hostedemail.com ([216.40.44.13]:40236 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932859AbbELPB2 (ORCPT ); Tue, 12 May 2015 11:01:28 -0400 Received: from filter.hostedemail.com (unknown [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id B3C649EA12; Tue, 12 May 2015 15:01:26 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::::::::::::::::, RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3871:3872:4321:5007:6117:6261:6742:7576:9545:10004:10400:10848:11026:11232:11658:11914:12043:12048:12050:12296:12438:12517:12519:12555:12740:13095:13149:13230:21080, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0 X-HE-Tag: owl49_80b0123df0e01 X-Filterd-Recvd-Size: 3597 Received: from joe-X200MA.home (pool-173-51-221-2.lsanca.fios.verizon.net [173.51.221.2]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Tue, 12 May 2015 15:01:24 +0000 (UTC) Message-ID: <1431442883.2884.59.camel@perches.com> Subject: Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster From: Joe Perches To: Rasmus Villemoes , Martin Schwidefsky , Heiko Carstens , linux390 Cc: Eugene Crosser , Frank Blaschka , Ursula Braun , Kashyap Desai , Sumit Saxena , Uday Lingala , "James E.J. Bottomley" , "PDL,MEGARAIDLINUX" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 12 May 2015 08:01:23 -0700 In-Reply-To: <1431442336.2884.57.camel@perches.com> References: <1423233221-27069-1-git-send-email-linux@rasmusvillemoes.dk> <87iobx7uzv.fsf@rasmusvillemoes.dk> <1431442336.2884.57.camel@perches.com> X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2015-05-12 at 07:52 -0700, Joe Perches wrote: > On Tue, 2015-05-12 at 16:04 +0200, Rasmus Villemoes wrote: > > On Tue, Feb 10 2015, Kashyap Desai wrote: > > > > > Acked-by: Kashyap Desai > > > > > >> -----Original Message----- > > >> From: Rasmus Villemoes [mailto:linux@rasmusvillemoes.dk] > > >> Sent: Friday, February 06, 2015 8:04 PM > > >> To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley > > >> Cc: Rasmus Villemoes; megaraidlinux.pdl@avagotech.com; linux- > > >> scsi@vger.kernel.org; linux-kernel@vger.kernel.org > > >> Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster > > >> > > >> There is currently no %po format extension, so currently the letters > > > "on" are > > >> simply skipped and the pointer is printed as expected (while missing the > > > word > > >> on). However, it is probably only a matter of time before someone comes > > > up > > >> with a %po extension, at which point this is likely to fail > > > spectacularly. > > >> > > >> Signed-off-by: Rasmus Villemoes > > > > Any chance either this minimal fix or Joe's more thorough cleanup could > > get applied? There's still no %po extension, but there's certainly a lot > > of proposals for more %p extensions flying around LKML, so I still think > > the "only a matter of time" holds. > > There's also this one with %pM6: And another with %ptail --- arch/s390/kernel/perf_cpum_sf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c index e6a1578..c0a4b87 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -205,7 +205,7 @@ static int realloc_sampling_buffer(struct sf_buffer *sfb, */ if (sfb->sdbt != get_next_sdbt(tail)) { debug_sprintf_event(sfdbg, 3, "realloc_sampling_buffer: " - "sampling buffer is not linked: origin=%p" + "sampling buffer is not linked: origin=%p " "tail=%p\n", (void *) sfb->sdbt, (void *) tail); return -EINVAL;