From patchwork Tue Jun 23 03:42:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maninder Singh X-Patchwork-Id: 6658771 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 716BB9F380 for ; Tue, 23 Jun 2015 03:44:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D6F8B205BC for ; Tue, 23 Jun 2015 03:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2D65205B9 for ; Tue, 23 Jun 2015 03:44:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbbFWDoO (ORCPT ); Mon, 22 Jun 2015 23:44:14 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:38277 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287AbbFWDoM (ORCPT ); Mon, 22 Jun 2015 23:44:12 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQD01W44P1MEMD0@mailout2.samsung.com>; Tue, 23 Jun 2015 12:44:10 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.125]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id B9.9D.17770.A06D8855; Tue, 23 Jun 2015 12:44:10 +0900 (KST) X-AuditID: cbfee691-f79ca6d00000456a-81-5588d60a717d Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id D3.A9.25346.A06D8855; Tue, 23 Jun 2015 12:44:10 +0900 (KST) Received: from localhost.localdomain ([107.108.92.210]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NQD00JMPP0Z51W1@mmp1.samsung.com>; Tue, 23 Jun 2015 12:44:09 +0900 (KST) From: Maninder Singh To: JBottomley@odin.com, hare@suse.de, hch@lst.de, michaelc@cs.wisc.edu, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: pankaj.m@samsung.com, Maninder Singh Subject: [PATCH 1/1] scsi: remove redundant NULL check before kfree Date: Tue, 23 Jun 2015 09:12:30 +0530 Message-id: <1435030950-35999-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsWyRsSkVpfrWkeowbPNghZ7Fk1isli5+iiT xf/1t1ksLu+aw2bRfX0Hm8Xh+W0sFsuP/2OyWPGmm9Hi3putTA6cHld/rWL22H2zgc3j8I8f zB4fn95i8ejbsorRY/Ppao/Pm+QC2KO4bFJSczLLUov07RK4Ml6v+8Ve8J6tomvlTrYGxg+s XYycHBICJhJ77hxlgbDFJC7cW8/WxcjFISSwlFGi6ddXFpiiplcgDSCJRYwSyw8sYYdwfjJK LHs9jw2kik1AT2LVrj1gHSICCxkl+h9rdjFycDALOElM/6oHYgoLOEtsOFMOUsEioCrRfP4C M0iYV8BdouNmDIgpIaAgMWeSDchwCYHp7BJ7f31jhigXkPg2+RALRI2sxKYDzBCXSUocXHGD ZQKj4AJGhlWMoqkFyQXFSelFpnrFibnFpXnpesn5uZsYgWF9+t+ziTsY7x+wPsQowMGoxMMr cLUjVIg1say4MvcQoynQhonMUqLJ+cDoySuJNzQ2M7IwNTE1NjK3NFMS59WR/hksJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgfEAh4bcaiYjlU23QnTeXljQ5O76eLElh6ktm/GC3F+fy+Lf SH94fPHmwd+2S6fWaB16lVNTozrhlUeSvrvl1I0S/FxXb3NX2u7s+pnS2uq6/EBcmurZ9Mzy uV/2Lyn78YWD86v3q7OS/z2NHjxM3ZbiFLr7u1lyrnWjxgqjnSxGsu/1Kw2PVyqxFGckGmox FxUnAgDVsTNlZgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t9jAV2uax2hBq83cFnsWTSJyWLl6qNM Fv/X32axuLxrDptF9/UdbBaH57exWCw//o/JYsWbbkaLe2+2Mjlwelz9tYrZY/fNBjaPwz9+ MHt8fHqLxaNvyypGj82nqz0+b5ILYI9qYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1 tLQwV1LIS8xNtVVy8QnQdcvMATpNSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EB GkhYw5jxet0v9oL3bBVdK3eyNTB+YO1i5OSQEDCRaHoFY4tJXLi3nq2LkYtDSGARo8TyA0vY IZyfjBLLXs9jA6liE9CTWLVrDwuILSKwkFGi/7FmFyMHB7OAk8T0r3ogprCAs8SGM+UgFSwC qhLN5y8wg4R5BdwlOm7GgJgSAgoScybZTGDkXsDIsIpRNLUguaA4KT3XUK84Mbe4NC9dLzk/ dxMjOGqeSe1gXNlgcYhRgINRiYc34UJHqBBrYllxZe4hRgkOZiURXleQEG9KYmVValF+fFFp TmrxIUZToN0TmaVEk/OBEZ1XEm9obGJuamxqaWJhYmapJM57Mt8nVEggPbEkNTs1tSC1CKaP iYNTqoHR6fTUlk+d1b4PI4IOPp9nUJdrtXK19PyFEyeE1r3ifmrvXtETbWg1c3LzvNgta6/a 7vqwJ3vOJKaYr/wLFzr126RP38HMr+Cx9r3zitMmTHY7q+Uev1j33vf6h8kzZPn0y40XVmRd ltRw+tBxbBGn8oenHw7kMe6uSS+bMk9gbt152wVyN83rlFiKMxINtZiLihMBQ+eV8LACAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no need of NULL check before kfree, So removing the same. Signed-off-by: Maninder Singh Reviewed-by: Rohit Thapliyal Reviewed-by: Hannes Reinecke --- drivers/scsi/aic94xx/aic94xx_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c index 4b135cc..a449fde 100644 --- a/drivers/scsi/aic94xx/aic94xx_init.c +++ b/drivers/scsi/aic94xx/aic94xx_init.c @@ -589,8 +589,7 @@ static void asd_destroy_ha_caches(struct asd_ha_struct *asd_ha) if (asd_ha->hw_prof.scb_ext) asd_free_coherent(asd_ha, asd_ha->hw_prof.scb_ext); - if (asd_ha->hw_prof.ddb_bitmap) - kfree(asd_ha->hw_prof.ddb_bitmap); + kfree(asd_ha->hw_prof.ddb_bitmap); asd_ha->hw_prof.ddb_bitmap = NULL; for (i = 0; i < ASD_MAX_PHYS; i++) {